* [PATCH] memstick: core: make memstick_bus_type const
@ 2024-02-04 20:05 Ricardo B. Marliere
2024-02-05 12:48 ` Greg Kroah-Hartman
2024-02-05 17:28 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 20:05 UTC (permalink / raw)
To: Maxim Levitsky, Alex Dubov, Ulf Hansson
Cc: linux-mmc, linux-kernel, Greg Kroah-Hartman, Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the memstick_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/memstick/core/memstick.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
index bbfaf6536903..23fea51ecbdd 100644
--- a/drivers/memstick/core/memstick.c
+++ b/drivers/memstick/core/memstick.c
@@ -164,7 +164,7 @@ static struct attribute *memstick_dev_attrs[] = {
};
ATTRIBUTE_GROUPS(memstick_dev);
-static struct bus_type memstick_bus_type = {
+static const struct bus_type memstick_bus_type = {
.name = "memstick",
.dev_groups = memstick_dev_groups,
.match = memstick_bus_match,
---
base-commit: 4e99ffb173faaf38f010acb369bff57a20e9e531
change-id: 20240204-bus_cleanup-memstick-071b3564d808
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] memstick: core: make memstick_bus_type const
2024-02-04 20:05 [PATCH] memstick: core: make memstick_bus_type const Ricardo B. Marliere
@ 2024-02-05 12:48 ` Greg Kroah-Hartman
2024-02-05 17:28 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:48 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Maxim Levitsky, Alex Dubov, Ulf Hansson, linux-mmc, linux-kernel
On Sun, Feb 04, 2024 at 05:05:58PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the memstick_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memstick: core: make memstick_bus_type const
2024-02-04 20:05 [PATCH] memstick: core: make memstick_bus_type const Ricardo B. Marliere
2024-02-05 12:48 ` Greg Kroah-Hartman
@ 2024-02-05 17:28 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-02-05 17:28 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Maxim Levitsky, Alex Dubov, linux-mmc, linux-kernel,
Greg Kroah-Hartman
On Sun, 4 Feb 2024 at 21:05, Ricardo B. Marliere <ricardo@marliere.net> wrote:
>
> Now that the driver core can properly handle constant struct bus_type,
> move the memstick_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/memstick/core/memstick.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
> index bbfaf6536903..23fea51ecbdd 100644
> --- a/drivers/memstick/core/memstick.c
> +++ b/drivers/memstick/core/memstick.c
> @@ -164,7 +164,7 @@ static struct attribute *memstick_dev_attrs[] = {
> };
> ATTRIBUTE_GROUPS(memstick_dev);
>
> -static struct bus_type memstick_bus_type = {
> +static const struct bus_type memstick_bus_type = {
> .name = "memstick",
> .dev_groups = memstick_dev_groups,
> .match = memstick_bus_match,
>
> ---
> base-commit: 4e99ffb173faaf38f010acb369bff57a20e9e531
> change-id: 20240204-bus_cleanup-memstick-071b3564d808
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-05 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 20:05 [PATCH] memstick: core: make memstick_bus_type const Ricardo B. Marliere
2024-02-05 12:48 ` Greg Kroah-Hartman
2024-02-05 17:28 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).