From: Erick Shepherd <erick.shepherd@ni.com>
To: <adrian.hunter@intel.com>
Cc: <brad.mouring@ni.com>, <erick.shepherd@ni.com>,
<gratian.crisan@emerson.com>, <kyle.roeschley@ni.com>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<ulf.hansson@linaro.org>
Subject: RE: [PATCH] mmc: core: Wait for Vdd to settle on card power off
Date: Fri, 7 Mar 2025 15:16:48 -0600 [thread overview]
Message-ID: <20250307211648.1289714-1-erick.shepherd@ni.com> (raw)
In-Reply-To: <440723b0-a1fa-4f9f-90f4-50dc831c68e5@intel.com>
> It probably should be dealt with in the ->set_power() callback.
> Is it one of the PCI devices in sdhci-pci-core.c?
Sure, I can move the delay to sdhci_set_power(). It looks like that
gets called right before the if-statement in the change I proposed
so the behavior should be the same, unless host->ops->set_power is set.
I believe we saw this failure on devices using the Intel Atom E3930
and E3940, which are Apollo Lake. It looks like there is an entry in
sdhci-pci-core.c. Does that change what we should do?
Regards,
Erick
next prev parent reply other threads:[~2025-03-07 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:46 [PATCH] mmc: core: Wait for Vdd to settle on card power off Erick Shepherd
2025-02-13 10:22 ` Avri Altman
2025-03-05 18:38 ` Adrian Hunter
2025-03-07 17:46 ` Erick Shepherd
2025-03-07 18:53 ` Adrian Hunter
2025-03-07 21:16 ` Erick Shepherd [this message]
2025-03-12 12:44 ` Adrian Hunter
2025-03-13 3:35 ` Erick Shepherd
2025-03-13 8:20 ` Adrian Hunter
2025-03-13 20:44 ` Erick Shepherd
2025-03-14 5:56 ` Adrian Hunter
-- strict thread matches above, loose matches on Subject: below --
2017-09-21 17:47 Kyle Roeschley
2017-09-22 9:38 ` Ulf Hansson
2017-09-22 13:57 ` Kyle Roeschley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307211648.1289714-1-erick.shepherd@ni.com \
--to=erick.shepherd@ni.com \
--cc=adrian.hunter@intel.com \
--cc=brad.mouring@ni.com \
--cc=gratian.crisan@emerson.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox