From: Frank Li <Frank.Li@nxp.com>
To: adrian.hunter@intel.com, ulf.hansson@linaro.org, haibo.chen@nxp.com
Cc: Frank Li <frank.li@nxp.com>,
Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, imx@lists.linux.dev,
linux-mmc@vger.kernel.org, s32@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support
Date: Tue, 3 Mar 2026 16:00:59 -0500 [thread overview]
Message-ID: <20260303210131.2966214-4-Frank.Li@nxp.com> (raw)
In-Reply-To: <20260303105006.989339-3-ziniu.wang_1@nxp.com>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
> + sdhci_get_property(pdev);
> +
Missing argument: sdhci_get_property() expects (struct sdhci_host *host)
as second parameter, not just pdev. Check function signature in
sdhci.h.
> - if (of_property_read_bool(np, "no-1-8-v"))
> - host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
Removal looks correct if sdhci_get_property() truly handles "no-1-8-v"
internally. Verify this is documented in the commit message or code
comment to avoid future confusion.
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> index 97461e20425d..b607d4ffc562 100644
Line length at hunk context appears OK (under 80 chars).
---
AI bot review and may be useless.
next prev parent reply other threads:[~2026-03-03 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:50 [PATCH v2 0/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support ziniu.wang_1
2026-03-03 10:50 ` [PATCH v2 1/4] mmc: sdhci: fix timing selection for 1-bit bus width ziniu.wang_1
2026-03-03 21:00 ` Frank Li
2026-03-11 9:05 ` Adrian Hunter
2026-03-11 9:19 ` [EXT] " Luke Wang
2026-03-03 10:50 ` [PATCH v2 2/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support ziniu.wang_1
2026-03-03 21:00 ` Frank Li [this message]
2026-03-11 9:05 ` Adrian Hunter
2026-03-03 10:50 ` [PATCH v2 3/4] mmc: sdhci-esdhc-imx: remove duplicate HS400 bus width validation ziniu.wang_1
2026-03-03 21:01 ` Frank Li
2026-03-11 9:05 ` Adrian Hunter
2026-03-03 10:50 ` [PATCH v2 4/4] mmc: sdhci-pltfm: remove duplicate DTS property parsing ziniu.wang_1
2026-03-03 21:01 ` Frank Li
2026-03-11 9:08 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303210131.2966214-4-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox