From: Frank Li <Frank.Li@nxp.com>
To: adrian.hunter@intel.com, ulf.hansson@linaro.org, haibo.chen@nxp.com
Cc: Frank Li <frank.li@nxp.com>,
Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, imx@lists.linux.dev,
linux-mmc@vger.kernel.org, s32@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mmc: sdhci-esdhc-imx: remove duplicate HS400 bus width validation
Date: Tue, 3 Mar 2026 16:01:00 -0500 [thread overview]
Message-ID: <20260303210131.2966214-5-Frank.Li@nxp.com> (raw)
In-Reply-To: <20260303105006.989339-4-ziniu.wang_1@nxp.com>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
AI bot review and may be useless.
The patch looks correct. The removal of duplicate validation is justified by
the commit message stating that mmc_validate_host_caps() already performs
this check.
A few observations:
> - /* HS400/HS400ES require 8 bit bus */
> - if (!(host->mmc->caps & MMC_CAP_8_BIT_DATA))
> - host->mmc->caps2 &= ~(MMC_CAP2_HS400 | MMC_CAP2_HS400_ES);
> -
Consider verifying in a follow-up that mmc_validate_host_caps() is indeed
called after sdhci_get_property() in the probe flow, to ensure no window
exists where invalid caps could be exposed to userspace or other subsystems.
The code removal itself is clean with no resource leaks or locking issues in
the deleted section.
next prev parent reply other threads:[~2026-03-03 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:50 [PATCH v2 0/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support ziniu.wang_1
2026-03-03 10:50 ` [PATCH v2 1/4] mmc: sdhci: fix timing selection for 1-bit bus width ziniu.wang_1
2026-03-03 21:00 ` Frank Li
2026-03-11 9:05 ` Adrian Hunter
2026-03-11 9:19 ` [EXT] " Luke Wang
2026-03-03 10:50 ` [PATCH v2 2/4] mmc: sdhci-esdhc-imx: add 1-bit bus width support ziniu.wang_1
2026-03-03 21:00 ` Frank Li
2026-03-11 9:05 ` Adrian Hunter
2026-03-03 10:50 ` [PATCH v2 3/4] mmc: sdhci-esdhc-imx: remove duplicate HS400 bus width validation ziniu.wang_1
2026-03-03 21:01 ` Frank Li [this message]
2026-03-11 9:05 ` Adrian Hunter
2026-03-03 10:50 ` [PATCH v2 4/4] mmc: sdhci-pltfm: remove duplicate DTS property parsing ziniu.wang_1
2026-03-03 21:01 ` Frank Li
2026-03-11 9:08 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303210131.2966214-5-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox