Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Sean Rhodes <sean@starlabs.systems>
To: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ricky Wu <ricky_wu@realtek.com>,
	Avri Altman <avri.altman@sandisk.com>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Jisheng Zhang <jszhang@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Huacai Chen <chenhuacai@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/6] rtsx_usb_sdmmc: tray CD fix + UHS + runtime PM
Date: Thu,  5 Mar 2026 19:40:46 +0000	[thread overview]
Message-ID: <20260305194052.5120-1-sean@starlabs.systems> (raw)
In-Reply-To: <1ca7b488a11e03b3f107f1829a40cf2c92c7d5fd.1771533586.git.sean@starlabs.systems>

Hi,

Some Realtek USB SD readers with a tray can assert SD_CD when only the
tray is inserted. This can lead to false card-detect, unnecessary card
initialization, and in the worst case suspend/shutdown failures when the
MMC core waits for a non-existent card.

This series hardens card detection by debouncing SD_CD and validating a
new insertion by probing for card responses before reporting it present.
It then brings rtsx_usb_sdmmc closer to the previously shipped Realtek
behaviour (excluding xD/CPRM) for power-up and UHS signalling, and fixes
runtime PM corner cases around USB transfers.

The insertion validation approach is intentionally conservative and is
aligned with the older Realtek rts5139 staging driver (drivers/staging/
rts5139), which was removed in:
  00d8521dcd236d1b8f664f54a0309e96bfdcb4f9
  ("staging: remove rts5139 driver code", 2014-05-23)

This is a resend as v2; the original standalone submission of patch 1
was sent on 2026-02-19 with Message-ID:
  <1ca7b488a11e03b3f107f1829a40cf2c92c7d5fd.1771533586.git.sean@starlabs.systems>

Testing (v6.18-rc4 based):
- Readers: Realtek RTS5129, Realtek RTS5170, Realtek
  RTS51379
- Tests (all readers): cold-boot detection (card present at power-on),
  hotplug insert/remove, and suspend pm_test=devices
- Tray behaviour (tray readers): tray inserted/no card does not create a
  phantom mmc device; insert/remove transitions are reported correctly
- Card modes/speeds: UHS-I SDXC cards negotiate UHS SDR104 (1.8V,
  208MHz) where supported by the reader/card; non-UHS cards fall back to
  SD High Speed (50MHz)

Thanks,
Sean Rhodes

Sean Rhodes (6):
  mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers
  mmc: rtsx_usb_sdmmc: start card power-up at 3.3V
  mmc: rtsx_usb_sdmmc: advertise UHS SDR104 and DDR50
  mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25
  rtsx_usb: hold runtime PM during transfers
  rtsx_usb: avoid USB I/O in runtime autosuspend

 drivers/misc/cardreader/rtsx_usb.c |  49 +++++++--
 drivers/mmc/host/rtsx_usb_sdmmc.c  | 167 +++++++++++++++++++++++++++--
 include/linux/rtsx_usb.h           |   3 +
 3 files changed, 199 insertions(+), 20 deletions(-)

-- 
2.51.0

  reply	other threads:[~2026-03-05 19:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 20:39 [PATCH] mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers Sean Rhodes
2026-03-05 19:40 ` Sean Rhodes [this message]
2026-03-05 19:40   ` [PATCH v2 1/6] " Sean Rhodes
2026-03-05 19:40   ` [PATCH v2 2/6] mmc: rtsx_usb_sdmmc: start card power-up at 3.3V Sean Rhodes
2026-03-05 19:40   ` [PATCH v2 3/6] mmc: rtsx_usb_sdmmc: advertise UHS SDR104 and DDR50 Sean Rhodes
2026-03-05 19:40   ` [PATCH v2 4/6] mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25 Sean Rhodes
2026-03-05 19:40   ` [PATCH v2 5/6] rtsx_usb: hold runtime PM during transfers Sean Rhodes
2026-03-05 19:40   ` [PATCH v2 6/6] rtsx_usb: avoid USB I/O in runtime autosuspend Sean Rhodes
2026-03-12 12:15   ` [PATCH v2 RESEND 0/6] rtsx_usb_sdmmc: tray CD fix + UHS + runtime PM Sean Rhodes
2026-03-12 12:15     ` [PATCH v2 RESEND 1/6] mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers Sean Rhodes
2026-03-24 11:26       ` Ulf Hansson
2026-03-24 11:27         ` Ulf Hansson
2026-03-24 11:59         ` Sean Rhodes
2026-03-24 12:23           ` Ulf Hansson
2026-03-24 12:30             ` Sean Rhodes
2026-03-24 12:57               ` Ulf Hansson
2026-03-24 13:13                 ` Sean Rhodes
2026-03-24 13:34                   ` Ulf Hansson
2026-03-12 12:15     ` [PATCH v2 RESEND 2/6] mmc: rtsx_usb_sdmmc: start card power-up at 3.3V Sean Rhodes
2026-03-24 11:41       ` Ulf Hansson
2026-03-24 12:02         ` Sean Rhodes
2026-03-12 12:15     ` [PATCH v2 RESEND 3/6] mmc: rtsx_usb_sdmmc: advertise UHS SDR104 and DDR50 Sean Rhodes
2026-03-24 11:49       ` Ulf Hansson
2026-03-12 12:15     ` [PATCH v2 RESEND 4/6] mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25 Sean Rhodes
2026-03-12 12:15     ` [PATCH v2 RESEND 5/6] rtsx_usb: hold runtime PM during transfers Sean Rhodes
2026-03-24 12:10       ` Ulf Hansson
2026-03-12 12:15     ` [PATCH v2 RESEND 6/6] rtsx_usb: avoid USB I/O in runtime autosuspend Sean Rhodes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305194052.5120-1-sean@starlabs.systems \
    --to=sean@starlabs.systems \
    --cc=arnd@arndb.de \
    --cc=avri.altman@sandisk.com \
    --cc=chenhuacai@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jszhang@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ricky_wu@realtek.com \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox