From: Sean Rhodes <sean@starlabs.systems>
To: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ricky Wu <ricky_wu@realtek.com>,
Avri Altman <avri.altman@sandisk.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Dan Carpenter <dan.carpenter@linaro.org>,
Jisheng Zhang <jszhang@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Huacai Chen <chenhuacai@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/6] mmc: rtsx_usb_sdmmc: start card power-up at 3.3V
Date: Thu, 5 Mar 2026 19:40:48 +0000 [thread overview]
Message-ID: <20260305194052.5120-3-sean@starlabs.systems> (raw)
In-Reply-To: <20260305194052.5120-1-sean@starlabs.systems>
Some tray-based readers keep SD_CD asserted even without a card. The
rtsx_usb_sdmmc driver now validates insertion with a minimal probe
sequence. That probe must start with the SD pads in 3.3V mode.
Like the old rts5139 driver (sd_init_power()), force the SD pads to
3.3V and tune the SD18 regulator to 3.3V before powering up the card.
This avoids spurious probe timeouts when the reader is left in 1.8V
from a previous UHS session.
Tested: Realtek RTS5129 (0bda:0129) + tray + Lexar 2TB SDXC
Tested: cold boot detects mmcblk0 (2026-02-24)
Tested: hotplug insert enumerates mmcblk0 (2026-02-23)
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index ec3eeea78e95..6be98926387d 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -1108,6 +1108,11 @@ static int sd_power_on(struct rtsx_usb_sdmmc *host)
}
dev_dbg(sdmmc_dev(host), "%s\n", __func__);
rtsx_usb_init_cmd(ucr);
+ /* Start SD init at 3.3V, like the old rts5139 driver. */
+ rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, SD_PAD_CTL,
+ SD_IO_USING_1V8, SD_IO_USING_3V3);
+ rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, LDO_POWER_CFG,
+ TUNE_SD18_MASK, TUNE_SD18_3V3);
rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, CARD_SELECT, 0x07, SD_MOD_SEL);
rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, CARD_SHARE_MODE,
CARD_SHARE_MASK, CARD_SHARE_SD);
--
2.51.0
next prev parent reply other threads:[~2026-03-05 19:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 20:39 [PATCH] mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers Sean Rhodes
2026-03-05 19:40 ` [PATCH v2 0/6] rtsx_usb_sdmmc: tray CD fix + UHS + runtime PM Sean Rhodes
2026-03-05 19:40 ` [PATCH v2 1/6] mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers Sean Rhodes
2026-03-05 19:40 ` Sean Rhodes [this message]
2026-03-05 19:40 ` [PATCH v2 3/6] mmc: rtsx_usb_sdmmc: advertise UHS SDR104 and DDR50 Sean Rhodes
2026-03-05 19:40 ` [PATCH v2 4/6] mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25 Sean Rhodes
2026-03-05 19:40 ` [PATCH v2 5/6] rtsx_usb: hold runtime PM during transfers Sean Rhodes
2026-03-05 19:40 ` [PATCH v2 6/6] rtsx_usb: avoid USB I/O in runtime autosuspend Sean Rhodes
2026-03-12 12:15 ` [PATCH v2 RESEND 0/6] rtsx_usb_sdmmc: tray CD fix + UHS + runtime PM Sean Rhodes
2026-03-12 12:15 ` [PATCH v2 RESEND 1/6] mmc: rtsx_usb_sdmmc: avoid false card-detect on tray readers Sean Rhodes
2026-03-24 11:26 ` Ulf Hansson
2026-03-24 11:27 ` Ulf Hansson
2026-03-24 11:59 ` Sean Rhodes
2026-03-24 12:23 ` Ulf Hansson
2026-03-24 12:30 ` Sean Rhodes
2026-03-24 12:57 ` Ulf Hansson
2026-03-24 13:13 ` Sean Rhodes
2026-03-24 13:34 ` Ulf Hansson
2026-03-12 12:15 ` [PATCH v2 RESEND 2/6] mmc: rtsx_usb_sdmmc: start card power-up at 3.3V Sean Rhodes
2026-03-24 11:41 ` Ulf Hansson
2026-03-24 12:02 ` Sean Rhodes
2026-03-12 12:15 ` [PATCH v2 RESEND 3/6] mmc: rtsx_usb_sdmmc: advertise UHS SDR104 and DDR50 Sean Rhodes
2026-03-24 11:49 ` Ulf Hansson
2026-03-12 12:15 ` [PATCH v2 RESEND 4/6] mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25 Sean Rhodes
2026-03-12 12:15 ` [PATCH v2 RESEND 5/6] rtsx_usb: hold runtime PM during transfers Sean Rhodes
2026-03-24 12:10 ` Ulf Hansson
2026-03-12 12:15 ` [PATCH v2 RESEND 6/6] rtsx_usb: avoid USB I/O in runtime autosuspend Sean Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305194052.5120-3-sean@starlabs.systems \
--to=sean@starlabs.systems \
--cc=arnd@arndb.de \
--cc=avri.altman@sandisk.com \
--cc=chenhuacai@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=ricky_wu@realtek.com \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox