Linux MultiMedia Card development
 help / color / mirror / Atom feed
* [PATCH] mmc: rtsx_pci_sdmmc: ignore broken write-protect on ThinkPad X260
@ 2026-08-24  6:57 Florian Maillard
  2026-09-10 16:05 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Maillard @ 2026-08-24  6:57 UTC (permalink / raw)
  To: Ulf Hansson; +Cc: linux-mmc, linux-kernel, Florian Maillard

The Realtek RTS522A card reader in the Lenovo ThinkPad X260
(subsystem 17aa:504a) incorrectly reports inserted SD cards as
write-protected.

This causes the MMC core to expose the card as read-only:

  mmcblk0: mmc0:aaaa SN256 238 GiB (ro)

and /sys/block/mmcblk0/ro reports 1.

Setting MMC_CAP2_NO_WRITE_PROTECT makes the card writable again.
Limit the quirk to the affected Lenovo subsystem.

Assisted-by: ChatGPT:GPT-5.6 Sol
Signed-off-by: Florian Maillard <florian.maillard@mailoo.org>
---
 drivers/mmc/host/rtsx_pci_sdmmc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 8dfbc62f16..d25d4cb59b 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -1425,6 +1425,11 @@ static void realtek_init_host(struct realtek_pci_sdmmc *host)
 		mmc->caps = mmc->caps | MMC_CAP_AGGRESSIVE_PM;
 	mmc->caps2 = MMC_CAP2_NO_PRESCAN_POWERUP | MMC_CAP2_FULL_PWR_CYCLE |
 		MMC_CAP2_NO_SDIO;
+
+	if (pcr->pci->device == 0x522a &&
+	    pcr->pci->subsystem_vendor == PCI_VENDOR_ID_LENOVO &&
+	    pcr->pci->subsystem_device == 0x504a)
+		mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT;
 	mmc->max_current_330 = 400;
 	mmc->max_current_180 = 800;
 	mmc->ops = &realtek_pci_sdmmc_ops;

base-commit: 388b607d107c07aaade04c7f22f344cab6bdccd3
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: rtsx_pci_sdmmc: ignore broken write-protect on ThinkPad X260
  2026-08-24  6:57 [PATCH] mmc: rtsx_pci_sdmmc: ignore broken write-protect on ThinkPad X260 Florian Maillard
@ 2026-09-10 16:05 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2026-09-10 16:05 UTC (permalink / raw)
  To: Florian Maillard; +Cc: Ulf Hansson, linux-mmc, linux-kernel

On Mon, Aug 24, 2026 at 8:58 AM Florian Maillard
<florian.maillard@mailoo.org> wrote:
>
> The Realtek RTS522A card reader in the Lenovo ThinkPad X260
> (subsystem 17aa:504a) incorrectly reports inserted SD cards as
> write-protected.
>
> This causes the MMC core to expose the card as read-only:
>
>   mmcblk0: mmc0:aaaa SN256 238 GiB (ro)
>
> and /sys/block/mmcblk0/ro reports 1.
>
> Setting MMC_CAP2_NO_WRITE_PROTECT makes the card writable again.
> Limit the quirk to the affected Lenovo subsystem.
>
> Assisted-by: ChatGPT:GPT-5.6 Sol
> Signed-off-by: Florian Maillard <florian.maillard@mailoo.org>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/rtsx_pci_sdmmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index 8dfbc62f16..d25d4cb59b 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -1425,6 +1425,11 @@ static void realtek_init_host(struct realtek_pci_sdmmc *host)
>                 mmc->caps = mmc->caps | MMC_CAP_AGGRESSIVE_PM;
>         mmc->caps2 = MMC_CAP2_NO_PRESCAN_POWERUP | MMC_CAP2_FULL_PWR_CYCLE |
>                 MMC_CAP2_NO_SDIO;
> +
> +       if (pcr->pci->device == 0x522a &&
> +           pcr->pci->subsystem_vendor == PCI_VENDOR_ID_LENOVO &&
> +           pcr->pci->subsystem_device == 0x504a)
> +               mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT;
>         mmc->max_current_330 = 400;
>         mmc->max_current_180 = 800;
>         mmc->ops = &realtek_pci_sdmmc_ops;
>
> base-commit: 388b607d107c07aaade04c7f22f344cab6bdccd3
> --
> 2.47.3
>
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-10 16:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24  6:57 [PATCH] mmc: rtsx_pci_sdmmc: ignore broken write-protect on ThinkPad X260 Florian Maillard
2026-09-10 16:05 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox