From: Shawn Lin <shawn.lin@rock-chips.com>
To: Uri Yanai <uri.yanai@sandisk.com>
Cc: ulf.hansson@linaro.org, shawn.lin@rock-chips.com,
linux-mmc@vger.kernel.org, chris@printf.net,
alex.lemberg@sandisk.com
Subject: Re: [PATCH 0/3] Auto BKOPS PM suspend
Date: Wed, 18 Jan 2017 09:53:50 +0800 [thread overview]
Message-ID: <30196abc-e340-2b7f-0ad2-d644a0d78b49@rock-chips.com> (raw)
In-Reply-To: <1484655337-32562-1-git-send-email-uri.yanai@sandisk.com>
Hi Uri,
On 2017/1/17 20:15, Uri Yanai wrote:
> Hi Ulf
> Resubmitting three patches for approval, originally submitted by Alex Lemberg <alex.lemberg@sandisk.com>
> [1/3] mmc: replacing hardcoded value for runtime PM suspend Message ID:<1472739890-3384-2-git-send-email-alex.lemberg@sandisk.com>
> [2/3] mmc: Adding AUTO_BKOPS_EN bit set for Auto BKOPS support Message ID:<1472739890-3384-3-git-send-email-alex.lemberg@sandisk.com>
> [3/3] mmc: Checking BKOPS status prior to Suspend Message ID:<1472739890-3384-4-git-send-email-alex.lemberg@sandisk.com>
>
> Thanks
> Uri Yanai
Firstly, the authorship isn't correct and of course the SOB path.
Then, it'd better to add a changelog since you do improve Alex's
patches, and it would help us to better understand what was changed. :)
Also you should remove Change-Id when fetching patches from your
internal code review system.
Anyway, let's talk about the patches themself, I have
a question for your patch 3/3 there.
>
> Uri Yanai (3):
> mmc: replacing hardcoded value for runtime PM suspend
> mmc: Adding AUTO_BKOPS_EN bit set for Auto BKOPS support
> mmc: Checking BKOPS status prior to Suspend
>
> drivers/mmc/core/block.c | 3 ++-
> drivers/mmc/core/mmc.c | 45 ++++++++++++++++++++++++++++++++++++---------
> include/linux/mmc/card.h | 1 +
> include/linux/mmc/host.h | 2 ++
> include/linux/mmc/mmc.h | 3 +++
> 5 files changed, 44 insertions(+), 10 deletions(-)
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2017-01-18 2:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 12:15 [PATCH 0/3] Auto BKOPS PM suspend Uri Yanai
2017-01-17 12:15 ` [PATCH 1/3] mmc: replacing hardcoded value for runtime " Uri Yanai
2017-01-17 12:15 ` [PATCH 2/3] mmc: Adding AUTO_BKOPS_EN bit set for Auto BKOPS support Uri Yanai
2017-01-17 12:15 ` [PATCH 3/3] mmc: Checking BKOPS status prior to Suspend Uri Yanai
2017-01-18 1:59 ` Shawn Lin
2017-01-18 15:01 ` Uri Yanai
2017-01-20 11:56 ` Adrian Hunter
2017-01-22 15:55 ` Uri Yanai
2017-01-23 17:07 ` Alex Lemberg
2017-01-24 14:36 ` Adrian Hunter
2017-01-25 9:48 ` Alex Lemberg
2017-01-25 10:30 ` Adrian Hunter
2017-01-25 12:40 ` Alex Lemberg
2017-01-25 12:45 ` Adrian Hunter
2017-01-25 13:42 ` Alex Lemberg
2017-01-18 1:53 ` Shawn Lin [this message]
2017-01-18 14:12 ` [PATCH 0/3] Auto BKOPS PM suspend Uri Yanai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30196abc-e340-2b7f-0ad2-d644a0d78b49@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=alex.lemberg@sandisk.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=uri.yanai@sandisk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox