[PATCH v3 0/2] Update sdhci-atmel dt-binding documentation

[PATCH v3 0/2] Update sdhci-atmel dt-binding documentation

[Dharma Balasubiramani]

This patch series converts the sdhci-atmel dt-binding to yaml format and adds
the sama7d65,sama7g5 compatibles to the list.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
Changes in v3:
- update the items in clocks instead of plain description.
- move the items list to clock-names.
- since baseclk is must, change maxitems to minitems: 3, and modify the
  conditional bits accordingly.
- Link to v2: https://lore.kernel.org/r/20240830-atmel-sdhci-v2-0-b7f58973f3fc@microchip.com

Changes in v2:
- Add missing deleted file to the patch 
"Documentation/devicetree/bindings/mmc/sdhci-atmel.txt"
- Link to v1: https://lore.kernel.org/r/20240830-atmel-sdhci-v1-0-01e3ec8c9804@microchip.com

---
Dharma Balasubiramani (2):
      dt-bindings: mmc: sdhci-atmel: Convert to json schema
      dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

 .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 95 ++++++++++++++++++++++
 .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 --------
 2 files changed, 95 insertions(+), 35 deletions(-)
---
base-commit: 4b7d983dd85a5cdf4938f4a0a93adedf697ac04d
change-id: 20240830-atmel-sdhci-c9a92b710624

Best regards,
-- 
Dharma Balasubiramani <dharma.b@microchip.com>

[PATCH v3 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema

[Dharma Balasubiramani]

Convert sdhci-atmel documentation to yaml format. The new file will inherit
from sdhci-common.yaml.

Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
in the DT.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 90 ++++++++++++++++++++++
 .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 ---------
 2 files changed, 90 insertions(+), 35 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
new file mode 100644
index 000000000000..ba4786328833
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel SDHCI controller
+
+maintainers:
+  - Aubin Constans <aubin.constans@microchip.com>
+  - Nicolas Ferre <nicolas.ferre@microchip.com>
+
+description:
+  Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - atmel,sama5d2-sdhci
+          - atmel,sama5d3-sdhci
+          - atmel,sama5d4-sdhci
+          - microchip,sam9x60-sdhci
+      - items:
+          - enum:
+              - microchip,sama7g5-sdhci
+          - const: microchip,sam9x60-sdhci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: hclock
+      - description: multclk
+      - description: baseclk
+    minItems: 2
+
+  clock-names:
+    items:
+      - const: hclock
+      - const: multclk
+      - const: baseclk
+    minItems: 2
+
+  microchip,sdcal-inverted:
+    type: boolean
+    description:
+      When present, polarity on the SDCAL SoC pin is inverted.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+allOf:
+  - $ref: sdhci-common.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - atmel,sama5d2-sdhci
+    then:
+      properties:
+        clocks:
+          minItems: 3
+        clock-names:
+          minItems: 3
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/at91.h>
+    mmc@a0000000 {
+        compatible = "atmel,sama5d2-sdhci";
+        reg = <0xa0000000 0x300>;
+        interrupts = <31 IRQ_TYPE_LEVEL_HIGH 0>;
+        clocks = <&sdmmc0_hclk>, <&sdmmc0_gclk>, <&main>;
+        clock-names = "hclock", "multclk", "baseclk";
+        assigned-clocks = <&sdmmc0_gclk>;
+        assigned-clock-rates = <480000000>;
+    };
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt b/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt
deleted file mode 100644
index a9fb0a91245f..000000000000
--- a/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-* Atmel SDHCI controller
-
-This file documents the differences between the core properties in
-Documentation/devicetree/bindings/mmc/mmc.txt and the properties used by the
-sdhci-of-at91 driver.
-
-Required properties:
-- compatible:		Must be "atmel,sama5d2-sdhci" or "microchip,sam9x60-sdhci"
-			or "microchip,sam9x7-sdhci", "microchip,sam9x60-sdhci".
-- clocks:		Phandlers to the clocks.
-- clock-names:		Must be "hclock", "multclk", "baseclk" for
-			"atmel,sama5d2-sdhci".
-			Must be "hclock", "multclk" for "microchip,sam9x60-sdhci".
-			Must be "hclock", "multclk" for "microchip,sam9x7-sdhci".
-
-Optional properties:
-- assigned-clocks:	The same with "multclk".
-- assigned-clock-rates	The rate of "multclk" in order to not rely on the
-			gck configuration set by previous components.
-- microchip,sdcal-inverted: when present, polarity on the SDCAL SoC pin is
-  inverted. The default polarity for this signal is described in the datasheet.
-  For instance on SAMA5D2, the pin is usually tied to the GND with a resistor
-  and a capacitor (see "SDMMC I/O Calibration" chapter).
-
-Example:
-
-mmc0: sdio-host@a0000000 {
-	compatible = "atmel,sama5d2-sdhci";
-	reg = <0xa0000000 0x300>;
-	interrupts = <31 IRQ_TYPE_LEVEL_HIGH 0>;
-	clocks = <&sdmmc0_hclk>, <&sdmmc0_gclk>, <&main>;
-	clock-names = "hclock", "multclk", "baseclk";
-	assigned-clocks = <&sdmmc0_gclk>;
-	assigned-clock-rates = <480000000>;
-};

-- 
2.43.0

[PATCH v3 2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

[Dharma Balasubiramani]

Add mmc binding documentation for sama7d65.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
index ba4786328833..a7c0ce201a5c 100644
--- a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
@@ -25,6 +25,11 @@ properties:
           - enum:
               - microchip,sama7g5-sdhci
           - const: microchip,sam9x60-sdhci
+      - items:
+          - enum:
+              - microchip,sama7d65-sdhci
+          - const: microchip,sama7g5-sdhci
+          - const: microchip,sam9x60-sdhci
 
   reg:
     maxItems: 1

-- 
2.43.0

Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema

[Krzysztof Kozlowski]

On Fri, Aug 30, 2024 at 08:21:20PM +0530, Dharma Balasubiramani wrote:
> Convert sdhci-atmel documentation to yaml format. The new file will inherit
> from sdhci-common.yaml.
> 
> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
> in the DT.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>  .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 90 ++++++++++++++++++++++
>  .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 ---------
>  2 files changed, 90 insertions(+), 35 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> new file mode 100644
> index 000000000000..ba4786328833
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel SDHCI controller
> +
> +maintainers:
> +  - Aubin Constans <aubin.constans@microchip.com>
> +  - Nicolas Ferre <nicolas.ferre@microchip.com>
> +
> +description:
> +  Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - atmel,sama5d2-sdhci
> +          - atmel,sama5d3-sdhci

This wasn't in the old binding.

> +          - atmel,sama5d4-sdhci

Neither this.

> +          - microchip,sam9x60-sdhci
> +      - items:
> +          - enum:
> +              - microchip,sama7g5-sdhci
> +          - const: microchip,sam9x60-sdhci

What happened with microchip,sam9x7-sdhci compatible from the old binding?

And none of above changes are explained in commit msg.



Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

[Krzysztof Kozlowski]

On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
> Add mmc binding documentation for sama7d65.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>  Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Where is any user of this? Why are you adding bindings without users?

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema

[Dharma.B]

Hi Krzysztof,

On 31/08/24 11:49 am, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Aug 30, 2024 at 08:21:20PM +0530, Dharma Balasubiramani wrote:
>> Convert sdhci-atmel documentation to yaml format. The new file will inherit
>> from sdhci-common.yaml.
>>
>> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
>> in the DT.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> ---
>>   .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 90 ++++++++++++++++++++++
>>   .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 ---------
>>   2 files changed, 90 insertions(+), 35 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
>> new file mode 100644
>> index 000000000000..ba4786328833
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
>> @@ -0,0 +1,90 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel SDHCI controller
>> +
>> +maintainers:
>> +  - Aubin Constans <aubin.constans@microchip.com>
>> +  - Nicolas Ferre <nicolas.ferre@microchip.com>
>> +
>> +description:
>> +  Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - enum:
>> +          - atmel,sama5d2-sdhci
>> +          - atmel,sama5d3-sdhci
> 
> This wasn't in the old binding.
> 
>> +          - atmel,sama5d4-sdhci
> 
> Neither this.

My bad, I accidentally added those compatibles that are not present in 
the old binding or the DTS files.

> 
>> +          - microchip,sam9x60-sdhci
>> +      - items:
>> +          - enum:
>> +              - microchip,sama7g5-sdhci
>> +          - const: microchip,sam9x60-sdhci
> 
> What happened with microchip,sam9x7-sdhci compatible from the old binding?
> 
> And none of above changes are explained in commit msg.

Since there are no users of microchip,sam9x7-sdhci compatible from the 
old binding I missed adding it during the conversion.

I'll correct these issues and make the necessary adjustments (remove the 
"atmel,sama5d3-sdhci" and "atmel,sama5d4-sdhci" compatibles and add back 
the "microchip,sam9x7-sdhci" compatible) in the next revision of this 
patch series.

Thanks.

> 
> 
> 
> Best regards,
> Krzysztof
> 
> 


-- 
With Best Regards,
Dharma B.

Re: [PATCH v3 2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

[Dharma.B]

Hi Krzysztof,

On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>> Add mmc binding documentation for sama7d65.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> ---
>>   Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> 
> Where is any user of this? Why are you adding bindings without users?

We will upstream the sama7d65 board dts files soon, hence adding support 
for it before hand in bindings.

> 
> Best regards,
> Krzysztof
> 


-- 
With Best Regards,
Dharma B.

Re: [PATCH v3 2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

[Krzysztof Kozlowski]

On 31/08/2024 09:51, Dharma.B@microchip.com wrote:
> Hi Krzysztof,
> 
> On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>>> Add mmc binding documentation for sama7d65.
>>>
>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>
>> Where is any user of this? Why are you adding bindings without users?
> 
> We will upstream the sama7d65 board dts files soon, hence adding support 
> for it before hand in bindings.
> 

Not soon. Two of your other postings are clearly wrongly split, so I
don't trust this one either.

Post everything. Your drivers with their bindings. Your DTS goes with
board bindings, in separate patchset (one!) with lore link to the driver
bindings so we can verify it.

Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

[Dharma.B]

On 31/08/24 7:11 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 31/08/2024 09:51, Dharma.B@microchip.com wrote:
>> Hi Krzysztof,
>>
>> On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>>>> Add mmc binding documentation for sama7d65.
>>>>
>>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>
>>> Where is any user of this? Why are you adding bindings without users?
>>
>> We will upstream the sama7d65 board dts files soon, hence adding support
>> for it before hand in bindings.
>>
> 
> Not soon. Two of your other postings are clearly wrongly split, so I
> don't trust this one either.
> 
> Post everything. Your drivers with their bindings. Your DTS goes with
> board bindings, in separate patchset (one!) with lore link to the driver
> bindings so we can verify it.

Okay, I will drop this now, I will just send the conversion from text to 
json in the next revision of this patch.

Will send it along with the dts as you suggest.
Thanks.

> 
> Best regards,
> Krzysztof
> 


-- 
With Best Regards,
Dharma B.