From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: Pavan Kondeti <quic_pkondeti@quicinc.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <andersson@kernel.org>,
<agross@kernel.org>, <konrad.dybcio@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<conor+dt@kernel.org>, <robdclark@gmail.com>,
<quic_abhinavk@quicinc.com>, <dmitry.baryshkov@linaro.org>,
<sean@poorly.run>, <marijn.suijten@somainline.org>,
<airlied@gmail.com>, <daniel@ffwll.ch>,
<stanimir.k.varbanov@gmail.com>, <quic_vgarodia@quicinc.com>,
<mchehab@kernel.org>, <ulf.hansson@linaro.org>,
<mathieu.poirier@linaro.org>, <jonathan@marek.ca>,
<vladimir.zapolskiy@linaro.org>, <quic_tdas@quicinc.com>,
<neil.armstrong@linaro.org>, <rfoss@kernel.org>,
<bhupesh.sharma@linaro.org>, <mani@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-media@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs
Date: Thu, 27 Jul 2023 12:38:16 +0530 [thread overview]
Message-ID: <3da310cc-b866-4829-8411-befaa719f10d@quicinc.com> (raw)
In-Reply-To: <86c6e8b1-d286-6858-5de6-b8faf6557fe4@quicinc.com>
On Thu, Jul 27, 2023 at 12:24:10PM +0530, Rohit Agarwal wrote:
>
> On 7/27/2023 11:06 AM, Pavan Kondeti wrote:
> > On Thu, Jul 27, 2023 at 10:21:10AM +0530, Rohit Agarwal wrote:
> > > Update the RPMHPD references with new bindings defined in rpmhpd.h
> > > for Qualcomm SoCs SM8[2345]50.
> > >
> > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> > > ---
> > > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 3 ++-
> > > .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 7 ++++---
> > > Documentation/devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 3 ++-
> > > .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 5 +++--
> > > Documentation/devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 3 ++-
> > > .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 7 ++++---
> > > Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 3 ++-
> > > .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 7 ++++---
> > > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 3 ++-
> > > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 ++-
> > > Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 5 +++--
> > > 18 files changed, 44 insertions(+), 26 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
> > > index d6774db..d6b81c0 100644
> > > --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
> > > @@ -83,6 +83,7 @@ examples:
> > > - |
> > > #include <dt-bindings/clock/qcom,rpmh.h>
> > > #include <dt-bindings/power/qcom-rpmpd.h>
> > > + #include <dt-bindings/power/qcom,rpmhpd.h>
> > > clock-controller@af00000 {
> > > compatible = "qcom,sm8250-dispcc";
> > > reg = <0x0af00000 0x10000>;
> > > @@ -103,7 +104,7 @@ examples:
> > > #clock-cells = <1>;
> > > #reset-cells = <1>;
> > > #power-domain-cells = <1>;
> > > - power-domains = <&rpmhpd SM8250_MMCX>;
> > > + power-domains = <&rpmhpd RPMHPD_MMCX>;
> > > required-opps = <&rpmhpd_opp_low_svs>;
> > > };
> > > ...
> > Does this file still need to include old header? The same is applicable
> > to some of the other files in the patch also.
> >
> > We also discussed on the other thread [1] to move the regulator level
> > definitions to new header. should this change be done after that, so that
> > we don't end up touching the very same files again?
> >
> > [1]
> > https://lore.kernel.org/all/a4zztrn6jhblozdswba7psqtvjt5l765mfr3yl4llsm5gsyqef@7x6q7yabydvm/
> Removing this header directly would also be fine as we are not using any
> macro defined directly in these
> bindings.
> I already checked with dt_binding_check by removing this header.
>
Thanks for checking, then we should remove the old header in this patch
it self, right?
Thanks,
Pavan
next prev parent reply other threads:[~2023-07-27 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 4:51 [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs Rohit Agarwal
2023-07-27 5:36 ` Pavan Kondeti
2023-07-27 6:54 ` Rohit Agarwal
2023-07-27 7:08 ` Pavan Kondeti [this message]
2023-07-27 7:09 ` Rohit Agarwal
2023-07-27 6:15 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da310cc-b866-4829-8411-befaa719f10d@quicinc.com \
--to=quic_pkondeti@quicinc.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=stanimir.k.varbanov@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox