From: Ritesh Harjani <riteshh@codeaurora.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: mmc_test: Fix "Commands during non-blocking write" tests
Date: Mon, 7 Nov 2016 11:40:48 +0530 [thread overview]
Message-ID: <41a2be09-2d50-335c-2045-88041e56a7f3@codeaurora.org> (raw)
In-Reply-To: <1478259665-13406-1-git-send-email-adrian.hunter@intel.com>
Hi,
On 11/4/2016 5:11 PM, Adrian Hunter wrote:
> mmc_test_check_result_async() requires that struct mmc_async_req is
> contained within struct mmc_test_async_req. Fix the "Commands during
> non-blocking write" tests so that is the case.
Tested this patch on an internal platform. Fixes the issue with mmc_test.
Tested-by: Ritesh Harjani <riteshh@codeaurora.org>
>
> Fixes: 4bbb9aac9a9a ("mmc: mmc_test: Add tests for sending commands during transfer")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/card/mmc_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index 5a8dc5a76e0d..3678220964fe 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -2347,7 +2347,7 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test,
> struct mmc_test_req *rq = mmc_test_req_alloc();
> struct mmc_host *host = test->card->host;
> struct mmc_test_area *t = &test->area;
> - struct mmc_async_req areq;
> + struct mmc_test_async_req test_areq = { .test = test };
> struct mmc_request *mrq;
> unsigned long timeout;
> bool expired = false;
> @@ -2363,8 +2363,8 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test,
> mrq->sbc = &rq->sbc;
> mrq->cap_cmd_during_tfr = true;
>
> - areq.mrq = mrq;
> - areq.err_check = mmc_test_check_result_async;
> + test_areq.areq.mrq = mrq;
> + test_areq.areq.err_check = mmc_test_check_result_async;
>
> mmc_test_prepare_mrq(test, mrq, t->sg, t->sg_len, dev_addr, t->blocks,
> 512, write);
> @@ -2378,7 +2378,7 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test,
>
> /* Start ongoing data request */
> if (use_areq) {
> - mmc_start_req(host, &areq, &ret);
> + mmc_start_req(host, &test_areq.areq, &ret);
> if (ret)
> goto out_free;
> } else {
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-07 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 11:41 [PATCH] mmc: mmc_test: Fix "Commands during non-blocking write" tests Adrian Hunter
2016-11-07 6:10 ` Ritesh Harjani [this message]
2016-11-07 12:43 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a2be09-2d50-335c-2045-88041e56a7f3@codeaurora.org \
--to=riteshh@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox