[PATCH V3 0/4] Add SD Card support for sm8750 SoC and boards

[PATCH V3 0/4] Add SD Card support for sm8750 SoC and boards

[Sarthak Garg]

Add SD Card support for sm8750 SoC, including MTP and QRD boards.

- Changed from v2
    - As suggested by Abel Vesa move the GPIO configuration for SD card
      detection (specifically the pin settings for gpio55) from the
      SoC-level device tree (sm8750.dtsi) to the board-specific device
      tree files.

- Changed from v1
    - As suggested by Konrad Dybcio the patch into separate commits per
      board and did formatting improvements (e.g. aligning < symbols,
      placing each item on a new line).
    - Addressed Konrad Dybcio comment to use SVS_L1 for opp-202000000.

Sarthak Garg (4):
  dt-bindings: mmc: sdhci-msm: Add sm8750 compatible
  arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
  arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board
  arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board

 .../devicetree/bindings/mmc/sdhci-msm.yaml    |  1 +
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts       | 23 ++++++++
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts       | 23 ++++++++
 arch/arm64/boot/dts/qcom/sm8750.dtsi          | 54 +++++++++++++++++++
 4 files changed, 101 insertions(+)

-- 
2.34.1

[PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible

[Sarthak Garg]

Document the compatible string for the SDHCI controller on the
sm8750 platform.

Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 594bd174ff21..027011223368 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -70,6 +70,7 @@ properties:
               - qcom,sm8450-sdhci
               - qcom,sm8550-sdhci
               - qcom,sm8650-sdhci
+              - qcom,sm8750-sdhci
               - qcom,x1e80100-sdhci
           - const: qcom,sdhci-msm-v5 # for sdcc version 5.0
 
-- 
2.34.1

Re: [PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible

[Krzysztof Kozlowski]

On 26/10/2025 12:17, Sarthak Garg wrote:
> Document the compatible string for the SDHCI controller on the
> sm8750 platform.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> ---



Why are you sending third time the same, even though this was applied
long time ago at v1? Please do not send unnecessary patches, this just
clutters people's mailboxes.

Best regards,
Krzysztof

Re: [PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible

[Sarthak Garg]

On 10/27/2025 8:00 PM, Krzysztof Kozlowski wrote:
> On 26/10/2025 12:17, Sarthak Garg wrote:
>> Document the compatible string for the SDHCI controller on the
>> sm8750 platform.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>
>
> Why are you sending third time the same, even though this was applied
> long time ago at v1? Please do not send unnecessary patches, this just
> clutters people's mailboxes.
>
> Best regards,
> Krzysztof


I had assumed that we need to repost the entire patch series regardless 
of whether some patches were already ACKed or applied. I’ll make sure to 
avoid resending already accepted patches in future submissions to keep 
the mailbox clean.


Regards,

Sarthak

Re: [PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible

[Krzysztof Kozlowski]

On 10/11/2025 07:47, Sarthak Garg wrote:
> 
> On 10/27/2025 8:00 PM, Krzysztof Kozlowski wrote:
>> On 26/10/2025 12:17, Sarthak Garg wrote:
>>> Document the compatible string for the SDHCI controller on the
>>> sm8750 platform.
>>>
>>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>
>>
>> Why are you sending third time the same, even though this was applied
>> long time ago at v1? Please do not send unnecessary patches, this just
>> clutters people's mailboxes.
>>
>> Best regards,
>> Krzysztof
> 
> 
> I had assumed that we need to repost the entire patch series regardless 
> of whether some patches were already ACKed or applied. I’ll make sure to 

Why? What sort of documentation ever suggested sending things which are
applied? What sort of logic drives it?

Best regards,
Krzysztof

Re: [PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible

[Bjorn Andersson]

On Mon, Nov 10, 2025 at 12:17:51PM +0530, Sarthak Garg wrote:
> 
> On 10/27/2025 8:00 PM, Krzysztof Kozlowski wrote:
> > On 26/10/2025 12:17, Sarthak Garg wrote:
> > > Document the compatible string for the SDHCI controller on the
> > > sm8750 platform.
> > > 
> > > Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> > > Acked-by: Rob Herring (Arm) <robh@kernel.org>
> > > ---
> > 
> > 
> > Why are you sending third time the same, even though this was applied
> > long time ago at v1? Please do not send unnecessary patches, this just
> > clutters people's mailboxes.
> > 
> > Best regards,
> > Krzysztof
> 
> 
> I had assumed that we need to repost the entire patch series regardless of
> whether some patches were already ACKed or applied. I’ll make sure to avoid
> resending already accepted patches in future submissions to keep the mailbox
> clean.
> 

In the end maintainers are going to merge your patches onto the tip of
their branch(es).

So, if you didn't rebase your changes past the merge of this binding,
did you validate that the other changes in the series still applies? Do
they still compile? Do they still work as intended?

Regards,
Bjorn

> 
> Regards,
> 
> Sarthak
> 
> 

[PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

[Sarthak Garg]

Add SD Card host controller for sm8750 soc.

Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index a82d9867c7cb..50e1fa67c093 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
 			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
 		};
 
+		sdhc_2: mmc@8804000 {
+			compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
+			reg = <0 0x08804000 0 0x1000>;
+
+			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "hc_irq",
+					  "pwr_irq";
+
+			clocks = <&gcc GCC_SDCC2_AHB_CLK>,
+				 <&gcc GCC_SDCC2_APPS_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "iface",
+				      "core",
+				      "xo";
+
+			interconnects = <&aggre2_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
+					&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					&config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
+			interconnect-names = "sdhc-ddr",
+					     "cpu-sdhc";
+
+			power-domains = <&rpmhpd RPMHPD_CX>;
+			operating-points-v2 = <&sdhc2_opp_table>;
+
+			qcom,dll-config = <0x0007442c>;
+			qcom,ddr-config = <0x80040868>;
+
+			iommus = <&apps_smmu 0x540 0x0>;
+			dma-coherent;
+
+			bus-width = <4>;
+			max-sd-hs-hz = <37500000>;
+
+			resets = <&gcc GCC_SDCC2_BCR>;
+
+			status = "disabled";
+
+			sdhc2_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					required-opps = <&rpmhpd_opp_low_svs>;
+				};
+
+				opp-202000000 {
+					opp-hz = /bits/ 64 <202000000>;
+					required-opps = <&rpmhpd_opp_svs_l1>;
+				};
+			};
+		};
+
 		cryptobam: dma-controller@1dc4000 {
 			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
 			reg = <0x0 0x01dc4000 0x0 0x28000>;
-- 
2.34.1

Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

[Abel Vesa]

On 25-10-26 16:47:44, Sarthak Garg wrote:
> Add SD Card host controller for sm8750 soc.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

[Krzysztof Kozlowski]

On 26/10/2025 12:17, Sarthak Garg wrote:
> Add SD Card host controller for sm8750 soc.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index a82d9867c7cb..50e1fa67c093 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
>  			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
>  		};
>  
> +		sdhc_2: mmc@8804000 {

Completely messed ordering.

> +			compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
> +			reg = <0 0x08804000 0 0x1000>;

Use hex everywhere in reg.

Best regards,
Krzysztof

Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

[Sarthak Garg]

On 10/27/2025 8:02 PM, Krzysztof Kozlowski wrote:
> On 26/10/2025 12:17, Sarthak Garg wrote:
>> Add SD Card host controller for sm8750 soc.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
>>   1 file changed, 54 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> index a82d9867c7cb..50e1fa67c093 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> @@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
>>   			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
>>   		};
>>   
>> +		sdhc_2: mmc@8804000 {
> Completely messed ordering.


Do you mean the property order within the sdhc_2 device tree node ?

What ordering do we need to follow here ?


>
>> +			compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
>> +			reg = <0 0x08804000 0 0x1000>;
> Use hex everywhere in reg.
>
> Best regards,
> Krzysztof


Sure will update in V2.

Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

[Krzysztof Kozlowski]

On 10/11/2025 08:06, Sarthak Garg wrote:
> 
> On 10/27/2025 8:02 PM, Krzysztof Kozlowski wrote:
>> On 26/10/2025 12:17, Sarthak Garg wrote:
>>> Add SD Card host controller for sm8750 soc.
>>>
>>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
>>>   1 file changed, 54 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> index a82d9867c7cb..50e1fa67c093 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> @@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
>>>   			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
>>>   		};
>>>   
>>> +		sdhc_2: mmc@8804000 {
>> Completely messed ordering.
> 
> 
> Do you mean the property order within the sdhc_2 device tree node ?
> 
> What ordering do we need to follow here ?

The one from coding style.

Best regards,
Krzysztof

[PATCH V3 3/4] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board

[Sarthak Garg]

Enable SD Card host controller for sm8750 mtp board.

Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3bbb53b7c71f..5a00603ec347 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1163,6 +1163,29 @@ wlan_en: wlan-en-state {
 		drive-strength = <8>;
 		bias-pull-down;
 	};
+
+	sdc2_card_det_n: sd-card-det-n-state {
+		pins = "gpio55";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+};
+
+&sdhc_2 {
+	cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
+
+	vmmc-supply = <&vreg_l9b_2p9>;
+	vqmmc-supply = <&vreg_l8b_1p8>;
+
+	no-sdio;
+	no-mmc;
+
+	pinctrl-0 = <&sdc2_default &sdc2_card_det_n>;
+	pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>;
+	pinctrl-names = "default", "sleep";
+
+	status = "okay";
 };
 
 &uart14 {
-- 
2.34.1

Re: [PATCH V3 3/4] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board

[Krzysztof Kozlowski]

On 26/10/2025 12:17, Sarthak Garg wrote:
> Enable SD Card host controller for sm8750 mtp board.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH V3 3/4] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board

[Krzysztof Kozlowski]

On 27/10/2025 15:31, Krzysztof Kozlowski wrote:
> On 26/10/2025 12:17, Sarthak Garg wrote:
>> Enable SD Card host controller for sm8750 mtp board.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Actually un-reviewed. Here also ordering is broken. Please follow
Qualcomm style for ordering properties.

Best regards,
Krzysztof

Re: [PATCH V3 3/4] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board

[Sarthak Garg]

On 10/27/2025 8:03 PM, Krzysztof Kozlowski wrote:
> On 27/10/2025 15:31, Krzysztof Kozlowski wrote:
>> On 26/10/2025 12:17, Sarthak Garg wrote:
>>> Enable SD Card host controller for sm8750 mtp board.
>>>
>>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>>> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 23 +++++++++++++++++++++++
>>>   1 file changed, 23 insertions(+)
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Actually un-reviewed. Here also ordering is broken. Please follow
> Qualcomm style for ordering properties.
>
> Best regards,
> Krzysztof


Sure will update in V4.

[PATCH V3 4/4] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board

[Sarthak Garg]

Enable SD Card host controller for sm8750 qrd board.

Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 13c7b9664c89..c2ab39744a0c 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1031,6 +1031,29 @@ wcd_default: wcd-reset-n-active-state {
 		bias-disable;
 		output-low;
 	};
+
+	sdc2_card_det_n: sd-card-det-n-state {
+		pins = "gpio55";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+};
+
+&sdhc_2 {
+	cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
+
+	vmmc-supply = <&vreg_l9b_2p9>;
+	vqmmc-supply = <&vreg_l8b_1p8>;
+
+	no-sdio;
+	no-mmc;
+
+	pinctrl-0 = <&sdc2_default &sdc2_card_det_n>;
+	pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>;
+	pinctrl-names = "default", "sleep";
+
+	status = "okay";
 };
 
 &uart7 {
-- 
2.34.1

Re: [PATCH V3 4/4] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board

[Krzysztof Kozlowski]

On 26/10/2025 12:17, Sarthak Garg wrote:
> Enable SD Card host controller for sm8750 qrd board.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..c2ab39744a0c 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1031,6 +1031,29 @@ wcd_default: wcd-reset-n-active-state {
>  		bias-disable;
>  		output-low;
>  	};
> +
> +	sdc2_card_det_n: sd-card-det-n-state {
> +		pins = "gpio55";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-pull-up;
> +	};
> +};
> +
> +&sdhc_2 {


That's random order. Please follow the order as expressed in DTS coding
style. This file already has broken Qualcomm style, but you do not have
to bring additional mistakes.

Best regards,
Krzysztof

Re: [PATCH V3 4/4] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board

[Sarthak Garg]

On 10/27/2025 8:04 PM, Krzysztof Kozlowski wrote:
> On 26/10/2025 12:17, Sarthak Garg wrote:
>> Enable SD Card host controller for sm8750 qrd board.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..c2ab39744a0c 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -1031,6 +1031,29 @@ wcd_default: wcd-reset-n-active-state {
>>   		bias-disable;
>>   		output-low;
>>   	};
>> +
>> +	sdc2_card_det_n: sd-card-det-n-state {
>> +		pins = "gpio55";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-pull-up;
>> +	};
>> +};
>> +
>> +&sdhc_2 {
>
> That's random order. Please follow the order as expressed in DTS coding
> style. This file already has broken Qualcomm style, but you do not have
> to bring additional mistakes.
>
> Best regards,
> Krzysztof


Sure will update in V4.