From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx
Date: Thu, 16 Feb 2023 10:18:42 +0100 [thread overview]
Message-ID: <48b4a87a-c5e9-c3ec-2492-bb2afb495398@linaro.org> (raw)
In-Reply-To: <CAPDyKFroB-TULOeia4OyXBW6rWMs7e3_Fp4Uw878Q8Gt=TDfag@mail.gmail.com>
On 15/02/2023 13:48, Ulf Hansson wrote:
> On Tue, 14 Feb 2023 at 22:39, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> On certain platforms like Amlogic Meson gpiod_to_irq() isn't supported
>> due to the design of gpio / interrupt controller. Therefore provide an
>> option for drivers to pass the card detect interrupt number
>> (retrieved e.g. from device tree) to mmc core.
>>
>> v2:
>> - use another mechanism for passing and storing the cd interrupt
>> - add patch 2
>>
>> Heiner Kallweit (3):
>> mmc: core: support setting card detect interrupt from drivers
>> dt-bindings: mmc: meson-gx: support specifying cd interrupt
>> mmc: meson-gx: support platform interrupt as card detect interrupt
>>
>> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>> drivers/mmc/core/slot-gpio.c | 17 ++++++++++++++++-
>> drivers/mmc/host/meson-gx-mmc.c | 5 ++++-
>> include/linux/mmc/slot-gpio.h | 1 +
>> 4 files changed, 22 insertions(+), 3 deletions(-)
>>
>
> Applied for next, thanks!
A bit too fast. Binding is incorrect - suggests ABI break and makes
interrupts not described enough.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-16 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 21:39 [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx Heiner Kallweit
2023-02-14 21:41 ` [PATCH v2 1/3] mmc: core: support setting card detect interrupt from drivers Heiner Kallweit
2023-02-14 21:42 ` [PATCH v2 2/3] dt-bindings: mmc: meson-gx: support specifying cd interrupt Heiner Kallweit
2023-02-16 9:18 ` Krzysztof Kozlowski
2023-02-16 9:29 ` Heiner Kallweit
2023-02-16 9:34 ` Krzysztof Kozlowski
2023-02-16 9:41 ` Heiner Kallweit
2023-02-16 9:49 ` Heiner Kallweit
2023-02-16 11:12 ` Ulf Hansson
2023-02-14 21:44 ` [PATCH v2 3/3] mmc: meson-gx: support platform interrupt as card detect interrupt Heiner Kallweit
2023-02-15 12:48 ` [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx Ulf Hansson
2023-02-16 9:18 ` Krzysztof Kozlowski [this message]
2023-02-16 11:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b4a87a-c5e9-c3ec-2492-bb2afb495398@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox