* [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT
@ 2012-02-07 5:13 Jaehoon Chung
2012-02-07 7:27 ` Namjae Jeon
2012-02-11 21:06 ` Chris Ball
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2012-02-07 5:13 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball, Kyungmin Park
This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc.
If sbc's message can see, should be help for debugging.
(We can check whether use the cmd23 or not)
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/core/core.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 8a19143..6b72eb8 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
struct scatterlist *sg;
#endif
+ if (mrq->sbc) {
+ pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+ mmc_hostname(host), mrq->sbc->opcode,
+ mrq->sbc->arg, mrq->sbc->flags);
+ }
+
pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
mmc_hostname(host), mrq->cmd->opcode,
mrq->cmd->arg, mrq->cmd->flags);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT
2012-02-07 5:13 [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT Jaehoon Chung
@ 2012-02-07 7:27 ` Namjae Jeon
2012-02-08 7:40 ` Jaehoon Chung
2012-02-11 21:06 ` Chris Ball
1 sibling, 1 reply; 5+ messages in thread
From: Namjae Jeon @ 2012-02-07 7:27 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Chris Ball, Kyungmin Park
2012/2/7 Jaehoon Chung <jh80.chung@samsung.com>:
> This patch is added just debug message.
> Almost features need to use the CMD23.
> But we didn't see the debug message for sbc.
> If sbc's message can see, should be help for debugging.
> (We can check whether use the cmd23 or not)
Hi. Jaehoon.
how about using CONFIG_MMC_DEBUG around this debug message.
Thanks.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/core/core.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 8a19143..6b72eb8 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
> struct scatterlist *sg;
> #endif
>
> + if (mrq->sbc) {
> + pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
> + mmc_hostname(host), mrq->sbc->opcode,
> + mrq->sbc->arg, mrq->sbc->flags);
> + }
> +
> pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
> mmc_hostname(host), mrq->cmd->opcode,
> mrq->cmd->arg, mrq->cmd->flags);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT
2012-02-07 7:27 ` Namjae Jeon
@ 2012-02-08 7:40 ` Jaehoon Chung
2012-02-08 9:13 ` Namjae Jeon
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2012-02-08 7:40 UTC (permalink / raw)
To: Namjae Jeon; +Cc: Jaehoon Chung, linux-mmc, Chris Ball, Kyungmin Park
On 02/07/2012 04:27 PM, Namjae Jeon wrote:
> 2012/2/7 Jaehoon Chung <jh80.chung@samsung.com>:
>> This patch is added just debug message.
>> Almost features need to use the CMD23.
>> But we didn't see the debug message for sbc.
>> If sbc's message can see, should be help for debugging.
>> (We can check whether use the cmd23 or not)
> Hi. Jaehoon.
> how about using CONFIG_MMC_DEBUG around this debug message.
Why using?
> Thanks.
>
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mmc/core/core.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index 8a19143..6b72eb8 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>> struct scatterlist *sg;
>> #endif
>>
>> + if (mrq->sbc) {
>> + pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
>> + mmc_hostname(host), mrq->sbc->opcode,
>> + mrq->sbc->arg, mrq->sbc->flags);
>> + }
>> +
>> pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>> mmc_hostname(host), mrq->cmd->opcode,
>> mrq->cmd->arg, mrq->cmd->flags);
>> --
>> 1.7.4.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT
2012-02-08 7:40 ` Jaehoon Chung
@ 2012-02-08 9:13 ` Namjae Jeon
0 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2012-02-08 9:13 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Chris Ball, Kyungmin Park
2012/2/8 Jaehoon Chung <jh80.chung@samsung.com>:
> On 02/07/2012 04:27 PM, Namjae Jeon wrote:
>
>> 2012/2/7 Jaehoon Chung <jh80.chung@samsung.com>:
>>> This patch is added just debug message.
>>> Almost features need to use the CMD23.
>>> But we didn't see the debug message for sbc.
>>> If sbc's message can see, should be help for debugging.
>>> (We can check whether use the cmd23 or not)
>> Hi. Jaehoon.
>> how about using CONFIG_MMC_DEBUG around this debug message.
>
> Why using?
It is not need because you used pr_debug. I understand.
Thanks.
>
>> Thanks.
>>
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>> drivers/mmc/core/core.c | 6 ++++++
>>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>>> index 8a19143..6b72eb8 100644
>>> --- a/drivers/mmc/core/core.c
>>> +++ b/drivers/mmc/core/core.c
>>> @@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>>> struct scatterlist *sg;
>>> #endif
>>>
>>> + if (mrq->sbc) {
>>> + pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
>>> + mmc_hostname(host), mrq->sbc->opcode,
>>> + mrq->sbc->arg, mrq->sbc->flags);
>>> + }
>>> +
>>> pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>>> mmc_hostname(host), mrq->cmd->opcode,
>>> mrq->cmd->arg, mrq->cmd->flags);
>>> --
>>> 1.7.4.1
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT
2012-02-07 5:13 [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT Jaehoon Chung
2012-02-07 7:27 ` Namjae Jeon
@ 2012-02-11 21:06 ` Chris Ball
1 sibling, 0 replies; 5+ messages in thread
From: Chris Ball @ 2012-02-11 21:06 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Kyungmin Park
Hi,
On Tue, Feb 07 2012, Jaehoon Chung wrote:
> This patch is added just debug message.
> Almost features need to use the CMD23.
> But we didn't see the debug message for sbc.
> If sbc's message can see, should be help for debugging.
> (We can check whether use the cmd23 or not)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/core/core.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 8a19143..6b72eb8 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
> struct scatterlist *sg;
> #endif
>
> + if (mrq->sbc) {
> + pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
> + mmc_hostname(host), mrq->sbc->opcode,
> + mrq->sbc->arg, mrq->sbc->flags);
> + }
> +
> pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
> mmc_hostname(host), mrq->cmd->opcode,
> mrq->cmd->arg, mrq->cmd->flags);
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-11 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-07 5:13 [PATCH] mmc: core: add the debug message for SET_BLOCK_COUNT Jaehoon Chung
2012-02-07 7:27 ` Namjae Jeon
2012-02-08 7:40 ` Jaehoon Chung
2012-02-08 9:13 ` Namjae Jeon
2012-02-11 21:06 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox