* [PATCH] mmc: sunxi: Remove dev_err_probe() if error is -ENOMEM
@ 2025-08-21 9:17 Xichao Zhao
2025-09-08 13:50 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Xichao Zhao @ 2025-08-21 9:17 UTC (permalink / raw)
To: ulf.hansson, wens, jernej.skrabec, samuel
Cc: linux-mmc, linux-sunxi, linux-kernel, Xichao Zhao
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just
return the value instead.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/mmc/host/sunxi-mmc.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index ee4a65b0a22d..8dd1d2409a26 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1371,8 +1371,8 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
mmc = devm_mmc_alloc_host(&pdev->dev, sizeof(*host));
if (!mmc)
- return dev_err_probe(&pdev->dev, -ENOMEM,
- "mmc alloc host failed\n");
+ return -ENOMEM;
+
platform_set_drvdata(pdev, mmc);
host = mmc_priv(mmc);
@@ -1387,8 +1387,7 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
host->sg_cpu = dma_alloc_coherent(&pdev->dev, PAGE_SIZE,
&host->sg_dma, GFP_KERNEL);
if (!host->sg_cpu)
- return dev_err_probe(&pdev->dev, -ENOMEM,
- "Failed to allocate DMA descriptor mem\n");
+ return -ENOMEM;
if (host->cfg->ccu_has_timings_switch) {
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: sunxi: Remove dev_err_probe() if error is -ENOMEM
2025-08-21 9:17 [PATCH] mmc: sunxi: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
@ 2025-09-08 13:50 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2025-09-08 13:50 UTC (permalink / raw)
To: ulf.hansson, wens, samuel, Xichao Zhao
Cc: linux-mmc, linux-sunxi, linux-kernel, Xichao Zhao
Dne četrtek, 21. avgust 2025 ob 11:17:21 Srednjeevropski poletni čas je Xichao Zhao napisal(a):
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
It would be better to print error message rather than dismiss them.
Best regards,
Jernej
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
> drivers/mmc/host/sunxi-mmc.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index ee4a65b0a22d..8dd1d2409a26 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1371,8 +1371,8 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
>
> mmc = devm_mmc_alloc_host(&pdev->dev, sizeof(*host));
> if (!mmc)
> - return dev_err_probe(&pdev->dev, -ENOMEM,
> - "mmc alloc host failed\n");
> + return -ENOMEM;
> +
> platform_set_drvdata(pdev, mmc);
>
> host = mmc_priv(mmc);
> @@ -1387,8 +1387,7 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
> host->sg_cpu = dma_alloc_coherent(&pdev->dev, PAGE_SIZE,
> &host->sg_dma, GFP_KERNEL);
> if (!host->sg_cpu)
> - return dev_err_probe(&pdev->dev, -ENOMEM,
> - "Failed to allocate DMA descriptor mem\n");
> + return -ENOMEM;
>
> if (host->cfg->ccu_has_timings_switch) {
> /*
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-08 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-21 9:17 [PATCH] mmc: sunxi: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
2025-09-08 13:50 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox