From: Adrian Hunter <adrian.hunter@intel.com>
To: Victor Shih <victorshihgli@gmail.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw,
Greg.tu@genesyslogic.com.tw, takahiro.akashi@linaro.org,
dlunev@chromium.org, Ben Chuang <ben.chuang@genesyslogic.com.tw>,
Victor Shih <victor.shih@genesyslogic.com.tw>,
ulf.hansson@linaro.org
Subject: Re: [PATCH V16 23/23] mmc: sdhci-pci-gli: enable UHS-II mode for GL9767
Date: Thu, 23 May 2024 20:09:44 +0300 [thread overview]
Message-ID: <81adac4f-edc5-4e3d-8c74-68a33183c3e3@intel.com> (raw)
In-Reply-To: <20240522110909.10060-24-victorshihgli@gmail.com>
On 22/05/24 14:09, Victor Shih wrote:
> From: Victor Shih <victor.shih@genesyslogic.com.tw>
>
> Changes are:
> * Enable the internal clock when do reset on UHS-II mode.
> * Increase timeout value before detecting UHS-II interface.
> * Add vendor settings for UHS-II mode.
>
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
> ---
>
> Updates in V15:
> - Add gl9767 to support uhs2 function.
>
> ---
>
> drivers/mmc/host/sdhci-pci-gli.c | 152 ++++++++++++++++++++++++++++++-
> drivers/mmc/host/sdhci-uhs2.c | 3 +-
> drivers/mmc/host/sdhci-uhs2.h | 1 +
> 3 files changed, 153 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 5df6be758b06..20f19cec6e64 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -210,6 +210,10 @@
> #define PCIE_GLI_9767_SCR_CORE_PWR_D3_OFF BIT(21)
> #define PCIE_GLI_9767_SCR_CFG_RST_DATA_LINK_DOWN BIT(30)
>
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG1 0x90C
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG1_SERDES_INTR GENMASK(31, 29)
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG1_SERDES_INTR_VALUE 0x3
> +
> #define PCIE_GLI_9767_SDHC_CAP 0x91C
> #define PCIE_GLI_9767_SDHC_CAP_SDEI_RESULT BIT(5)
>
> @@ -228,9 +232,15 @@
> #define PCIE_GLI_9767_SD_EXPRESS_CTL_SD_EXPRESS_MODE BIT(1)
>
> #define PCIE_GLI_9767_SD_DATA_MULTI_CTL 0x944
> +#define PCIE_GLI_9767_SD_DATA_MULTI_CTL_SELECT_UHS2 BIT(5)
> +#define PCIE_GLI_9767_SD_DATA_MULTI_CTL_UHS2_SWITCH_CTL BIT(8)
> #define PCIE_GLI_9767_SD_DATA_MULTI_CTL_DISCONNECT_TIME GENMASK(23, 16)
> #define PCIE_GLI_9767_SD_DATA_MULTI_CTL_DISCONNECT_TIME_VALUE 0x64
>
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG2 0x948
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG2_SSC_PPM_SETTING GENMASK(22, 21)
> +#define PCIE_GLI_9767_UHS2_PHY_SET_REG2_SSC_PPM_SETTING_VALUE 0x0
> +
> #define PCIE_GLI_9767_NORMAL_ERR_INT_STATUS_REG2 0x950
> #define PCIE_GLI_9767_NORMAL_ERR_INT_STATUS_REG2_SDEI_COMPLETE BIT(0)
>
> @@ -240,6 +250,28 @@
> #define PCIE_GLI_9767_NORMAL_ERR_INT_SIGNAL_EN_REG2 0x958
> #define PCIE_GLI_9767_NORMAL_ERR_INT_SIGNAL_EN_REG2_SDEI_COMPLETE_SIGNAL_EN BIT(0)
>
> +#define PCIE_GLI_9767_UHS2_CTL1 0x95C
> +#define PCIE_GLI_9767_UHS2_CTL1_TRANS_PASS BIT(5)
> +#define PCIE_GLI_9767_UHS2_CTL1_TRANS_PASS_VALUE 0x1
> +#define PCIE_GLI_9767_UHS2_CTL1_DECODING_CTL BIT(6)
> +#define PCIE_GLI_9767_UHS2_CTL1_DECODING_CTL_VALUE 0x1
> +#define PCIE_GLI_9767_UHS2_CTL1_SERDES_TRAN GENMASK(10, 7)
> +#define PCIE_GLI_9767_UHS2_CTL1_SERDES_TRAN_VALUE 0x3
> +#define PCIE_GLI_9767_UHS2_CTL1_SERDES_RECV GENMASK(14, 11)
> +#define PCIE_GLI_9767_UHS2_CTL1_SERDES_RECV_VALUE 0xf
> +#define PCIE_GLI_9767_UHS2_CTL1_DIR_TRANS GENMASK(16, 15)
> +#define PCIE_GLI_9767_UHS2_CTL1_DIR_TRANS_VALUE 0x3
> +#define PCIE_GLI_9767_UHS2_CTL1_DIR_RECV GENMASK(18, 17)
> +#define PCIE_GLI_9767_UHS2_CTL1_DIR_RECV_VALUE 0x0
> +#define PCIE_GLI_9767_UHS2_CTL1_PDRST BIT(25)
> +#define PCIE_GLI_9767_UHS2_CTL1_PDRST_VALUE 0x1
> +
> +#define PCIE_GLI_9767_UHS2_CTL2 0x964
> +#define PCIE_GLI_9767_UHS2_CTL2_ZC GENMASK(3, 0)
> +#define PCIE_GLI_9767_UHS2_CTL2_ZC_VALUE 0xb
> +#define PCIE_GLI_9767_UHS2_CTL2_ZC_CTL BIT(6)
> +#define PCIE_GLI_9767_UHS2_CTL2_ZC_CTL_VALUE 0x1
> +
> #define GLI_MAX_TUNING_LOOP 40
>
> /* Genesys Logic chipset */
> @@ -1198,8 +1230,35 @@ static void gl9767_hw_setting(struct sdhci_pci_slot *slot)
>
> static void sdhci_gl9767_reset(struct sdhci_host *host, u8 mask)
> {
> - sdhci_reset(host, mask);
> - gli_set_9767(host);
> + u16 clk_ctrl;
> + u16 ctrl2;
> +
> + if (host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_A ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_A_HD ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_B ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_B_HD) {
> + /* need internal clock */
> + if (mask & SDHCI_RESET_ALL) {
> + ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> + clk_ctrl = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
> +
> + if ((ctrl2 & SDHCI_CTRL_V4_MODE) && (ctrl2 & SDHCI_CTRL_UHS2_ENABLE)) {
> + sdhci_writew(host, SDHCI_CLOCK_INT_EN, SDHCI_CLOCK_CONTROL);
> + } else {
> + sdhci_writew(host, SDHCI_CLOCK_INT_EN, SDHCI_CLOCK_CONTROL);
> + sdhci_wait_clock_stable(host);
> + sdhci_writew(host, SDHCI_CTRL_V4_MODE, SDHCI_HOST_CONTROL2);
> + }
> + }
> + if ((mask & SDHCI_RESET_CMD) | (mask & SDHCI_RESET_DATA))
> + sdhci_gli_uhs2_reset_sd_tran(host);
> +
> + sdhci_uhs2_reset(host, mask);
> + gli_set_9767(host);
> + } else {
> + sdhci_reset(host, mask);
> + gli_set_9767(host);
> + }
> }
>
> static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
> @@ -1289,6 +1348,87 @@ static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
> return 0;
> }
>
> +static void gl9767_vendor_init(struct sdhci_host *host)
> +{
> + struct sdhci_pci_slot *slot = sdhci_priv(host);
> + struct pci_dev *pdev = slot->chip->pdev;
> + u32 value;
> +
> + gl9767_vhs_write(pdev);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_UHS2_PHY_SET_REG1, &value);
> + value |= FIELD_PREP(PCIE_GLI_9767_UHS2_PHY_SET_REG1_SERDES_INTR,
> + PCIE_GLI_9767_UHS2_PHY_SET_REG1_SERDES_INTR_VALUE);
> + pci_write_config_dword(pdev, PCIE_GLI_9767_UHS2_PHY_SET_REG1, value);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_UHS2_PHY_SET_REG2, &value);
> + value |= FIELD_PREP(PCIE_GLI_9767_UHS2_PHY_SET_REG2_SSC_PPM_SETTING,
> + PCIE_GLI_9767_UHS2_PHY_SET_REG2_SSC_PPM_SETTING_VALUE);
> + pci_write_config_dword(pdev, PCIE_GLI_9767_UHS2_PHY_SET_REG2, value);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_UHS2_CTL1, &value);
> + value |= FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_TRANS_PASS,
> + PCIE_GLI_9767_UHS2_CTL1_TRANS_PASS_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_DECODING_CTL,
> + PCIE_GLI_9767_UHS2_CTL1_DECODING_CTL_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_SERDES_TRAN,
> + PCIE_GLI_9767_UHS2_CTL1_SERDES_TRAN_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_SERDES_RECV,
> + PCIE_GLI_9767_UHS2_CTL1_SERDES_RECV_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_DIR_TRANS,
> + PCIE_GLI_9767_UHS2_CTL1_DIR_TRANS_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_DIR_RECV,
> + PCIE_GLI_9767_UHS2_CTL1_DIR_RECV_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL1_PDRST,
> + PCIE_GLI_9767_UHS2_CTL1_PDRST_VALUE);
> + pci_write_config_dword(pdev, PCIE_GLI_9767_UHS2_CTL1, value);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_UHS2_CTL2, &value);
> + value |= FIELD_PREP(PCIE_GLI_9767_UHS2_CTL2_ZC,
> + PCIE_GLI_9767_UHS2_CTL2_ZC_VALUE) |
> + FIELD_PREP(PCIE_GLI_9767_UHS2_CTL2_ZC_CTL,
> + PCIE_GLI_9767_UHS2_CTL2_ZC_CTL_VALUE);
> + pci_write_config_dword(pdev, PCIE_GLI_9767_UHS2_CTL2, value);
> +
> + gl9767_vhs_read(pdev);
> +}
> +
> +static void sdhci_gl9767_set_power(struct sdhci_host *host, unsigned char mode, unsigned short vdd)
> +{
> + struct sdhci_pci_slot *slot = sdhci_priv(host);
> + struct pci_dev *pdev;
> + u32 value;
> +
> + pdev = slot->chip->pdev;
> +
> + if (host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_A ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_A_HD ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_B ||
> + host->mmc->ios.timing == MMC_TIMING_UHS2_SPEED_B_HD) {
> + gl9767_vhs_write(pdev);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_SD_DATA_MULTI_CTL, &value);
> + value |= PCIE_GLI_9767_SD_DATA_MULTI_CTL_SELECT_UHS2 |
> + PCIE_GLI_9767_SD_DATA_MULTI_CTL_UHS2_SWITCH_CTL;
> + pci_write_config_dword(pdev, PCIE_GLI_9767_SD_DATA_MULTI_CTL, value);
> +
> + gl9767_vhs_read(pdev);
> +
> + sdhci_uhs2_set_power(host, mode, vdd);
> + } else {
> + gl9767_vhs_write(pdev);
> +
> + pci_read_config_dword(pdev, PCIE_GLI_9767_SD_DATA_MULTI_CTL, &value);
> + value &= ~(PCIE_GLI_9767_SD_DATA_MULTI_CTL_SELECT_UHS2 |
> + PCIE_GLI_9767_SD_DATA_MULTI_CTL_UHS2_SWITCH_CTL);
> + pci_write_config_dword(pdev, PCIE_GLI_9767_SD_DATA_MULTI_CTL, value);
> +
> + gl9767_vhs_read(pdev);
> +
> + sdhci_set_power(host, mode, vdd);
> + }
> +}
> +
> static int gli_probe_slot_gl9750(struct sdhci_pci_slot *slot)
> {
> struct sdhci_host *host = slot->host;
> @@ -1325,6 +1465,7 @@ static int gli_probe_slot_gl9767(struct sdhci_pci_slot *slot)
> host->mmc->caps2 |= MMC_CAP2_SD_EXP;
> host->mmc_host_ops.init_sd_express = gl9767_init_sd_express;
> sdhci_enable_v4_mode(host);
> + gl9767_vendor_init(host);
>
> return 0;
> }
> @@ -1828,12 +1969,19 @@ static const struct sdhci_ops sdhci_gl9767_ops = {
> .reset = sdhci_gl9767_reset,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> .voltage_switch = sdhci_gl9767_voltage_switch,
> + .dump_uhs2_regs = sdhci_uhs2_dump_regs,
> + .set_timeout = sdhci_uhs2_set_timeout,
> + .irq = sdhci_uhs2_irq,
> + .set_power = sdhci_gl9767_set_power,
> + .uhs2_pre_detect_init = sdhci_gli_pre_detect_init,
> };
>
> const struct sdhci_pci_fixes sdhci_gl9767 = {
> .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> .quirks2 = SDHCI_QUIRK2_BROKEN_DDR50,
> .probe_slot = gli_probe_slot_gl9767,
> + .add_host = sdhci_pci_uhs2_add_host,
> + .remove_host = sdhci_pci_uhs2_remove_host,
> .ops = &sdhci_gl9767_ops,
> #ifdef CONFIG_PM_SLEEP
> .resume = sdhci_pci_gli_resume,
> diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c
> index c830ee352504..47180429448b 100644
> --- a/drivers/mmc/host/sdhci-uhs2.c
> +++ b/drivers/mmc/host/sdhci-uhs2.c
> @@ -125,7 +125,7 @@ static void sdhci_uhs2_reset_cmd_data(struct mmc_host *mmc)
> }
> }
>
> -static void sdhci_uhs2_set_power(struct sdhci_host *host, unsigned char mode, unsigned short vdd)
> +void sdhci_uhs2_set_power(struct sdhci_host *host, unsigned char mode, unsigned short vdd)
> {
> struct mmc_host *mmc = host->mmc;
> u8 pwr = 0;
> @@ -165,6 +165,7 @@ static void sdhci_uhs2_set_power(struct sdhci_host *host, unsigned char mode, un
> mdelay(5);
> }
> }
> +EXPORT_SYMBOL_GPL(sdhci_uhs2_set_power);
Might as well export sdhci_uhs2_set_power() when it is first added
>
> static u8 sdhci_calc_timeout_uhs2(struct sdhci_host *host, u8 *cmd_res, u8 *dead_lock)
> {
> diff --git a/drivers/mmc/host/sdhci-uhs2.h b/drivers/mmc/host/sdhci-uhs2.h
> index 42f34ca75275..c4a860f4e1e0 100644
> --- a/drivers/mmc/host/sdhci-uhs2.h
> +++ b/drivers/mmc/host/sdhci-uhs2.h
> @@ -185,5 +185,6 @@ void sdhci_uhs2_clear_set_irqs(struct sdhci_host *host, u32 clear, u32 set);
> u32 sdhci_uhs2_irq(struct sdhci_host *host, u32 intmask);
> int sdhci_uhs2_add_host(struct sdhci_host *host);
> void sdhci_uhs2_remove_host(struct sdhci_host *host, int dead);
> +void sdhci_uhs2_set_power(struct sdhci_host *host, unsigned char mode, unsigned short vdd);
>
> #endif /* __SDHCI_UHS2_H */
next prev parent reply other threads:[~2024-05-23 17:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 11:08 [PATCH V16 00/23] Add support UHS-II for GL9755 and GL9767 Victor Shih
2024-05-22 11:08 ` [PATCH V16 01/23] mmc: core: Cleanup printing of speed mode at card insertion Victor Shih
2024-05-22 11:08 ` [PATCH V16 02/23] mmc: core: Prepare to support SD UHS-II cards Victor Shih
2024-05-22 11:08 ` [PATCH V16 03/23] mmc: core: Announce successful insertion of an SD UHS-II card Victor Shih
2024-05-22 11:08 ` [PATCH V16 04/23] mmc: core: Extend support for mmc regulators with a vqmmc2 Victor Shih
2024-05-22 11:08 ` [PATCH V16 05/23] mmc: core: Add definitions for SD UHS-II cards Victor Shih
2024-05-22 11:08 ` [PATCH V16 06/23] mmc: core: Add New function to re-factoring the code Victor Shih
2024-05-22 11:08 ` [PATCH V16 07/23] mmc: core: Support UHS-II card control and access Victor Shih
2024-05-22 11:08 ` [PATCH V16 08/23] mmc: core: Support UHS-II Auto Command Error Recovery Victor Shih
2024-05-24 6:54 ` Adrian Hunter
2024-05-31 10:31 ` Victor Shih
2024-05-31 11:23 ` Adrian Hunter
2024-06-09 18:40 ` Victor Shih
2024-06-17 5:04 ` Adrian Hunter
2024-06-18 10:47 ` Victor Shih
2024-06-18 11:13 ` Adrian Hunter
2024-06-20 10:39 ` Victor Shih
2024-05-22 11:08 ` [PATCH V16 09/23] mmc: sdhci: add UHS-II related definitions in headers Victor Shih
2024-05-22 11:08 ` [PATCH V16 10/23] mmc: sdhci: add UHS-II module and add a kernel configuration Victor Shih
2024-05-22 11:08 ` [PATCH V16 11/23] mmc: sdhci-uhs2: dump UHS-II registers Victor Shih
2024-05-22 11:08 ` [PATCH V16 12/23] mmc: sdhci-uhs2: add reset function function Victor Shih
2024-05-24 7:23 ` Adrian Hunter
2024-05-31 10:32 ` Victor Shih
2024-05-31 11:25 ` Adrian Hunter
2024-06-20 10:39 ` Victor Shih
2024-05-22 11:08 ` [PATCH V16 13/23] mmc: sdhci-uhs2: add set_power() to support vdd2 Victor Shih
2024-05-22 11:09 ` [PATCH V16 14/23] mmc: sdhci-uhs2: add set_timeout() Victor Shih
2024-05-22 11:09 ` [PATCH V16 15/23] mmc: sdhci-uhs2: add set_ios() Victor Shih
2024-05-22 11:09 ` [PATCH V16 16/23] mmc: sdhci-uhs2: add uhs2_control() to initialise the interface Victor Shih
2024-05-22 11:09 ` [PATCH V16 17/23] mmc: sdhci-uhs2: add request() and others Victor Shih
2024-05-22 11:09 ` [PATCH V16 18/23] mmc: sdhci-uhs2: add irq() " Victor Shih
2024-05-22 11:09 ` [PATCH V16 19/23] mmc: sdhci-uhs2: add add_host() and others to set up the driver Victor Shih
2024-05-22 11:09 ` [PATCH V16 20/23] mmc: sdhci-uhs2: add pre-detect_init hook Victor Shih
2024-05-22 11:09 ` [PATCH V16 21/23] mmc: sdhci-pci: add UHS-II support framework Victor Shih
2024-05-22 11:09 ` [PATCH V16 22/23] mmc: sdhci-pci-gli: enable UHS-II mode for GL9755 Victor Shih
2024-05-22 11:09 ` [PATCH V16 23/23] mmc: sdhci-pci-gli: enable UHS-II mode for GL9767 Victor Shih
2024-05-23 17:08 ` Adrian Hunter
2024-06-20 10:39 ` Victor Shih
2024-05-23 17:09 ` Adrian Hunter [this message]
2024-06-20 10:39 ` Victor Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81adac4f-edc5-4e3d-8c74-68a33183c3e3@intel.com \
--to=adrian.hunter@intel.com \
--cc=Greg.tu@genesyslogic.com.tw \
--cc=HL.Liu@genesyslogic.com.tw \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=dlunev@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=victorshihgli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox