Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Chris Ball <chris@printf.net>
To: Grant Grundler <grundler@chromium.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Puthikorn Voravootivat <puthik@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH] mmc-utils: add eMMC 5.0 FFU support
Date: Thu, 23 Jan 2014 19:28:01 +0000	[thread overview]
Message-ID: <86fvoe1ose.fsf@void.printf.net> (raw)
In-Reply-To: <CANEJEGvpr3TB4PyfSOViy1D6avZQuKL7Km0DhnA5BiXDkYPV1w@mail.gmail.com> (Grant Grundler's message of "Thu, 23 Jan 2014 11:20:46 -0800")

Hi Grant,

On Thu, Jan 23 2014, Grant Grundler wrote:
> You can directly pull into a local branch/review with:
>     git fetch https://chromium.googlesource.com/chromiumos/third_party/mmc-utils
> refs/changes/21/179621/2 && git cherry-pick FETCH_HEAD

Thanks, that worked fine.  Now I'm seeing:

cc  -Wall -Werror -Wuninitialized -Wundef -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -O2 -Wp,-MMD,./.mmc_cmds.o.d,-MT,mmc_cmds.o -c mmc_cmds.c
mmc_cmds.c: In function ‘do_firmware_update’:
mmc_cmds.c:1201:53: error: macro "strncmp" requires 3 arguments, but only 2 given
if (strncmp(argv[4], "--I_want_to_destroy_my_drive")) {
                                                   ^
mmc_cmds.c:1201:6: error: the address of ‘strncmp’ will always evaluate as ‘true’ [-Werror=address]
if (strncmp(argv[4], "--I_want_to_destroy_my_drive")) {
    ^
mmc_cmds.c:1290:4: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Werror=format=]
    fwsize, fwfilename, ret);
    ^
cc1: all warnings being treated as errors
make: *** [mmc_cmds.o] Error 1

-- 
Chris Ball   <chris@printf.net>   <http://printf.net/>

  reply	other threads:[~2014-01-23 19:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 18:21 [PATCH] mmc-utils: add eMMC 5.0 FFU support Grant Grundler
2014-01-23 18:42 ` Chris Ball
2014-01-23 19:20   ` Grant Grundler
2014-01-23 19:28     ` Chris Ball [this message]
2014-01-23 19:30       ` Grant Grundler
2014-01-23 19:46         ` Grant Grundler
2014-01-26  1:47           ` Chris Ball
2014-01-28  0:38             ` Grant Grundler
2014-01-23 20:39         ` Grant Grundler
2014-01-23 18:45 ` Chris Ball
2014-01-23 19:26   ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fvoe1ose.fsf@void.printf.net \
    --to=chris@printf.net \
    --cc=grundler@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=puthik@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox