From: Chris Ball <chris@printf.net>
To: Grant Grundler <grundler@chromium.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Puthikorn Voravootivat <puthik@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH] mmc-utils: add eMMC 5.0 FFU support
Date: Thu, 23 Jan 2014 18:42:39 +0000 [thread overview]
Message-ID: <86ob321qw0.fsf@void.printf.net> (raw)
In-Reply-To: <1390501260-8730-1-git-send-email-grundler@chromium.org> (Grant Grundler's message of "Thu, 23 Jan 2014 10:21:00 -0800")
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -1,7 +1,7 @@
> CC ?= gcc
> AM_CFLAGS = -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2
> CFLAGS ?= -g -O2
> -objects = mmc.o mmc_cmds.o
> +objects = mmc.o mmc_cmds.o mmc_cmds-emmc5.o
>
> CHECKFLAGS = -Wall -Werror -Wuninitialized -Wundef
>
> @@ -44,7 +44,7 @@ clean:
> $(MAKE) -C man clean
The patch looks good, but doesn't apply because "$(MAKE) -C man clean"
does not exist in mainline mmc-utils and never has. Could you check
for local patches (and ideally push them up to me too)?
Thanks,
- Chris.
--
Chris Ball <chris@printf.net> <http://printf.net/>
next prev parent reply other threads:[~2014-01-23 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 18:21 [PATCH] mmc-utils: add eMMC 5.0 FFU support Grant Grundler
2014-01-23 18:42 ` Chris Ball [this message]
2014-01-23 19:20 ` Grant Grundler
2014-01-23 19:28 ` Chris Ball
2014-01-23 19:30 ` Grant Grundler
2014-01-23 19:46 ` Grant Grundler
2014-01-26 1:47 ` Chris Ball
2014-01-28 0:38 ` Grant Grundler
2014-01-23 20:39 ` Grant Grundler
2014-01-23 18:45 ` Chris Ball
2014-01-23 19:26 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ob321qw0.fsf@void.printf.net \
--to=chris@printf.net \
--cc=grundler@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox