From: Chris Ball <cjb@laptop.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Octavian Purdila <octavian.purdila@intel.com>,
Irina Tirdea <irina.tirdea@intel.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 00/26] pstore, mmc: add mmc as backend for pstore
Date: Mon, 29 Oct 2012 16:50:42 -0400 [thread overview]
Message-ID: <87390xroil.fsf@octavius.laptop.org> (raw)
In-Reply-To: <20121029202820.GA21660@shutemov.name> (Kirill A. Shutemov's message of "Mon, 29 Oct 2012 22:28:20 +0200")
Hi,
On Mon, Oct 29 2012, Kirill A. Shutemov wrote:
> On Tue, Oct 23, 2012 at 04:47:58PM +0300, Irina Tirdea wrote:
>> These patches enable using the mmc card to store panic information.
>>
>> They include changes for pstore and mmc:
>> - add block device backend for pstore
>> - add logic in mmc for writing in panic mode
>
> Chris, any feedback on mmc/sdhci part?
Looks like the patchset hasn't been sent to linux-mmc@vger.kernel.org
yet -- could you send a v2 with that address included, please?
It would also be great to see descriptive commit messages, rather than
just patch subject lines.
Documentation-wise, the patchset mentions that host controller support
is required for this to work, but doesn't explain what kind of support
that is, and the sdhci-pci support seems unconditional on type of host
controller -- why wouldn't every controller work? Is it (just) because
other controller drivers use msleep?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-10-29 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1351000104-13015-1-git-send-email-irina.tirdea@intel.com>
2012-10-29 20:28 ` [PATCH 00/26] pstore, mmc: add mmc as backend for pstore Kirill A. Shutemov
2012-10-29 20:50 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87390xroil.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=adrian.hunter@intel.com \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=irina.tirdea@intel.com \
--cc=keescook@chromium.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox