* Re: [PATCH 00/26] pstore, mmc: add mmc as backend for pstore
2012-10-29 20:28 ` [PATCH 00/26] pstore, mmc: add mmc as backend for pstore Kirill A. Shutemov
@ 2012-10-29 20:50 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2012-10-29 20:50 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: Anton Vorontsov, Colin Cross, Kees Cook, Tony Luck, linux-kernel,
Adrian Hunter, Octavian Purdila, Irina Tirdea, linux-mmc
Hi,
On Mon, Oct 29 2012, Kirill A. Shutemov wrote:
> On Tue, Oct 23, 2012 at 04:47:58PM +0300, Irina Tirdea wrote:
>> These patches enable using the mmc card to store panic information.
>>
>> They include changes for pstore and mmc:
>> - add block device backend for pstore
>> - add logic in mmc for writing in panic mode
>
> Chris, any feedback on mmc/sdhci part?
Looks like the patchset hasn't been sent to linux-mmc@vger.kernel.org
yet -- could you send a v2 with that address included, please?
It would also be great to see descriptive commit messages, rather than
just patch subject lines.
Documentation-wise, the patchset mentions that host controller support
is required for this to work, but doesn't explain what kind of support
that is, and the sdhci-pci support seems unconditional on type of host
controller -- why wouldn't every controller work? Is it (just) because
other controller drivers use msleep?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread