From: NeilBrown <neil@brown.name>
To: Chaotian Jing <chaotian.jing@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
thirtythreeforty@gmail.com
Subject: Re: [PATCH 2/5] mmc: mtk-sd: don't hard-code interrupt trigger type
Date: Wed, 17 Apr 2019 08:12:28 +1000 [thread overview]
Message-ID: <878sw97g6r.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1555402302.18628.17.camel@mhfsdcap03>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Tue, Apr 16 2019, Chaotian Jing wrote:
> On Tue, 2019-04-16 at 14:47 +1000, NeilBrown wrote:
>> When using devicetree for configuration, interrupt trigger type
>> should be described in the dts file, not hard-coded in the C code.
>>
>> The mtk-sd silicon in the mt7621 soc uses an active-high interrupt
>> and so cannot be used with the current code.
>>
>> So remove the trigger and leave it to be set from devicetree.
>>
>> Signed-off-by: NeilBrown <neil@brown.name>
>> ---
>> drivers/mmc/host/mtk-sd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
>> index 4492a4465c0e..14e048239143 100644
>> --- a/drivers/mmc/host/mtk-sd.c
>> +++ b/drivers/mmc/host/mtk-sd.c
>> @@ -2243,7 +2243,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>> msdc_init_hw(host);
>>
>> ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq,
>> - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host);
>> +
> change it to IRQF_TRIGGER_NONE | IRQF_ONESHOT
Why do we need IRQF_ONESHOT. That is for threaded interrupted
handlers...
msdc_irq() clears the interrupts, so ONESHOT isn't needed.
???
NeilBrown
>> 0, pdev->name, host);
>> if (ret)
>> goto release;
>>
>>
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-04-16 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 4:47 [PATCH 0/5] mtk-sd enhancement to support MT7621 NeilBrown
2019-04-16 4:47 ` [PATCH 3/5] mmc: mtk-sd: add support for config found in mt7620 family SOCs NeilBrown
2019-04-16 4:47 ` [PATCH 2/5] mmc: mtk-sd: don't hard-code interrupt trigger type NeilBrown
2019-04-16 8:11 ` Chaotian Jing
2019-04-16 22:12 ` NeilBrown [this message]
2019-04-18 6:36 ` Chaotian Jing
2019-04-16 4:47 ` [PATCH 1/5] mmc: mtk-sd: support "voltage-ranges" setting NeilBrown
2019-04-16 4:47 ` [PATCH 5/5] mmc: mtk-sd: enable internal write-protect logic NeilBrown
2019-04-16 4:47 ` [PATCH 4/5] mmc: mtk-sd: enable internal card-detect logic NeilBrown
2019-04-18 6:39 ` Chaotian Jing
2019-05-04 8:18 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sw97g6r.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=chaotian.jing@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=thirtythreeforty@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox