From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Brian O'Keefe <bokeefe@alum.wpi.edu>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/2] mmc: sdio: Move SDIO IDs from rtl8723bs, driver to common include file
Date: Thu, 26 Nov 2020 08:28:31 +0100 [thread overview]
Message-ID: <X79ZH+COJbxqd+eJ@kroah.com> (raw)
In-Reply-To: <1760357a038.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
On Thu, Nov 26, 2020 at 07:57:23AM +0100, Arend Van Spriel wrote:
> On November 25, 2020 8:13:07 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>
> > On Wed, Nov 25, 2020 at 01:33:00PM -0500, Brian O'Keefe wrote:
> > > Macro names were derived from the Windows driver, as that was the best
> > > available source.
> >
> > Why move these? What does this help with?
>
> Hi Greg,
>
> Most if not all SDIO-based (wifi) drivers in mainline have their venid and
> devid definitions in that header file. So seems like a good idea to me, but
> maybe not so for a staging driver?
If the driver ever gets moved out, maybe do it then as part of that
effort. I haven't seen that happening, so I would recommend just
leaving this alone for now.
thanks,
greg k-h
next prev parent reply other threads:[~2020-11-26 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 18:23 [PATCH 1/2] mmc: sdio: Move SDIO IDs from rtl8723bs, driver to common include file Brian O'Keefe
2020-11-25 18:25 ` [PATCH 2/2] " Brian O'Keefe
2020-11-25 18:33 ` [PATCH 1/2] " Brian O'Keefe
2020-11-25 19:13 ` Greg Kroah-Hartman
2020-11-26 6:57 ` Arend Van Spriel
2020-11-26 7:28 ` Greg Kroah-Hartman [this message]
2020-11-26 12:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X79ZH+COJbxqd+eJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arend.vanspriel@broadcom.com \
--cc=bokeefe@alum.wpi.edu \
--cc=hdegoede@redhat.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox