public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Rename RZ/G2L SDHI clocks
@ 2021-11-22 10:39 Biju Das
  2021-11-22 10:39 ` [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks Biju Das
  2021-11-22 11:27 ` [PATCH 0/2] Rename RZ/G2L SDHI clocks Ulf Hansson
  0 siblings, 2 replies; 6+ messages in thread
From: Biju Das @ 2021-11-22 10:39 UTC (permalink / raw)
  To: Ulf Hansson, Rob Herring
  Cc: Biju Das, Wolfram Sang, linux-mmc, devicetree, Geert Uytterhoeven,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
	linux-renesas-soc

RZ/G2L SDHI has 4 clocks which is controlled by PM frame work and is using
Gen3 compatible string. Now the clock factorisation happened on highspeed
clock handling and it changes to fallback by getting parent clock, if
"clkh" is not specified in device tree.

This path series rename the clocks to match with the clock names used in
R-Car Gen2 and later generations. This will avoid driver changes related
to clock names.

This patch series based on renesas-devel

Biju Das (2):
  dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
  arm64: dts: renesas: r9a07g044: Rename SDHI clocks

 .../devicetree/bindings/mmc/renesas,sdhi.yaml          | 10 +++++-----
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi             |  8 ++++----
 2 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
  2021-11-22 10:39 [PATCH 0/2] Rename RZ/G2L SDHI clocks Biju Das
@ 2021-11-22 10:39 ` Biju Das
  2021-11-22 10:46   ` Wolfram Sang
  2021-11-23 13:38   ` Geert Uytterhoeven
  2021-11-22 11:27 ` [PATCH 0/2] Rename RZ/G2L SDHI clocks Ulf Hansson
  1 sibling, 2 replies; 6+ messages in thread
From: Biju Das @ 2021-11-22 10:39 UTC (permalink / raw)
  To: Ulf Hansson, Rob Herring
  Cc: Biju Das, Wolfram Sang, linux-mmc, devicetree, Geert Uytterhoeven,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
	linux-renesas-soc

Rename the below RZ/G2L clocks to match with the clock names used in
R-Car Gen2 and later generations.

 imclk->core
 clk_hs->clkh
 imclk2->cd

This changes will avoid using fallback for RZ/G2L high speed clock,
if "clkh" is not used in device tree and also the code changes in
driver related to this clocks.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Note:
 This patch series based on renesas-devel and depend upon [1]

 [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git/commit/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml?id=e051025efac3929ca7e3e2f2c8860d3447366ebc
---
 .../devicetree/bindings/mmc/renesas,sdhi.yaml          | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index f5107a641790..9ce6e06c19db 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -113,17 +113,17 @@ allOf:
         clocks:
           items:
             - description: IMCLK, SDHI channel main clock1.
+            - description: CLK_HS, SDHI channel High speed clock which operates
+                           4 times that of SDHI channel main clock1.
             - description: IMCLK2, SDHI channel main clock2. When this clock is
                            turned off, external SD card detection cannot be
                            detected.
-            - description: CLK_HS, SDHI channel High speed clock which operates
-                           4 times that of SDHI channel main clock1.
             - description: ACLK, SDHI channel bus clock.
         clock-names:
           items:
-            - const: imclk
-            - const: imclk2
-            - const: clk_hs
+            - const: core
+            - const: clkh
+            - const: cd
             - const: aclk
       required:
         - clock-names
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
  2021-11-22 10:39 ` [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks Biju Das
@ 2021-11-22 10:46   ` Wolfram Sang
  2021-11-23 13:38   ` Geert Uytterhoeven
  1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-11-22 10:46 UTC (permalink / raw)
  To: Biju Das
  Cc: Ulf Hansson, Rob Herring, linux-mmc, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	Prabhakar Mahadev Lad, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Mon, Nov 22, 2021 at 10:39:04AM +0000, Biju Das wrote:
> Rename the below RZ/G2L clocks to match with the clock names used in
> R-Car Gen2 and later generations.
> 
>  imclk->core
>  clk_hs->clkh
>  imclk2->cd
> 
> This changes will avoid using fallback for RZ/G2L high speed clock,
> if "clkh" is not used in device tree and also the code changes in
> driver related to this clocks.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

The bindings match what we discussed. Thanks!

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Rename RZ/G2L SDHI clocks
  2021-11-22 10:39 [PATCH 0/2] Rename RZ/G2L SDHI clocks Biju Das
  2021-11-22 10:39 ` [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks Biju Das
@ 2021-11-22 11:27 ` Ulf Hansson
  1 sibling, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2021-11-22 11:27 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Wolfram Sang, linux-mmc, devicetree,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	Prabhakar Mahadev Lad, linux-renesas-soc

On Mon, 22 Nov 2021 at 11:39, Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> RZ/G2L SDHI has 4 clocks which is controlled by PM frame work and is using
> Gen3 compatible string. Now the clock factorisation happened on highspeed
> clock handling and it changes to fallback by getting parent clock, if
> "clkh" is not specified in device tree.
>
> This path series rename the clocks to match with the clock names used in
> R-Car Gen2 and later generations. This will avoid driver changes related
> to clock names.
>
> This patch series based on renesas-devel

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

>
> Biju Das (2):
>   dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
>   arm64: dts: renesas: r9a07g044: Rename SDHI clocks
>
>  .../devicetree/bindings/mmc/renesas,sdhi.yaml          | 10 +++++-----
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi             |  8 ++++----
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
  2021-11-22 10:39 ` [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks Biju Das
  2021-11-22 10:46   ` Wolfram Sang
@ 2021-11-23 13:38   ` Geert Uytterhoeven
  2021-11-23 16:16     ` Ulf Hansson
  1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-11-23 13:38 UTC (permalink / raw)
  To: Biju Das
  Cc: Ulf Hansson, Rob Herring, Wolfram Sang, Linux MMC List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	Prabhakar Mahadev Lad, Linux-Renesas

On Mon, Nov 22, 2021 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Rename the below RZ/G2L clocks to match with the clock names used in
> R-Car Gen2 and later generations.
>
>  imclk->core
>  clk_hs->clkh
>  imclk2->cd
>
> This changes will avoid using fallback for RZ/G2L high speed clock,
> if "clkh" is not used in device tree and also the code changes in
> driver related to this clocks.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.17 if Ulf is happy.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks
  2021-11-23 13:38   ` Geert Uytterhoeven
@ 2021-11-23 16:16     ` Ulf Hansson
  0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2021-11-23 16:16 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Biju Das, Rob Herring, Wolfram Sang, Linux MMC List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	Prabhakar Mahadev Lad, Linux-Renesas

On Tue, 23 Nov 2021 at 14:38, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Mon, Nov 22, 2021 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Rename the below RZ/G2L clocks to match with the clock names used in
> > R-Car Gen2 and later generations.
> >
> >  imclk->core
> >  clk_hs->clkh
> >  imclk2->cd
> >
> > This changes will avoid using fallback for RZ/G2L high speed clock,
> > if "clkh" is not used in device tree and also the code changes in
> > driver related to this clocks.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.17 if Ulf is happy.

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-11-23 16:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-22 10:39 [PATCH 0/2] Rename RZ/G2L SDHI clocks Biju Das
2021-11-22 10:39 ` [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Rename RZ/G2L clocks Biju Das
2021-11-22 10:46   ` Wolfram Sang
2021-11-23 13:38   ` Geert Uytterhoeven
2021-11-23 16:16     ` Ulf Hansson
2021-11-22 11:27 ` [PATCH 0/2] Rename RZ/G2L SDHI clocks Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox