* RE: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
2025-03-14 10:11 [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() Dan Carpenter
@ 2025-03-14 10:15 ` Biju Das
2025-03-14 10:23 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Biju Das @ 2025-03-14 10:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Wolfram Sang, Ulf Hansson, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan Carpenter,
Thanks for the patch.
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: 14 March 2025 10:11
> Subject: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
>
> If devm_regulator_register() fails then propagate the error code. Don't return success.
>
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Cheers,
Biju
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 396fa2816a15..fa6526be3638 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> of_node_put(rcfg.of_node);
> if (IS_ERR(rdev)) {
> dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
> + ret = PTR_ERR(rdev);
> goto efree;
> }
> priv->rdev = rdev;
> --
> 2.47.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
2025-03-14 10:11 [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() Dan Carpenter
2025-03-14 10:15 ` Biju Das
@ 2025-03-14 10:23 ` Geert Uytterhoeven
2025-03-14 10:23 ` Wolfram Sang
2025-03-17 10:51 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2025-03-14 10:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Biju Das, Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc,
linux-kernel, kernel-janitors
On Fri, 14 Mar 2025 at 11:12, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> If devm_regulator_register() fails then propagate the error code. Don't
> return success.
>
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
2025-03-14 10:11 [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() Dan Carpenter
2025-03-14 10:15 ` Biju Das
2025-03-14 10:23 ` Geert Uytterhoeven
@ 2025-03-14 10:23 ` Wolfram Sang
2025-03-17 10:51 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-14 10:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Biju Das, Ulf Hansson, linux-mmc, linux-renesas-soc, linux-kernel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Fri, Mar 14, 2025 at 01:11:09PM +0300, Dan Carpenter wrote:
> If devm_regulator_register() fails then propagate the error code. Don't
> return success.
>
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks for this and maintaining smatch!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
2025-03-14 10:11 [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() Dan Carpenter
` (2 preceding siblings ...)
2025-03-14 10:23 ` Wolfram Sang
@ 2025-03-17 10:51 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2025-03-17 10:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Biju Das, Wolfram Sang, linux-mmc, linux-renesas-soc,
linux-kernel, kernel-janitors
On Fri, 14 Mar 2025 at 11:11, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> If devm_regulator_register() fails then propagate the error code. Don't
> return success.
>
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 396fa2816a15..fa6526be3638 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> of_node_put(rcfg.of_node);
> if (IS_ERR(rdev)) {
> dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
> + ret = PTR_ERR(rdev);
> goto efree;
> }
> priv->rdev = rdev;
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread