Re: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

hi!

> > I'm afraid I'm not familiar with the details either, but this is how the
> > SDIO wifi device for the Pinephone is defined (in
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi, as of v6.8-rc2):
> > 
> > &mmc1 {
> >         pinctrl-names = "default";
> >         pinctrl-0 = <&mmc1_pins>;
> >         vmmc-supply = <&reg_vbat_wifi>;
> >         vqmmc-supply = <&reg_dldo4>;
> >         bus-width = <4>;
> >         non-removable;
> >         status = "okay";
> > 
> >         rtl8723cs: wifi@1 {
> 
> I think rtl8723cs is module name of vendor driver, so will you add rtw88_8723ds?

dts is supposed to describe hardware, not driver structure. So a) this
label should not really matter b) it really should not really be
changed to match the driver name.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]