* [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn
@ 2024-02-08 20:21 Krzysztof Kozlowski
2024-02-09 0:10 ` Wolfram Sang
2024-02-13 16:45 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-08 20:21 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc,
linux-kernel
Cc: Krzysztof Kozlowski
Use existing typedef for dma_filter_fn to avoid duplicating type
definition.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/mmc/host/renesas_sdhi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index c1fb9740eab0..586f94d4dbfd 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -9,6 +9,7 @@
#ifndef RENESAS_SDHI_H
#define RENESAS_SDHI_H
+#include <linux/dmaengine.h>
#include <linux/platform_device.h>
#include "tmio_mmc.h"
@@ -63,7 +64,7 @@ struct renesas_sdhi_of_data_with_quirks {
struct renesas_sdhi_dma {
unsigned long end_flags;
enum dma_slave_buswidth dma_buswidth;
- bool (*filter)(struct dma_chan *chan, void *arg);
+ dma_filter_fn filter;
void (*enable)(struct tmio_mmc_host *host, bool enable);
struct completion dma_dataend;
struct tasklet_struct dma_complete;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn
2024-02-08 20:21 [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn Krzysztof Kozlowski
@ 2024-02-09 0:10 ` Wolfram Sang
2024-02-13 16:45 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2024-02-09 0:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, linux-mmc, linux-renesas-soc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
On Thu, Feb 08, 2024 at 09:21:37PM +0100, Krzysztof Kozlowski wrote:
> Use existing typedef for dma_filter_fn to avoid duplicating type
> definition.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn
2024-02-08 20:21 [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn Krzysztof Kozlowski
2024-02-09 0:10 ` Wolfram Sang
@ 2024-02-13 16:45 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-02-13 16:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wolfram Sang, linux-mmc, linux-renesas-soc, linux-kernel
On Thu, 8 Feb 2024 at 21:21, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Use existing typedef for dma_filter_fn to avoid duplicating type
> definition.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index c1fb9740eab0..586f94d4dbfd 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -9,6 +9,7 @@
> #ifndef RENESAS_SDHI_H
> #define RENESAS_SDHI_H
>
> +#include <linux/dmaengine.h>
> #include <linux/platform_device.h>
> #include "tmio_mmc.h"
>
> @@ -63,7 +64,7 @@ struct renesas_sdhi_of_data_with_quirks {
> struct renesas_sdhi_dma {
> unsigned long end_flags;
> enum dma_slave_buswidth dma_buswidth;
> - bool (*filter)(struct dma_chan *chan, void *arg);
> + dma_filter_fn filter;
> void (*enable)(struct tmio_mmc_host *host, bool enable);
> struct completion dma_dataend;
> struct tasklet_struct dma_complete;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-13 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-08 20:21 [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn Krzysztof Kozlowski
2024-02-09 0:10 ` Wolfram Sang
2024-02-13 16:45 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox