* [PATCH] mmc: dw_mmc: remove unneeded assignment
@ 2024-03-07 12:21 Muhammad Usama Anjum
2024-03-07 12:22 ` Yang Xiwen
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-07 12:21 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson, Yang Xiwen
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-mmc,
linux-kernel
The err is being set to 0 and replaced every time after this
assignment. Remove this assignment as it is extraneous.
Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
index 989ae8dda7228..96af693e3e37c 100644
--- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
@@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
goto tuning_out;
prev_err = err;
- err = 0;
}
tuning_out:
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
@ 2024-03-07 12:22 ` Yang Xiwen
2024-03-07 14:51 ` Muhammad Usama Anjum
2024-03-07 12:24 ` AngeloGioacchino Del Regno
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Yang Xiwen @ 2024-03-07 12:22 UTC (permalink / raw)
To: Muhammad Usama Anjum, Jaehoon Chung, Ulf Hansson
Cc: kernel, kernel-janitors, linux-mmc, linux-kernel
On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
Same for dw_mmc-hi3798cv200.c, maybe fix it as well?
> }
>
> tuning_out:
--
Regards,
Yang Xiwen
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 12:22 ` Yang Xiwen
@ 2024-03-07 14:51 ` Muhammad Usama Anjum
2024-03-07 15:01 ` Dan Carpenter
0 siblings, 1 reply; 10+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-07 14:51 UTC (permalink / raw)
To: Yang Xiwen
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-mmc,
linux-kernel, Jaehoon Chung, Ulf Hansson
On 3/7/24 5:22 PM, Yang Xiwen wrote:
> On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
>> The err is being set to 0 and replaced every time after this
>> assignment. Remove this assignment as it is extraneous.
>>
>> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> b/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> index 989ae8dda7228..96af693e3e37c 100644
>> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> @@ -133,7 +133,6 @@ static int
>> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
>> goto tuning_out;
>> prev_err = err;
>> - err = 0;
>
>
> Same for dw_mmc-hi3798cv200.c, maybe fix it as well?
Sent separately as different Fixes tag is required for that:
https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com
>
>
>> }
>> tuning_out:
>
>
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 14:51 ` Muhammad Usama Anjum
@ 2024-03-07 15:01 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2024-03-07 15:01 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Yang Xiwen, kernel, kernel-janitors, linux-mmc, linux-kernel,
Jaehoon Chung, Ulf Hansson
On Thu, Mar 07, 2024 at 07:51:37PM +0500, Muhammad Usama Anjum wrote:
> On 3/7/24 5:22 PM, Yang Xiwen wrote:
> > On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
> >> The err is being set to 0 and replaced every time after this
> >> assignment. Remove this assignment as it is extraneous.
> >>
> >> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> >> ---
> >> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> index 989ae8dda7228..96af693e3e37c 100644
> >> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> >> @@ -133,7 +133,6 @@ static int
> >> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> >> goto tuning_out;
> >> prev_err = err;
> >> - err = 0;
> >
> >
> > Same for dw_mmc-hi3798cv200.c, maybe fix it as well?
> Sent separately as different Fixes tag is required for that:
> https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com
>
The subjects are identical though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
2024-03-07 12:22 ` Yang Xiwen
@ 2024-03-07 12:24 ` AngeloGioacchino Del Regno
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
3 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-03-07 12:24 UTC (permalink / raw)
To: Muhammad Usama Anjum, Jaehoon Chung, Ulf Hansson, Yang Xiwen
Cc: kernel, kernel-janitors, linux-mmc, linux-kernel
Il 07/03/24 13:21, Muhammad Usama Anjum ha scritto:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
2024-03-07 12:22 ` Yang Xiwen
2024-03-07 12:24 ` AngeloGioacchino Del Regno
@ 2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
3 siblings, 0 replies; 10+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-25 7:06 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson, Yang Xiwen
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-mmc,
linux-kernel
Soft reminder
On 3/7/24 5:21 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
` (2 preceding siblings ...)
2024-03-25 7:06 ` Muhammad Usama Anjum
@ 2024-03-25 13:18 ` Ulf Hansson
3 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2024-03-25 13:18 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Jaehoon Chung, Yang Xiwen, kernel, kernel-janitors, linux-mmc,
linux-kernel
On Thu, 7 Mar 2024 at 13:21, Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
Again, this isn't needed I think, so I have dropped it.
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Applied for next and by amending the commit message prefix to "mmc:
dw_mmc-hi3798mv200", thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] mmc: dw_mmc: remove unneeded assignment
@ 2024-03-07 14:50 Muhammad Usama Anjum
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
0 siblings, 2 replies; 10+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-07 14:50 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson, tianshuliang, Shawn Guo,
Jiancheng Xue, Shawn Lin
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-mmc,
linux-kernel
The err is being set to 0 and replaced every time after this
assignment. Remove this assignment as it is extraneous.
Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
index 61923a5183693..6099756e59b3c 100644
--- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
@@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
goto tuning_out;
prev_err = err;
- err = 0;
}
tuning_out:
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 14:50 Muhammad Usama Anjum
@ 2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
1 sibling, 0 replies; 10+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-25 7:06 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson, tianshuliang, Shawn Guo,
Jiancheng Xue, Shawn Lin
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-mmc,
linux-kernel
Soft reminder
On 3/7/24 7:50 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 61923a5183693..6099756e59b3c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
2024-03-07 14:50 Muhammad Usama Anjum
2024-03-25 7:06 ` Muhammad Usama Anjum
@ 2024-03-25 13:18 ` Ulf Hansson
1 sibling, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2024-03-25 13:18 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Jaehoon Chung, tianshuliang, Shawn Guo, Jiancheng Xue, Shawn Lin,
kernel, kernel-janitors, linux-mmc, linux-kernel
On Thu, 7 Mar 2024 at 15:49, Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")
I don't think we need a fixes tag here, so I have dropped it.
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Applied for next and by amending the commit message prefix to "mmc:
dw_mmc-hi3798cv200", thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 61923a5183693..6099756e59b3c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-03-25 13:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-07 12:21 [PATCH] mmc: dw_mmc: remove unneeded assignment Muhammad Usama Anjum
2024-03-07 12:22 ` Yang Xiwen
2024-03-07 14:51 ` Muhammad Usama Anjum
2024-03-07 15:01 ` Dan Carpenter
2024-03-07 12:24 ` AngeloGioacchino Del Regno
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2024-03-07 14:50 Muhammad Usama Anjum
2024-03-25 7:06 ` Muhammad Usama Anjum
2024-03-25 13:18 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox