From: Adrian Hunter <adrian.hunter@intel.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code
Date: Wed, 2 Nov 2022 12:22:34 +0200 [thread overview]
Message-ID: <bc14b1e4-2034-c70d-66b9-47da89726037@intel.com> (raw)
In-Reply-To: <20221101105242.2019036-1-matthias.schiffer@ew.tq-group.com>
On 1/11/22 12:52, Matthias Schiffer wrote:
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>
next prev parent reply other threads:[~2022-11-02 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 10:52 [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code Matthias Schiffer
2022-11-02 10:22 ` Adrian Hunter [this message]
2022-11-07 20:13 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc14b1e4-2034-c70d-66b9-47da89726037@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox