* [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code
@ 2022-11-01 10:52 Matthias Schiffer
2022-11-02 10:22 ` Adrian Hunter
2022-11-07 20:13 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Schiffer @ 2022-11-01 10:52 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Matthias Schiffer
Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/mmc/host/sdhci_am654.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 8f1023480e12..4e17efa8ab97 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
ret = mmc_of_parse(host->mmc);
if (ret) {
- dev_err(dev, "parsing dt failed (%d)\n", ret);
+ dev_err_probe(dev, ret, "parsing dt failed\n");
goto pm_runtime_put;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code
2022-11-01 10:52 [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code Matthias Schiffer
@ 2022-11-02 10:22 ` Adrian Hunter
2022-11-07 20:13 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2022-11-02 10:22 UTC (permalink / raw)
To: Matthias Schiffer, Ulf Hansson; +Cc: linux-mmc, linux-kernel
On 1/11/22 12:52, Matthias Schiffer wrote:
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code
2022-11-01 10:52 [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code Matthias Schiffer
2022-11-02 10:22 ` Adrian Hunter
@ 2022-11-07 20:13 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-11-07 20:13 UTC (permalink / raw)
To: Matthias Schiffer; +Cc: Adrian Hunter, linux-mmc, linux-kernel
On Tue, 1 Nov 2022 at 11:53, Matthias Schiffer
<matthias.schiffer@ew.tq-group.com> wrote:
>
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-07 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 10:52 [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code Matthias Schiffer
2022-11-02 10:22 ` Adrian Hunter
2022-11-07 20:13 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox