From: "Christian Löhle" <CLoehle@hyperstone.com>
To: Avri Altman <Avri.Altman@wdc.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: [PATCH] mmc-utils: Add basic erase error check
Date: Mon, 16 Jan 2023 10:49:15 +0000 [thread overview]
Message-ID: <ca4d29de093e4e29a2222c4d94a9367f@hyperstone.com> (raw)
Check for erase specific R1 errors so e.g. an OOR erase is not
reported as successful when it never executed.
There could be checks for more error bits but R1_ERASE_SEQ_ERROR
on CMD38 should catch all that are reported by hardware anyway.
Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
---
-v2: Remove unneeded error bit checking
mmc_cmds.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/mmc_cmds.c b/mmc_cmds.c
index e6d3273..97fdb59 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -54,7 +54,6 @@
#define WPTYPE_PWRON 2
#define WPTYPE_PERM 3
-
int read_extcsd(int fd, __u8 *ext_csd)
{
int ret = 0;
@@ -2668,6 +2667,18 @@ static int erase(int dev_fd, __u32 argin, __u32 start, __u32 end)
if (ret)
perror("Erase multi-cmd ioctl");
+ /* Does not work for SPI cards */
+ if (multi_cmd->cmds[0].response[0] & R1_ERASE_PARAM) {
+ fprintf(stderr, "Erase start response: 0x%08x\n",
+ multi_cmd->cmds[0].response[0]);
+ ret = -EIO;
+ }
+ if (multi_cmd->cmds[2].response[0] & R1_ERASE_SEQ_ERROR) {
+ fprintf(stderr, "Erase response: 0x%08x\n",
+ multi_cmd->cmds[2].response[0]);
+ ret = -EIO;
+ }
+
free(multi_cmd);
return ret;
}
--
2.37.3
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
next reply other threads:[~2023-01-16 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:49 Christian Löhle [this message]
2023-01-16 11:10 ` [PATCH] mmc-utils: Add basic erase error check Avri Altman
-- strict thread matches above, loose matches on Subject: below --
2022-12-12 9:21 Christian Löhle
2022-12-12 13:44 ` Avri Altman
2022-12-12 14:00 ` Christian Löhle
2022-12-12 14:08 ` Christian Löhle
2022-12-13 14:00 ` Avri Altman
2022-12-13 15:26 ` Christian Löhle
2022-12-14 8:15 ` Avri Altman
2022-12-15 18:14 ` Christian Löhle
2022-12-16 6:11 ` Avri Altman
2023-01-02 12:01 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4d29de093e4e29a2222c4d94a9367f@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=Avri.Altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox