Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies

[Adrian Hunter <adrian.hunter@intel.com>]

On 2/01/24 12:10, Peter Robinson wrote:
> On Tue, Jan 2, 2024 at 10:06 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> On 20/12/23 15:59, Peter Robinson wrote:
>>> The sdhci_am654 is specific to recent TI SoCs, update the
>>> dependencies for those SoCs and compile testing. While we're
>>> at it update the text to reflect the wider range of
>>> supported TI SoCS the driver now supports.
>>>
>>> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
>>
>> Is this really a fix?  Seems like a minor improvement.
>> Same question for patch 2/2.
> 
> It is for distro kernels at least :)

Distros ship thousands of modules.  I am not sure one more or
less makes any difference?

> 
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>>
>> It would be good to get an Ack from a TI person.
>> Same for patch 2/2.
>>
>>> ---
>>>  drivers/mmc/host/Kconfig | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index 58bd5fe4cd25..24ce5576b61a 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
>>>
>>>  config MMC_SDHCI_AM654
>>>       tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
>>> +     depends on ARCH_K3 || COMPILE_TEST
>>>       depends on MMC_SDHCI_PLTFM && OF
>>>       select MMC_SDHCI_IO_ACCESSORS
>>>       select MMC_CQHCI
>>>       select REGMAP_MMIO
>>>       help
>>>         This selects the Secure Digital Host Controller Interface (SDHCI)
>>> -       support present in TI's AM654 SOCs. The controller supports
>>> -       SD/MMC/SDIO devices.
>>> +       support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
>>> +       supports SD/MMC/SDIO devices.
>>>
>>>         If you have a controller with this interface, say Y or M here.
>>>
>>