From: Adrian Hunter <adrian.hunter@intel.com>
To: Peter Robinson <pbrobinson@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Faiz Abbas <faiz_abbas@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Tony Lindgren <tony@atomide.com>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
Date: Tue, 2 Jan 2024 12:06:35 +0200 [thread overview]
Message-ID: <0fe97709-6b6c-4c66-82a1-ecf58dde5b3f@intel.com> (raw)
In-Reply-To: <20231220135950.433588-1-pbrobinson@gmail.com>
On 20/12/23 15:59, Peter Robinson wrote:
> The sdhci_am654 is specific to recent TI SoCs, update the
> dependencies for those SoCs and compile testing. While we're
> at it update the text to reflect the wider range of
> supported TI SoCS the driver now supports.
>
> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
Is this really a fix? Seems like a minor improvement.
Same question for patch 2/2.
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
It would be good to get an Ack from a TI person.
Same for patch 2/2.
> ---
> drivers/mmc/host/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 58bd5fe4cd25..24ce5576b61a 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
>
> config MMC_SDHCI_AM654
> tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> + depends on ARCH_K3 || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM && OF
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> select REGMAP_MMIO
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> - support present in TI's AM654 SOCs. The controller supports
> - SD/MMC/SDIO devices.
> + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
> + supports SD/MMC/SDIO devices.
>
> If you have a controller with this interface, say Y or M here.
>
next prev parent reply other threads:[~2024-01-02 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 13:59 [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies Peter Robinson
2023-12-20 13:59 ` [PATCH 2/2] mmc: sdhci_omap: " Peter Robinson
2024-01-02 10:06 ` Adrian Hunter [this message]
2024-01-02 10:10 ` [PATCH 1/2] mmc: sdhci_am654: " Peter Robinson
2024-01-02 10:22 ` Adrian Hunter
2024-01-02 10:29 ` Peter Robinson
2024-01-02 16:57 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe97709-6b6c-4c66-82a1-ecf58dde5b3f@intel.com \
--to=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox