* [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
@ 2023-12-20 13:59 Peter Robinson
2023-12-20 13:59 ` [PATCH 2/2] mmc: sdhci_omap: " Peter Robinson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Peter Robinson @ 2023-12-20 13:59 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, Faiz Abbas, Kishon Vijay Abraham I,
Tony Lindgren, linux-mmc, linux-omap, linux-arm-kernel
Cc: Peter Robinson
The sdhci_am654 is specific to recent TI SoCs, update the
dependencies for those SoCs and compile testing. While we're
at it update the text to reflect the wider range of
supported TI SoCS the driver now supports.
Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/mmc/host/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 58bd5fe4cd25..24ce5576b61a 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
config MMC_SDHCI_AM654
tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
+ depends on ARCH_K3 || COMPILE_TEST
depends on MMC_SDHCI_PLTFM && OF
select MMC_SDHCI_IO_ACCESSORS
select MMC_CQHCI
select REGMAP_MMIO
help
This selects the Secure Digital Host Controller Interface (SDHCI)
- support present in TI's AM654 SOCs. The controller supports
- SD/MMC/SDIO devices.
+ support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
+ supports SD/MMC/SDIO devices.
If you have a controller with this interface, say Y or M here.
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] mmc: sdhci_omap: Fix TI SoC dependencies
2023-12-20 13:59 [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies Peter Robinson
@ 2023-12-20 13:59 ` Peter Robinson
2024-01-02 10:06 ` [PATCH 1/2] mmc: sdhci_am654: " Adrian Hunter
2024-01-02 16:57 ` Ulf Hansson
2 siblings, 0 replies; 7+ messages in thread
From: Peter Robinson @ 2023-12-20 13:59 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, Faiz Abbas, Kishon Vijay Abraham I,
Tony Lindgren, linux-mmc, linux-omap, linux-arm-kernel
Cc: Peter Robinson
The sdhci_omap is specific to older TI SoCs, update the
dependencies for those SoCs and compile testing. While we're
at it update the text to reflect the wider range of
supported TI SoCS the driver now supports.
Fixes: 7d326930d352 ("mmc: sdhci-omap: Add OMAP SDHCI driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/mmc/host/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 24ce5576b61a..81f2c4e05287 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1026,14 +1026,15 @@ config MMC_SDHCI_XENON
config MMC_SDHCI_OMAP
tristate "TI SDHCI Controller Support"
+ depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
depends on MMC_SDHCI_PLTFM && OF
select THERMAL
imply TI_SOC_THERMAL
select MMC_SDHCI_EXTERNAL_DMA if DMA_ENGINE
help
This selects the Secure Digital Host Controller Interface (SDHCI)
- support present in TI's DRA7 SOCs. The controller supports
- SD/MMC/SDIO devices.
+ support present in TI's Keystone/OMAP2+/DRA7 SOCs. The controller
+ supports SD/MMC/SDIO devices.
If you have a controller with this interface, say Y or M here.
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
2023-12-20 13:59 [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies Peter Robinson
2023-12-20 13:59 ` [PATCH 2/2] mmc: sdhci_omap: " Peter Robinson
@ 2024-01-02 10:06 ` Adrian Hunter
2024-01-02 10:10 ` Peter Robinson
2024-01-02 16:57 ` Ulf Hansson
2 siblings, 1 reply; 7+ messages in thread
From: Adrian Hunter @ 2024-01-02 10:06 UTC (permalink / raw)
To: Peter Robinson, Ulf Hansson, Faiz Abbas, Kishon Vijay Abraham I,
Tony Lindgren, linux-mmc, linux-omap, linux-arm-kernel
On 20/12/23 15:59, Peter Robinson wrote:
> The sdhci_am654 is specific to recent TI SoCs, update the
> dependencies for those SoCs and compile testing. While we're
> at it update the text to reflect the wider range of
> supported TI SoCS the driver now supports.
>
> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
Is this really a fix? Seems like a minor improvement.
Same question for patch 2/2.
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
It would be good to get an Ack from a TI person.
Same for patch 2/2.
> ---
> drivers/mmc/host/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 58bd5fe4cd25..24ce5576b61a 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
>
> config MMC_SDHCI_AM654
> tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> + depends on ARCH_K3 || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM && OF
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> select REGMAP_MMIO
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> - support present in TI's AM654 SOCs. The controller supports
> - SD/MMC/SDIO devices.
> + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
> + supports SD/MMC/SDIO devices.
>
> If you have a controller with this interface, say Y or M here.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
2024-01-02 10:06 ` [PATCH 1/2] mmc: sdhci_am654: " Adrian Hunter
@ 2024-01-02 10:10 ` Peter Robinson
2024-01-02 10:22 ` Adrian Hunter
0 siblings, 1 reply; 7+ messages in thread
From: Peter Robinson @ 2024-01-02 10:10 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ulf Hansson, Faiz Abbas, Kishon Vijay Abraham I, Tony Lindgren,
linux-mmc, linux-omap, linux-arm-kernel
On Tue, Jan 2, 2024 at 10:06 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 20/12/23 15:59, Peter Robinson wrote:
> > The sdhci_am654 is specific to recent TI SoCs, update the
> > dependencies for those SoCs and compile testing. While we're
> > at it update the text to reflect the wider range of
> > supported TI SoCS the driver now supports.
> >
> > Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
>
> Is this really a fix? Seems like a minor improvement.
> Same question for patch 2/2.
It is for distro kernels at least :)
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> It would be good to get an Ack from a TI person.
> Same for patch 2/2.
>
> > ---
> > drivers/mmc/host/Kconfig | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 58bd5fe4cd25..24ce5576b61a 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
> >
> > config MMC_SDHCI_AM654
> > tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> > + depends on ARCH_K3 || COMPILE_TEST
> > depends on MMC_SDHCI_PLTFM && OF
> > select MMC_SDHCI_IO_ACCESSORS
> > select MMC_CQHCI
> > select REGMAP_MMIO
> > help
> > This selects the Secure Digital Host Controller Interface (SDHCI)
> > - support present in TI's AM654 SOCs. The controller supports
> > - SD/MMC/SDIO devices.
> > + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
> > + supports SD/MMC/SDIO devices.
> >
> > If you have a controller with this interface, say Y or M here.
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
2024-01-02 10:10 ` Peter Robinson
@ 2024-01-02 10:22 ` Adrian Hunter
2024-01-02 10:29 ` Peter Robinson
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Hunter @ 2024-01-02 10:22 UTC (permalink / raw)
To: Peter Robinson
Cc: Ulf Hansson, Faiz Abbas, Kishon Vijay Abraham I, Tony Lindgren,
linux-mmc, linux-omap, linux-arm-kernel
On 2/01/24 12:10, Peter Robinson wrote:
> On Tue, Jan 2, 2024 at 10:06 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> On 20/12/23 15:59, Peter Robinson wrote:
>>> The sdhci_am654 is specific to recent TI SoCs, update the
>>> dependencies for those SoCs and compile testing. While we're
>>> at it update the text to reflect the wider range of
>>> supported TI SoCS the driver now supports.
>>>
>>> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
>>
>> Is this really a fix? Seems like a minor improvement.
>> Same question for patch 2/2.
>
> It is for distro kernels at least :)
Distros ship thousands of modules. I am not sure one more or
less makes any difference?
>
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>>
>> It would be good to get an Ack from a TI person.
>> Same for patch 2/2.
>>
>>> ---
>>> drivers/mmc/host/Kconfig | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index 58bd5fe4cd25..24ce5576b61a 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
>>>
>>> config MMC_SDHCI_AM654
>>> tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
>>> + depends on ARCH_K3 || COMPILE_TEST
>>> depends on MMC_SDHCI_PLTFM && OF
>>> select MMC_SDHCI_IO_ACCESSORS
>>> select MMC_CQHCI
>>> select REGMAP_MMIO
>>> help
>>> This selects the Secure Digital Host Controller Interface (SDHCI)
>>> - support present in TI's AM654 SOCs. The controller supports
>>> - SD/MMC/SDIO devices.
>>> + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
>>> + supports SD/MMC/SDIO devices.
>>>
>>> If you have a controller with this interface, say Y or M here.
>>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
2024-01-02 10:22 ` Adrian Hunter
@ 2024-01-02 10:29 ` Peter Robinson
0 siblings, 0 replies; 7+ messages in thread
From: Peter Robinson @ 2024-01-02 10:29 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ulf Hansson, Faiz Abbas, Kishon Vijay Abraham I, Tony Lindgren,
linux-mmc, linux-omap, linux-arm-kernel
On Tue, Jan 2, 2024 at 10:22 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 2/01/24 12:10, Peter Robinson wrote:
> > On Tue, Jan 2, 2024 at 10:06 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >>
> >> On 20/12/23 15:59, Peter Robinson wrote:
> >>> The sdhci_am654 is specific to recent TI SoCs, update the
> >>> dependencies for those SoCs and compile testing. While we're
> >>> at it update the text to reflect the wider range of
> >>> supported TI SoCS the driver now supports.
> >>>
> >>> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> >>
> >> Is this really a fix? Seems like a minor improvement.
> >> Same question for patch 2/2.
> >
> > It is for distro kernels at least :)
>
> Distros ship thousands of modules. I am not sure one more or
> less makes any difference?
I added the fixes because that's what a lot of other similar patches
do, see 4920bded3e and 1f223208e in CAN drivers I was looking at
recently, if you want to drop the fixes tag I don't mind but I was
mostly just following what numerous other similar patches do :)
> >
> >>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> >>
> >> It would be good to get an Ack from a TI person.
> >> Same for patch 2/2.
> >>
> >>> ---
> >>> drivers/mmc/host/Kconfig | 5 +++--
> >>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >>> index 58bd5fe4cd25..24ce5576b61a 100644
> >>> --- a/drivers/mmc/host/Kconfig
> >>> +++ b/drivers/mmc/host/Kconfig
> >>> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
> >>>
> >>> config MMC_SDHCI_AM654
> >>> tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> >>> + depends on ARCH_K3 || COMPILE_TEST
> >>> depends on MMC_SDHCI_PLTFM && OF
> >>> select MMC_SDHCI_IO_ACCESSORS
> >>> select MMC_CQHCI
> >>> select REGMAP_MMIO
> >>> help
> >>> This selects the Secure Digital Host Controller Interface (SDHCI)
> >>> - support present in TI's AM654 SOCs. The controller supports
> >>> - SD/MMC/SDIO devices.
> >>> + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
> >>> + supports SD/MMC/SDIO devices.
> >>>
> >>> If you have a controller with this interface, say Y or M here.
> >>>
> >>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies
2023-12-20 13:59 [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies Peter Robinson
2023-12-20 13:59 ` [PATCH 2/2] mmc: sdhci_omap: " Peter Robinson
2024-01-02 10:06 ` [PATCH 1/2] mmc: sdhci_am654: " Adrian Hunter
@ 2024-01-02 16:57 ` Ulf Hansson
2 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2024-01-02 16:57 UTC (permalink / raw)
To: Peter Robinson
Cc: Adrian Hunter, Faiz Abbas, Kishon Vijay Abraham I, Tony Lindgren,
linux-mmc, linux-omap, linux-arm-kernel
On Wed, 20 Dec 2023 at 14:59, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> The sdhci_am654 is specific to recent TI SoCs, update the
> dependencies for those SoCs and compile testing. While we're
> at it update the text to reflect the wider range of
> supported TI SoCS the driver now supports.
>
> Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Applied for next (and patch2/2), thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 58bd5fe4cd25..24ce5576b61a 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1041,14 +1041,15 @@ config MMC_SDHCI_OMAP
>
> config MMC_SDHCI_AM654
> tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> + depends on ARCH_K3 || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM && OF
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> select REGMAP_MMIO
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> - support present in TI's AM654 SOCs. The controller supports
> - SD/MMC/SDIO devices.
> + support present in TI's AM65x/AM64x/AM62x/J721E SOCs. The controller
> + supports SD/MMC/SDIO devices.
>
> If you have a controller with this interface, say Y or M here.
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-02 16:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-20 13:59 [PATCH 1/2] mmc: sdhci_am654: Fix TI SoC dependencies Peter Robinson
2023-12-20 13:59 ` [PATCH 2/2] mmc: sdhci_omap: " Peter Robinson
2024-01-02 10:06 ` [PATCH 1/2] mmc: sdhci_am654: " Adrian Hunter
2024-01-02 10:10 ` Peter Robinson
2024-01-02 10:22 ` Adrian Hunter
2024-01-02 10:29 ` Peter Robinson
2024-01-02 16:57 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox