From: Adrian Hunter <adrian.hunter@intel.com>
To: Judith Mendez <jm@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 4/7] mmc: sdhci_am654: Fix itapdly/otapdly array type
Date: Fri, 16 Feb 2024 19:10:06 +0200 [thread overview]
Message-ID: <ea3f337b-8e8f-4813-b0d7-aff0f08c5a5c@intel.com> (raw)
In-Reply-To: <20240207011520.3128382-5-jm@ti.com>
On 7/02/24 03:15, Judith Mendez wrote:
> While integer type works, the otap_del_sel and itap_del_sel
> arrays are manipulated as u32, so change array types to u32.
If it doesn't make any practical difference, then it is not
generally considered a "fix", at least according to stable
kernel rules, so Fixes tags are probably not warranted here.
>
> Fixes: 8ee5fc0e0b3b ("mmc: sdhci_am654: Update OTAPDLY writes")
> Fixes: a0a62497f6aa ("mmc: sdhci_am654: Add support for input tap delay")
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> drivers/mmc/host/sdhci_am654.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 935f581c05d8..35ba7d921690 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -141,8 +141,8 @@ static const struct timing_data td[] = {
>
> struct sdhci_am654_data {
> struct regmap *base;
> - int otap_del_sel[ARRAY_SIZE(td)];
> - int itap_del_sel[ARRAY_SIZE(td)];
> + u32 otap_del_sel[ARRAY_SIZE(td)];
> + u32 itap_del_sel[ARRAY_SIZE(td)];
> u32 itap_del_ena[ARRAY_SIZE(td)];
> int clkbuf_sel;
> int trm_icp;
next prev parent reply other threads:[~2024-02-16 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 1:15 [PATCH v2 0/7] Add tuning algorithm for delay chain Judith Mendez
2024-02-07 1:15 ` [PATCH v2 1/7] mmc: sdhci_am654: " Judith Mendez
2024-02-16 17:09 ` Adrian Hunter
2024-02-20 20:10 ` Judith Mendez
2024-02-28 13:21 ` Adrian Hunter
2024-02-28 15:38 ` Judith Mendez
2024-02-07 1:15 ` [PATCH v2 2/7] mmc: sdhci_am654: Write ITAPDLY for DDR52 timing Judith Mendez
2024-02-12 17:13 ` Andrew Davis
2024-02-12 17:33 ` Judith Mendez
2024-02-16 17:09 ` Adrian Hunter
2024-02-20 21:05 ` Judith Mendez
2024-02-28 13:21 ` Adrian Hunter
2024-02-28 15:40 ` Judith Mendez
2024-02-07 1:15 ` [PATCH v2 3/7] mmc: sdhci_am654: Add missing OTAP/ITAP enable Judith Mendez
2024-02-07 1:15 ` [PATCH v2 4/7] mmc: sdhci_am654: Fix itapdly/otapdly array type Judith Mendez
2024-02-16 17:10 ` Adrian Hunter [this message]
2024-02-20 20:14 ` Judith Mendez
2024-02-07 1:15 ` [PATCH v2 5/7] mmc: sdhci_am654: Update comments in sdhci_am654_set_clock Judith Mendez
2024-02-16 17:11 ` Adrian Hunter
2024-02-20 20:14 ` Judith Mendez
2024-02-07 1:15 ` [PATCH v2 6/7] mmc: sdhci_am654: Add ITAPDLYSEL in sdhci_j721e_4bit_set_clock Judith Mendez
2024-02-07 1:15 ` [PATCH v2 7/7] mmc: sdhci_am654: Fix ITAPDLY for HS400 timing Judith Mendez
2024-02-11 16:02 ` [PATCH v2 0/7] Add tuning algorithm for delay chain Francesco Dolcini
2024-02-12 16:33 ` Judith Mendez
2024-02-12 17:32 ` Francesco Dolcini
2024-02-12 17:56 ` Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3f337b-8e8f-4813-b0d7-aff0f08c5a5c@intel.com \
--to=adrian.hunter@intel.com \
--cc=jm@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox