From: Adrian Hunter <adrian.hunter@intel.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Eric Anholt <eric@anholt.net>, Gerd Hoffmann <kraxel@redhat.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
linux-mmc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] mmc: sdhci-iproc: Apply caps from bcm2835-mmc driver
Date: Thu, 5 Jan 2017 11:53:17 +0200 [thread overview]
Message-ID: <efecfb41-9696-dfb8-69da-966cfbc27078@intel.com> (raw)
In-Reply-To: <1483111474-29907-2-git-send-email-stefan.wahren@i2se.com>
On 30/12/16 17:24, Stefan Wahren wrote:
> Since the mmc module on bcm2835 neither provide a capabilities register nor
> free documentation we must rely on the downstream implementation [1].
>
> So enable the following capabilities for bcm2835:
>
> MMC_CAP_MMC_HIGHSPEED
> MMC_CAP_SD_HIGHSPEED
> MMC_CAP_DRIVER_TYPE_A
> MMC_CAP_DRIVER_TYPE_C
>
> [1] - https://github.com/raspberrypi/linux/blob/rpi-4.4.y/drivers/mmc/host/bcm2835-mmc.c
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index d7046d6..30b3fdf 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -211,14 +211,17 @@ static void sdhci_iproc_writeb(struct sdhci_host *host, u8 val, int reg)
> static const struct sdhci_pltfm_data sdhci_bcm2835_pltfm_data = {
> .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
> - SDHCI_QUIRK_MISSING_CAPS,
> + SDHCI_QUIRK_MISSING_CAPS |
> + SDHCI_QUIRK_NO_HISPD_BIT,
> .ops = &sdhci_iproc_32only_ops,
> };
>
> static const struct sdhci_iproc_data bcm2835_data = {
> .pdata = &sdhci_bcm2835_pltfm_data,
> - .caps = SDHCI_CAN_VDD_330,
> - .caps1 = 0x00000000,
> + .caps = SDHCI_CAN_VDD_330 |
> + SDHCI_CAN_DO_HISPD,
> + .caps1 = SDHCI_DRIVER_TYPE_A |
> + SDHCI_DRIVER_TYPE_C,
> .mmc_caps = 0x00000000,
> };
>
>
next prev parent reply other threads:[~2017-01-05 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 15:24 [PATCH 0/2] mmc: sdhci-iproc: Improve bcm2835 performance Stefan Wahren
2016-12-30 15:24 ` [PATCH 1/2] mmc: sdhci-iproc: Apply caps from bcm2835-mmc driver Stefan Wahren
2017-01-03 18:27 ` Eric Anholt
2017-01-03 20:23 ` Stefan Wahren
2017-01-04 18:16 ` Eric Anholt
2017-01-05 9:53 ` Adrian Hunter [this message]
2016-12-30 15:24 ` [PATCH 2/2] mmc: sdhci-iproc: Increase max_blk_size for bcm2835 Stefan Wahren
2017-01-03 18:04 ` Eric Anholt
2017-01-04 18:47 ` Scott Branden
2017-01-05 9:53 ` Adrian Hunter
2017-01-10 15:38 ` [PATCH 0/2] mmc: sdhci-iproc: Improve bcm2835 performance Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efecfb41-9696-dfb8-69da-966cfbc27078@intel.com \
--to=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=jonmason@broadcom.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox