public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Eric Anholt <eric@anholt.net>, Gerd Hoffmann <kraxel@redhat.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Scott Branden <sbranden@broadcom.com>,
	Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
	linux-mmc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] mmc: sdhci-iproc: Increase max_blk_size for bcm2835
Date: Thu, 5 Jan 2017 11:53:39 +0200	[thread overview]
Message-ID: <f869a601-38ba-daf7-e6bb-713547041c3c@intel.com> (raw)
In-Reply-To: <1483111474-29907-3-git-send-email-stefan.wahren@i2se.com>

On 30/12/16 17:24, Stefan Wahren wrote:
> According to the BCM2835 datasheet the maximum block size for the
> eMMC module is restricted to the internal data FIFO which is 1024 byte.
> But this is still an improvement to the default of 512 byte.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-iproc.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 30b3fdf..3275d49 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -218,7 +218,9 @@ static void sdhci_iproc_writeb(struct sdhci_host *host, u8 val, int reg)
>  
>  static const struct sdhci_iproc_data bcm2835_data = {
>  	.pdata = &sdhci_bcm2835_pltfm_data,
> -	.caps = SDHCI_CAN_VDD_330 |
> +	.caps = ((0x1 << SDHCI_MAX_BLOCK_SHIFT)
> +			& SDHCI_MAX_BLOCK_MASK) |
> +		SDHCI_CAN_VDD_330 |
>  		SDHCI_CAN_DO_HISPD,
>  	.caps1 = SDHCI_DRIVER_TYPE_A |
>  		 SDHCI_DRIVER_TYPE_C,
> 

  parent reply	other threads:[~2017-01-05  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 15:24 [PATCH 0/2] mmc: sdhci-iproc: Improve bcm2835 performance Stefan Wahren
2016-12-30 15:24 ` [PATCH 1/2] mmc: sdhci-iproc: Apply caps from bcm2835-mmc driver Stefan Wahren
2017-01-03 18:27   ` Eric Anholt
2017-01-03 20:23     ` Stefan Wahren
2017-01-04 18:16       ` Eric Anholt
2017-01-05  9:53   ` Adrian Hunter
2016-12-30 15:24 ` [PATCH 2/2] mmc: sdhci-iproc: Increase max_blk_size for bcm2835 Stefan Wahren
2017-01-03 18:04   ` Eric Anholt
2017-01-04 18:47     ` Scott Branden
2017-01-05  9:53   ` Adrian Hunter [this message]
2017-01-10 15:38 ` [PATCH 0/2] mmc: sdhci-iproc: Improve bcm2835 performance Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f869a601-38ba-daf7-e6bb-713547041c3c@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric@anholt.net \
    --cc=jonmason@broadcom.com \
    --cc=kraxel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox