From: Chris Ball <cjb@laptop.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
will.newton@imgtec.com, Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume
Date: Wed, 11 May 2011 23:46:17 -0400 [thread overview]
Message-ID: <m3tyd0zily.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <4DCB4D9B.8050706@samsung.com> (Jaehoon Chung's message of "Thu, 12 May 2011 12:01:47 +0900")
Hi,
On Wed, May 11 2011, Jaehoon Chung wrote:
> Hi Chris..
>
> I think you're confused something because my explanation.
>
> My means..if we use the regulator, regulator is enabled when probing.
> Then regulator is enabling until we don't disable..
>
> In order to power-save, disabled the regulator when entered suspend.
> Already in suspend function, located "regulator_disable()".
> but also located "regulator_enable()" in suspend function.
>
> So i think right that "regulator_enable()" is located in resume function.
> not in suspend function.
Thanks, I agree. I hadn't looked at the suspend function, but now I see
that it already has the disable.
Will, want to ACK this before I merge it?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-05-12 3:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 6:52 [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume Jaehoon Chung
2011-05-11 13:46 ` Chris Ball
2011-05-12 3:01 ` Jaehoon Chung
2011-05-12 3:46 ` Chris Ball [this message]
2011-05-12 9:01 ` Will Newton
2011-05-12 22:14 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyd0zily.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox