[PATCH] rust: module_param: add missing newline to pr_warn

[PATCH] rust: module_param: add missing newline to pr_warn

[Kenny Glowner]

Add a trailing newline ('\n') to the pr_warn! call in set_param to
ensure the kernel ring buffer flushes the message correctly and
prevents log line smearing.

Link: https://github.com/Rust-for-Linux/linux/issues/1139

Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>
---
 rust/kernel/module_param.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index 6a8a7a875643..fa26089be2e0 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -63,7 +63,7 @@ pub trait ModuleParam: Sized + Copy {
     // to be null here.
     if val.is_null() {
         // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn!("Null pointer passed to `module_param::set_param`\n");
         return EINVAL.to_errno();
     }
 
-- 
2.54.0

Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Miguel Ojeda]

On Thu, May 21, 2026 at 6:14 PM Kenny Glowner
<sisyphuscode0311@gmail.com> wrote:
>
> Add a trailing newline ('\n') to the pr_warn! call in set_param to
> ensure the kernel ring buffer flushes the message correctly and
> prevents log line smearing.

Did you see log smearing? IIRC this changed with the buffer rework --
it is still the convention we expect, though, so the diff contents are
good.

> Link: https://github.com/Rust-for-Linux/linux/issues/1139
>
> Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>

Andreas, Sami, Daniel, Luis, Petr: will this one go through modules
too? Otherwise, please let me know and I can take it.

(Trivial conflict with the `pr_warn_once!` one applied yesterday.)

Thanks!

Cheers,
Miguel

Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Sami Tolvanen]

On Thu, May 28, 2026 at 1:56 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Thu, May 21, 2026 at 6:14 PM Kenny Glowner
> <sisyphuscode0311@gmail.com> wrote:
> >
> > Add a trailing newline ('\n') to the pr_warn! call in set_param to
> > ensure the kernel ring buffer flushes the message correctly and
> > prevents log line smearing.
>
> Did you see log smearing? IIRC this changed with the buffer rework --
> it is still the convention we expect, though, so the diff contents are
> good.
>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1139
> >
> > Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>
>
> Andreas, Sami, Daniel, Luis, Petr: will this one go through modules
> too? Otherwise, please let me know and I can take it.

Yes, I'll take this one through modules too. Thanks, Miguel.

Sami

Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Miguel Ojeda]

On Fri, May 29, 2026 at 2:55 AM Kenny Glowner
<sisyphuscode0311@gmail.com> wrote:
>
> I hope I submitted everything correctly?  I am trying to get used to it so I can provide better assistance on more mainstream issues. That's why I started with the most minor issue I could find. I appreciate all of the feedback.

Yes, it looks fine, thanks! :)

However, in general, please try to reply to the feedback, e.g. I asked
a question about the commit message.

Cheers,
Miguel

Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Miguel Ojeda]

On Thu, May 21, 2026 at 6:14 PM Kenny Glowner
<sisyphuscode0311@gmail.com> wrote:
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1139
>
> Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>

By the way, we put tags together as one -- also please feel free to
add me as suggester like the issue says (part of the reason behind
these "good first issues" is to show you how these tags usually work),
e.g.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1139
Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>

Cheers,
Miguel

Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Sami Tolvanen]

On Thu, May 21, 2026 at 11:14:05AM -0500, Kenny Glowner wrote:
> Add a trailing newline ('\n') to the pr_warn! call in set_param to
> ensure the kernel ring buffer flushes the message correctly and
> prevents log line smearing.
> 

Applied to modules-next, thanks!

[1/1] rust: module_param: add missing newline to pr_warn_once
      commit: ae12a56ba16adcb8a06d5b3b91d4f82a092e8de3

Best regards,

	Sami