Re: [PATCH v3 13/24] dyndbg: reduce verbose/debug clutter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Loss of 'no matches' diagnostic output at verbose=1.
- [Low] Commit message output mismatch due to double space formatting.
--

commit 4e15442ecf24d2ba351dc5e3411a51965df2f4c3
Author: Jim Cromie <jim.cromie@gmail.com>

dyndbg: reduce verbose/debug clutter

This commit reduces verbose and debug clutter in dyndbg by condensing
multi-line logging output into single lines and dropping unnecessary verbose
messages during query execution and module addition.

> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 0377d9f8dcd1f..bacb55f960faf 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *query,
>  	}
>  	mutex_unlock(&ddebug_lock);
>  
> -	if (!nfound && verbose)
> -		pr_info("no matches for query\n");
> -

[Severity: Low]
Is it possible this unintentionally hides the 'no matches' diagnostic output
from ddebug_change() for users with verbose=1?

The commit message mentions that this status is retold later in the output,
but that updated line is printed using v2pr_info() in ddebug_exec_queries().
Since v2pr_info() requires verbose >= 2, users running with verbose=1 will
lose this diagnostic feedback when queries don't match.

>  	return nfound;
>  }

[ ... ]

> @@ -593,7 +587,8 @@ static int ddebug_exec_queries(char *query, const char *modname)
>  		if (!query || !*query || *query == '#')
>  			continue;
>  
> -		vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*");
> +		vpr_info("query %d: %s%s \"%s\"\n", i,
> +			 modname ? "module " : "", modname ?: "", query);

[Severity: Low]
Will this format string produce a double space in the output when modname
is NULL?

If modname is NULL in ddebug_exec_queries(), both %s formatters evaluate to
empty strings. This leaves the space after the colon and the space before
the quote adjacent, resulting in a double space before the query string.

This isn't a bug, but it contradicts the single space output explicitly shown
in the commit message.

>  
>  		rc = ddebug_exec_query(query, modname);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com?part=13