Re: [PATCH v3 18/24] dyndbg: Upgrade class param storage to u64 for 64-bit classmaps

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch causes a compilation failure by instantiating an undeclared type `struct _ddebug_class_param` for `drm_debug_bitmap`.
--

commit 907ab9c053461a5ca389ec9e173d54aa04b245d4
Author: Jim Cromie <jim.cromie@gmail.com>

dyndbg: Upgrade class param storage to u64 for 64-bit classmaps

This patch upgrades the internal storage types in the dynamic debug class
parameter structures to u64 to fully support 64-bit debug categories. It
updates the internal storage elements and the relevant dynamic debug sysfs
input parsers to use the 64-bit types.

> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
> index ded9461df5f25..9b4d8e3baacc0 100644
> --- a/drivers/gpu/drm/drm_print.c
> +++ b/drivers/gpu/drm/drm_print.c
[ ... ]
> @@ -69,7 +69,7 @@ DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, DD_CLASS_TYPE_DISJOINT_BITS, 0,
>  			"DRM_UT_DP",
>  			"DRM_UT_DRMRES");
>  
> -static struct ddebug_class_param drm_debug_bitmap = {
> +static struct _ddebug_class_param drm_debug_bitmap = {

[Severity: Low]
Does this cause a build failure when CONFIG_DRM_USE_DYNAMIC_DEBUG is enabled?

The struct is still defined as ddebug_class_param in
include/linux/dynamic_debug.h at this point in the commit history.
Instantiating the undeclared _ddebug_class_param type for drm_debug_bitmap
breaks bisectability for this patch.

I see this issue is fixed later in the patch series in commit
97c08d5dc7f7ec501676f73addba8ad9f6c67352, but it might be worth correcting
here to keep the tree building at every step.

>  	.bits = &__drm_debug,
>  	.flags = "p",
>  	.map = &drm_debug_classes,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com?part=18