Linux Modules
 help / color / mirror / Atom feed
* [PATCH v2] rust: kbuild: generate a symbol version for rust_build_error
@ 2026-11-19 10:19 Peder Bergan via B4 Relay
  0 siblings, 0 replies; only message in thread
From: Peder Bergan via B4 Relay @ 2026-11-19 10:19 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
	Daniel Almeida, Tamir Duberstein, Alexandre Courbot,
	Onur Özkan, Nathan Chancellor, Nicolas Schier, Sami Tolvanen,
	Matthew Maurer, Masahiro Yamada, Gwan-gyeong Mun, rust-for-linux,
	linux-kernel, linux-kbuild, linux-modules

From: Peder Bergan <peder.bergan@gmail.com>

CONFIG_RUST_BUILD_ASSERT_ALLOW exports rust_build_error to modules.
When CONFIG_MODVERSIONS is also enabled, modpost warns that the export
has no symbol version and records a zero CRC because the build_error.o
rule skips gendwarfksyms.

Let the existing Rust library rule run gendwarfksyms for build_error.o
so modpost gets a version calculated from the Rust definition.

Fixes: ac61506bf2d1 ("rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS")
Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Closes: https://github.com/Rust-for-Linux/linux/issues/1201
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
A clean x86-64 build with Clippy enabled generated the same nonzero CRC
for the kernel export and an external Rust module that references it.
An output tree built before this patch can reuse rust/build_error.o
without generating the CRC. Rebuild that object before relinking.
External modules built with the old CRC for rust_build_error also need
rebuilding against the corrected kernel.

OpenAI Codex assisted with coding and testing.
---
Changes in v2:
- Drop the rust/Makefile prerequisite after Gary's review.
- Omit Sami's v1 Reviewed-by because v2 changes incremental rebuild behavior.
- Link to v1: https://lore.kernel.org/rust-for-linux/20261118-fix-rust-build-error-modversions-v1-1-7c1023764f30@gmail.com/
---
 rust/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rust/Makefile b/rust/Makefile
index 0165626decbe..189c5cbdf44f 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -773,7 +773,6 @@ $(obj)/pin_init.o: $(src)/pin-init/src/lib.rs $(obj)/compiler_builtins.o \
 # treated as such so that we pass the same flags. Otherwise, for instance,
 # `rustc` will complain about missing sanitizer flags causing an ABI mismatch.
 $(obj)/build_error.o: private is-kernel-object := y
-$(obj)/build_error.o: private skip_gendwarfksyms = 1
 $(obj)/build_error.o: $(src)/build_error.rs $(obj)/compiler_builtins.o FORCE
 	+$(call if_changed_rule,rustc_library)
 

---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261118-fix-rust-build-error-modversions-4af535edc9b2

Best regards,
--  
Peder Bergan <peder.bergan@gmail.com>



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 10:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 10:19 [PATCH v2] rust: kbuild: generate a symbol version for rust_build_error Peder Bergan via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox