Re: [PATCH v4 0/2] clean up EXPORT_SYMBOL_RUST_GPL

["Gary Guo" <gary@garyguo.net>]

On Wed Nov 11, 2026 at 3:01 PM GMT, Giuliano Procida wrote:
> On Mon, 9 Nov 2026 at 15:14, Gary Guo <gary@garyguo.net> wrote:
>>
>> On Tue Nov 3, 2026 at 4:58 PM GMT, Giuliano Procida wrote:
>> > Move EXPORT_SYMBOL_RUST_GPL definitions into linux/export.h and
>> > prevent the emission of bogus type information for Rust symbols.
>> >
>> > Addressing review comments, the first commit now ensures the moves do
>> > not trigger warnings from scripts/misc-check about missing symbol
>> > exports by extending regexes to match EXPORT_SYMBOL_RUST_GPL as well.
>> >
>> > Giuliano Procida (2):
>> >   rust: move EXPORT_SYMBOL_RUST_GPL to include/linux/export.h
>> >   rust: exports: emit ___EXPORT_SYMBOL without C declarations
>> >
>> >  drivers/gpu/Makefile                      |  4 ++--
>> >  drivers/gpu/nova-core/nova_core_exports.c |  5 ++---
>> >  include/linux/export.h                    | 14 ++++++++++++++
>> >  rust/exports.c                            | 12 +-----------
>> >  scripts/misc-check                        |  4 ++--
>> >  5 files changed, 21 insertions(+), 18 deletions(-)
>>
>> How about just getting rid of EXPORT_SYMBOL_RUST_GPL completely? The only reason
>> that it exists is because EXPORT_SYMBOL_GPL in C expects the symbol to exist.
>
> At some point there may a desire to limit which Rust symbols get exported
> on a granular level like for C. But that's out of scope here.
>
>> We can simply change change rust/exports.c to rust/exports.S and get rid of
>> EXPORT_SYMBOL_RUST_GPL completely (plus saving a C compiler invoocation):
>>
>> Something like this:
>>
>> diff --git a/rust/Makefile b/rust/Makefile
>> index 0165626decbe..75de47028b60 100644
>> --- a/rust/Makefile
>> +++ b/rust/Makefile
>> @@ -571,7 +571,7 @@ rust_exports = $(NM) -p --defined-only $(1) | awk '$$2~/(T|R|D|B)/ && $$3!~/__(p
>>
>>  quiet_cmd_exports = EXPORTS $@
>>        cmd_exports = \
>> -       $(call rust_exports,$<,"EXPORT_SYMBOL_RUST_GPL(%s);\n") > $@
>> +       $(call rust_exports,$<,"EXPORT_SYMBOL_GPL(%s);\n") > $@
>>
>>  $(obj)/exports_core_generated.h: $(obj)/core.o FORCE
>>         $(call if_changed,exports)
>> diff --git a/rust/exports.c b/rust/exports.S
>> similarity index 86%
>> rename from rust/exports.c
>> rename to rust/exports.S
>> index 1b52460b0f4e..efe6bff0f983 100644
>> --- a/rust/exports.c
>> +++ b/rust/exports.S
>> @@ -13,8 +13,6 @@
>>
>>  #include <linux/export.h>
>>
>> -#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
>> -
>>  #include "exports_core_generated.h"
>>  #include "exports_bindings_generated.h"
>>  #include "exports_kernel_generated.h"
>> @@ -25,5 +23,5 @@
>>
>>  // For modules using `rust/build_error.rs`.
>>  #ifdef CONFIG_RUST_BUILD_ASSERT_ALLOW
>> -EXPORT_SYMBOL_RUST_GPL(rust_build_error);
>> +EXPORT_SYMBOL_GPL(rust_build_error);
>>  #endif
>>
>
> This doesn't cover drivers/gpu/nova-core/nova_core_exports.c though.

The same can be done to that file.

Best,
Gary