* Re: [PATCH 0/3] Add {init, exit}_sequence_fs() helper function
[not found] <20240711074859.366088-1-youling.tang@linux.dev>
@ 2024-07-11 8:26 ` Christoph Hellwig
2024-07-23 8:44 ` Youling Tang
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-11 8:26 UTC (permalink / raw)
To: Youling Tang
Cc: Alexander Viro, Christian Brauner, Jan Kara, Chris Mason,
Josef Bacik, David Sterba, tytso, Andreas Dilger, Jaegeuk Kim,
Chao Yu, linux-fsdevel, linux-btrfs, linux-ext4, linux-f2fs-devel,
linux-kernel, Luis Chamberlain, linux-modules
Can we please stop this boilerplate code an instead our __init/__exit
sections to supper multiple entires per module. This should be mostly
trivial, except that we'd probably want a single macro that has the
init and exit calls so that the order in the section is the same and
the unroll on failure can walk back form the given offset. e.g.
something like:
module_subinit(foo_bar_init, foo_bar_exit);
module_subinit(foo_bar2_init, foo_bar2_exit);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Add {init, exit}_sequence_fs() helper function
2024-07-11 8:26 ` [PATCH 0/3] Add {init, exit}_sequence_fs() helper function Christoph Hellwig
@ 2024-07-23 8:44 ` Youling Tang
2024-07-23 13:37 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Youling Tang @ 2024-07-23 8:44 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alexander Viro, Christian Brauner, Jan Kara, Chris Mason,
Josef Bacik, David Sterba, tytso, Andreas Dilger, Jaegeuk Kim,
Chao Yu, linux-fsdevel, linux-btrfs, linux-ext4, linux-f2fs-devel,
linux-kernel, Luis Chamberlain, linux-modules
Hi, Christoph
On 11/07/2024 16:26, Christoph Hellwig wrote:
> Can we please stop this boilerplate code an instead our __init/__exit
> sections to supper multiple entires per module. This should be mostly
> trivial, except that we'd probably want a single macro that has the
> init and exit calls so that the order in the section is the same and
> the unroll on failure can walk back form the given offset. e.g.
> something like:
>
> module_subinit(foo_bar_init, foo_bar_exit);
> module_subinit(foo_bar2_init, foo_bar2_exit);
>
>
Thanks for your suggestion, I re-implemented it using section mode,
and the new patch set [1] has been sent.
[1]:
https://lore.kernel.org/all/20240723083239.41533-1-youling.tang@linux.dev/T/#md81aaefe0c1fef70a0592d1580cbbb10ec9989b0
Thanks,
Youling.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Add {init, exit}_sequence_fs() helper function
2024-07-23 8:44 ` Youling Tang
@ 2024-07-23 13:37 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-23 13:37 UTC (permalink / raw)
To: Youling Tang
Cc: Christoph Hellwig, Alexander Viro, Christian Brauner, Jan Kara,
Chris Mason, Josef Bacik, David Sterba, tytso, Andreas Dilger,
Jaegeuk Kim, Chao Yu, linux-fsdevel, linux-btrfs, linux-ext4,
linux-f2fs-devel, linux-kernel, Luis Chamberlain, linux-modules
On Tue, Jul 23, 2024 at 04:44:14PM +0800, Youling Tang wrote:
> Thanks for your suggestion, I re-implemented it using section mode,
> and the new patch set [1] has been sent.
Nice! I'll review it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-23 13:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240711074859.366088-1-youling.tang@linux.dev>
2024-07-11 8:26 ` [PATCH 0/3] Add {init, exit}_sequence_fs() helper function Christoph Hellwig
2024-07-23 8:44 ` Youling Tang
2024-07-23 13:37 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox