* [PATCH Resend 1/3] mtd: omap2: Cleanup header files
@ 2014-01-10 5:54 Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 2/3] mtd: orion: Cleanup mtd-orion_nand.h header Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
0 siblings, 2 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-01-10 5:54 UTC (permalink / raw)
To: linux-mtd; +Cc: sachin.kamat, computersforpeace
Commit 2203747c9771 ("ARM: omap: move platform_data definitions")
moved the files to the current location but forgot to remove the pointer
to its previous location. Clean it up.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Pekon Gupta <pekon@ti.com>
---
include/linux/platform_data/mtd-nand-omap2.h | 2 --
include/linux/platform_data/mtd-onenand-omap2.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/include/linux/platform_data/mtd-nand-omap2.h b/include/linux/platform_data/mtd-nand-omap2.h
index 4da5bfa2147f..3e9dd6676b97 100644
--- a/include/linux/platform_data/mtd-nand-omap2.h
+++ b/include/linux/platform_data/mtd-nand-omap2.h
@@ -1,6 +1,4 @@
/*
- * arch/arm/plat-omap/include/mach/nand.h
- *
* Copyright (C) 2006 Micron Technology Inc.
*
* This program is free software; you can redistribute it and/or modify
diff --git a/include/linux/platform_data/mtd-onenand-omap2.h b/include/linux/platform_data/mtd-onenand-omap2.h
index e9a9fb188f97..56ff0e6f5ad1 100644
--- a/include/linux/platform_data/mtd-onenand-omap2.h
+++ b/include/linux/platform_data/mtd-onenand-omap2.h
@@ -1,6 +1,4 @@
/*
- * arch/arm/plat-omap/include/mach/onenand.h
- *
* Copyright (C) 2006 Nokia Corporation
* Author: Juha Yrjola
*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH Resend 2/3] mtd: orion: Cleanup mtd-orion_nand.h header
2014-01-10 5:54 [PATCH Resend 1/3] mtd: omap2: Cleanup header files Sachin Kamat
@ 2014-01-10 5:54 ` Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
1 sibling, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-01-10 5:54 UTC (permalink / raw)
To: linux-mtd; +Cc: sachin.kamat, computersforpeace
Commit c02cecb92ed4 ("ARM: orion: move platform_data definitions")
moved the file to the current location but forgot to remove the pointer
to its previous location. Clean it up. While at it also change the header
file protection macros appropriately.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
include/linux/platform_data/mtd-orion_nand.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/linux/platform_data/mtd-orion_nand.h b/include/linux/platform_data/mtd-orion_nand.h
index 9f3c180834d1..a7ce77c7c1a8 100644
--- a/include/linux/platform_data/mtd-orion_nand.h
+++ b/include/linux/platform_data/mtd-orion_nand.h
@@ -1,13 +1,11 @@
/*
- * arch/arm/plat-orion/include/plat/orion_nand.h
- *
* This file is licensed under the terms of the GNU General Public
* License version 2. This program is licensed "as is" without any
* warranty of any kind, whether express or implied.
*/
-#ifndef __PLAT_ORION_NAND_H
-#define __PLAT_ORION_NAND_H
+#ifndef __MTD_ORION_NAND_H
+#define __MTD_ORION_NAND_H
/*
* Device bus NAND private data
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
2014-01-10 5:54 [PATCH Resend 1/3] mtd: omap2: Cleanup header files Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 2/3] mtd: orion: Cleanup mtd-orion_nand.h header Sachin Kamat
@ 2014-01-10 5:54 ` Sachin Kamat
2014-01-15 6:07 ` Sachin Kamat
2014-01-21 4:29 ` Sachin Kamat
1 sibling, 2 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-01-10 5:54 UTC (permalink / raw)
To: linux-mtd; +Cc: sachin.kamat, Kukjin Kim, computersforpeace
plat/regs-nand.h is used only by S3C2410 nand driver. Since there
are no other users, merge this file into the driver code to remove
platform dependency. While at it also remove unused macros.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
---
arch/arm/plat-samsung/include/plat/regs-nand.h | 123 ------------------------
drivers/mtd/nand/s3c2410.c | 36 ++++++-
2 files changed, 35 insertions(+), 124 deletions(-)
delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
diff --git a/arch/arm/plat-samsung/include/plat/regs-nand.h b/arch/arm/plat-samsung/include/plat/regs-nand.h
deleted file mode 100644
index 238efea7b9e4..000000000000
--- a/arch/arm/plat-samsung/include/plat/regs-nand.h
+++ /dev/null
@@ -1,123 +0,0 @@
-/* arch/arm/mach-s3c2410/include/mach/regs-nand.h
- *
- * Copyright (c) 2004-2005 Simtec Electronics <linux@simtec.co.uk>
- * http://www.simtec.co.uk/products/SWLINUX/
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * S3C2410 NAND register definitions
-*/
-
-#ifndef __ASM_ARM_REGS_NAND
-#define __ASM_ARM_REGS_NAND
-
-
-#define S3C2410_NFREG(x) (x)
-
-#define S3C2410_NFCONF S3C2410_NFREG(0x00)
-#define S3C2410_NFCMD S3C2410_NFREG(0x04)
-#define S3C2410_NFADDR S3C2410_NFREG(0x08)
-#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
-#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
-#define S3C2410_NFECC S3C2410_NFREG(0x14)
-
-#define S3C2440_NFCONT S3C2410_NFREG(0x04)
-#define S3C2440_NFCMD S3C2410_NFREG(0x08)
-#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
-#define S3C2440_NFDATA S3C2410_NFREG(0x10)
-#define S3C2440_NFECCD0 S3C2410_NFREG(0x14)
-#define S3C2440_NFECCD1 S3C2410_NFREG(0x18)
-#define S3C2440_NFECCD S3C2410_NFREG(0x1C)
-#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
-#define S3C2440_NFESTAT0 S3C2410_NFREG(0x24)
-#define S3C2440_NFESTAT1 S3C2410_NFREG(0x28)
-#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
-#define S3C2440_NFMECC1 S3C2410_NFREG(0x30)
-#define S3C2440_NFSECC S3C2410_NFREG(0x34)
-#define S3C2440_NFSBLK S3C2410_NFREG(0x38)
-#define S3C2440_NFEBLK S3C2410_NFREG(0x3C)
-
-#define S3C2412_NFSBLK S3C2410_NFREG(0x20)
-#define S3C2412_NFEBLK S3C2410_NFREG(0x24)
-#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
-#define S3C2412_NFMECC_ERR0 S3C2410_NFREG(0x2C)
-#define S3C2412_NFMECC_ERR1 S3C2410_NFREG(0x30)
-#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
-#define S3C2412_NFMECC1 S3C2410_NFREG(0x38)
-#define S3C2412_NFSECC S3C2410_NFREG(0x3C)
-
-#define S3C2410_NFCONF_EN (1<<15)
-#define S3C2410_NFCONF_512BYTE (1<<14)
-#define S3C2410_NFCONF_4STEP (1<<13)
-#define S3C2410_NFCONF_INITECC (1<<12)
-#define S3C2410_NFCONF_nFCE (1<<11)
-#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
-#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
-#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
-
-#define S3C2410_NFSTAT_BUSY (1<<0)
-
-#define S3C2440_NFCONF_BUSWIDTH_8 (0<<0)
-#define S3C2440_NFCONF_BUSWIDTH_16 (1<<0)
-#define S3C2440_NFCONF_ADVFLASH (1<<3)
-#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
-#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
-#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
-
-#define S3C2440_NFCONT_LOCKTIGHT (1<<13)
-#define S3C2440_NFCONT_SOFTLOCK (1<<12)
-#define S3C2440_NFCONT_ILLEGALACC_EN (1<<10)
-#define S3C2440_NFCONT_RNBINT_EN (1<<9)
-#define S3C2440_NFCONT_RN_FALLING (1<<8)
-#define S3C2440_NFCONT_SPARE_ECCLOCK (1<<6)
-#define S3C2440_NFCONT_MAIN_ECCLOCK (1<<5)
-#define S3C2440_NFCONT_INITECC (1<<4)
-#define S3C2440_NFCONT_nFCE (1<<1)
-#define S3C2440_NFCONT_ENABLE (1<<0)
-
-#define S3C2440_NFSTAT_READY (1<<0)
-#define S3C2440_NFSTAT_nCE (1<<1)
-#define S3C2440_NFSTAT_RnB_CHANGE (1<<2)
-#define S3C2440_NFSTAT_ILLEGAL_ACCESS (1<<3)
-
-#define S3C2412_NFCONF_NANDBOOT (1<<31)
-#define S3C2412_NFCONF_ECCCLKCON (1<<30)
-#define S3C2412_NFCONF_ECC_MLC (1<<24)
-#define S3C2412_NFCONF_TACLS_MASK (7<<12) /* 1 extra bit of Tacls */
-
-#define S3C2412_NFCONT_ECC4_DIRWR (1<<18)
-#define S3C2412_NFCONT_LOCKTIGHT (1<<17)
-#define S3C2412_NFCONT_SOFTLOCK (1<<16)
-#define S3C2412_NFCONT_ECC4_ENCINT (1<<13)
-#define S3C2412_NFCONT_ECC4_DECINT (1<<12)
-#define S3C2412_NFCONT_MAIN_ECC_LOCK (1<<7)
-#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
-#define S3C2412_NFCONT_nFCE1 (1<<2)
-#define S3C2412_NFCONT_nFCE0 (1<<1)
-
-#define S3C2412_NFSTAT_ECC_ENCDONE (1<<7)
-#define S3C2412_NFSTAT_ECC_DECDONE (1<<6)
-#define S3C2412_NFSTAT_ILLEGAL_ACCESS (1<<5)
-#define S3C2412_NFSTAT_RnB_CHANGE (1<<4)
-#define S3C2412_NFSTAT_nFCE1 (1<<3)
-#define S3C2412_NFSTAT_nFCE0 (1<<2)
-#define S3C2412_NFSTAT_Res1 (1<<1)
-#define S3C2412_NFSTAT_READY (1<<0)
-
-#define S3C2412_NFECCERR_SERRDATA(x) (((x) >> 21) & 0xf)
-#define S3C2412_NFECCERR_SERRBIT(x) (((x) >> 18) & 0x7)
-#define S3C2412_NFECCERR_MERRDATA(x) (((x) >> 7) & 0x3ff)
-#define S3C2412_NFECCERR_MERRBIT(x) (((x) >> 4) & 0x7)
-#define S3C2412_NFECCERR_SPARE_ERR(x) (((x) >> 2) & 0x3)
-#define S3C2412_NFECCERR_MAIN_ERR(x) (((x) >> 2) & 0x3)
-#define S3C2412_NFECCERR_NONE (0)
-#define S3C2412_NFECCERR_1BIT (1)
-#define S3C2412_NFECCERR_MULTIBIT (2)
-#define S3C2412_NFECCERR_ECCAREA (3)
-
-
-
-#endif /* __ASM_ARM_REGS_NAND */
-
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 47fbd9a2cacf..f0918e7411d9 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -46,9 +46,43 @@
#include <linux/mtd/nand_ecc.h>
#include <linux/mtd/partitions.h>
-#include <plat/regs-nand.h>
#include <linux/platform_data/mtd-nand-s3c2410.h>
+#define S3C2410_NFREG(x) (x)
+
+#define S3C2410_NFCONF S3C2410_NFREG(0x00)
+#define S3C2410_NFCMD S3C2410_NFREG(0x04)
+#define S3C2410_NFADDR S3C2410_NFREG(0x08)
+#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
+#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
+#define S3C2410_NFECC S3C2410_NFREG(0x14)
+#define S3C2440_NFCONT S3C2410_NFREG(0x04)
+#define S3C2440_NFCMD S3C2410_NFREG(0x08)
+#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
+#define S3C2440_NFDATA S3C2410_NFREG(0x10)
+#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
+#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
+#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
+#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
+#define S3C2410_NFCONF_EN (1<<15)
+#define S3C2410_NFCONF_INITECC (1<<12)
+#define S3C2410_NFCONF_nFCE (1<<11)
+#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
+#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
+#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
+#define S3C2410_NFSTAT_BUSY (1<<0)
+#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
+#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
+#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
+#define S3C2440_NFCONT_INITECC (1<<4)
+#define S3C2440_NFCONT_nFCE (1<<1)
+#define S3C2440_NFCONT_ENABLE (1<<0)
+#define S3C2440_NFSTAT_READY (1<<0)
+#define S3C2412_NFCONF_NANDBOOT (1<<31)
+#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
+#define S3C2412_NFCONT_nFCE0 (1<<1)
+#define S3C2412_NFSTAT_READY (1<<0)
+
/* new oob placement block for use with hardware ecc generation
*/
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
2014-01-10 5:54 ` [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
@ 2014-01-15 6:07 ` Sachin Kamat
2014-01-21 4:29 ` Sachin Kamat
1 sibling, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-01-15 6:07 UTC (permalink / raw)
To: linux-mtd; +Cc: Sachin Kamat, Kukjin Kim, Brian Norris
On 10 January 2014 11:24, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> are no other users, merge this file into the driver code to remove
> platform dependency. While at it also remove unused macros.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-nand.h | 123 ------------------------
> drivers/mtd/nand/s3c2410.c | 36 ++++++-
> 2 files changed, 35 insertions(+), 124 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-nand.h b/arch/arm/plat-samsung/include/plat/regs-nand.h
> deleted file mode 100644
> index 238efea7b9e4..000000000000
> --- a/arch/arm/plat-samsung/include/plat/regs-nand.h
> +++ /dev/null
> @@ -1,123 +0,0 @@
> -/* arch/arm/mach-s3c2410/include/mach/regs-nand.h
> - *
> - * Copyright (c) 2004-2005 Simtec Electronics <linux@simtec.co.uk>
> - * http://www.simtec.co.uk/products/SWLINUX/
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * S3C2410 NAND register definitions
> -*/
> -
> -#ifndef __ASM_ARM_REGS_NAND
> -#define __ASM_ARM_REGS_NAND
> -
> -
> -#define S3C2410_NFREG(x) (x)
> -
> -#define S3C2410_NFCONF S3C2410_NFREG(0x00)
> -#define S3C2410_NFCMD S3C2410_NFREG(0x04)
> -#define S3C2410_NFADDR S3C2410_NFREG(0x08)
> -#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
> -#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
> -#define S3C2410_NFECC S3C2410_NFREG(0x14)
> -
> -#define S3C2440_NFCONT S3C2410_NFREG(0x04)
> -#define S3C2440_NFCMD S3C2410_NFREG(0x08)
> -#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
> -#define S3C2440_NFDATA S3C2410_NFREG(0x10)
> -#define S3C2440_NFECCD0 S3C2410_NFREG(0x14)
> -#define S3C2440_NFECCD1 S3C2410_NFREG(0x18)
> -#define S3C2440_NFECCD S3C2410_NFREG(0x1C)
> -#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
> -#define S3C2440_NFESTAT0 S3C2410_NFREG(0x24)
> -#define S3C2440_NFESTAT1 S3C2410_NFREG(0x28)
> -#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
> -#define S3C2440_NFMECC1 S3C2410_NFREG(0x30)
> -#define S3C2440_NFSECC S3C2410_NFREG(0x34)
> -#define S3C2440_NFSBLK S3C2410_NFREG(0x38)
> -#define S3C2440_NFEBLK S3C2410_NFREG(0x3C)
> -
> -#define S3C2412_NFSBLK S3C2410_NFREG(0x20)
> -#define S3C2412_NFEBLK S3C2410_NFREG(0x24)
> -#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
> -#define S3C2412_NFMECC_ERR0 S3C2410_NFREG(0x2C)
> -#define S3C2412_NFMECC_ERR1 S3C2410_NFREG(0x30)
> -#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
> -#define S3C2412_NFMECC1 S3C2410_NFREG(0x38)
> -#define S3C2412_NFSECC S3C2410_NFREG(0x3C)
> -
> -#define S3C2410_NFCONF_EN (1<<15)
> -#define S3C2410_NFCONF_512BYTE (1<<14)
> -#define S3C2410_NFCONF_4STEP (1<<13)
> -#define S3C2410_NFCONF_INITECC (1<<12)
> -#define S3C2410_NFCONF_nFCE (1<<11)
> -#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
> -#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
> -#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
> -
> -#define S3C2410_NFSTAT_BUSY (1<<0)
> -
> -#define S3C2440_NFCONF_BUSWIDTH_8 (0<<0)
> -#define S3C2440_NFCONF_BUSWIDTH_16 (1<<0)
> -#define S3C2440_NFCONF_ADVFLASH (1<<3)
> -#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
> -#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
> -#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
> -
> -#define S3C2440_NFCONT_LOCKTIGHT (1<<13)
> -#define S3C2440_NFCONT_SOFTLOCK (1<<12)
> -#define S3C2440_NFCONT_ILLEGALACC_EN (1<<10)
> -#define S3C2440_NFCONT_RNBINT_EN (1<<9)
> -#define S3C2440_NFCONT_RN_FALLING (1<<8)
> -#define S3C2440_NFCONT_SPARE_ECCLOCK (1<<6)
> -#define S3C2440_NFCONT_MAIN_ECCLOCK (1<<5)
> -#define S3C2440_NFCONT_INITECC (1<<4)
> -#define S3C2440_NFCONT_nFCE (1<<1)
> -#define S3C2440_NFCONT_ENABLE (1<<0)
> -
> -#define S3C2440_NFSTAT_READY (1<<0)
> -#define S3C2440_NFSTAT_nCE (1<<1)
> -#define S3C2440_NFSTAT_RnB_CHANGE (1<<2)
> -#define S3C2440_NFSTAT_ILLEGAL_ACCESS (1<<3)
> -
> -#define S3C2412_NFCONF_NANDBOOT (1<<31)
> -#define S3C2412_NFCONF_ECCCLKCON (1<<30)
> -#define S3C2412_NFCONF_ECC_MLC (1<<24)
> -#define S3C2412_NFCONF_TACLS_MASK (7<<12) /* 1 extra bit of Tacls */
> -
> -#define S3C2412_NFCONT_ECC4_DIRWR (1<<18)
> -#define S3C2412_NFCONT_LOCKTIGHT (1<<17)
> -#define S3C2412_NFCONT_SOFTLOCK (1<<16)
> -#define S3C2412_NFCONT_ECC4_ENCINT (1<<13)
> -#define S3C2412_NFCONT_ECC4_DECINT (1<<12)
> -#define S3C2412_NFCONT_MAIN_ECC_LOCK (1<<7)
> -#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
> -#define S3C2412_NFCONT_nFCE1 (1<<2)
> -#define S3C2412_NFCONT_nFCE0 (1<<1)
> -
> -#define S3C2412_NFSTAT_ECC_ENCDONE (1<<7)
> -#define S3C2412_NFSTAT_ECC_DECDONE (1<<6)
> -#define S3C2412_NFSTAT_ILLEGAL_ACCESS (1<<5)
> -#define S3C2412_NFSTAT_RnB_CHANGE (1<<4)
> -#define S3C2412_NFSTAT_nFCE1 (1<<3)
> -#define S3C2412_NFSTAT_nFCE0 (1<<2)
> -#define S3C2412_NFSTAT_Res1 (1<<1)
> -#define S3C2412_NFSTAT_READY (1<<0)
> -
> -#define S3C2412_NFECCERR_SERRDATA(x) (((x) >> 21) & 0xf)
> -#define S3C2412_NFECCERR_SERRBIT(x) (((x) >> 18) & 0x7)
> -#define S3C2412_NFECCERR_MERRDATA(x) (((x) >> 7) & 0x3ff)
> -#define S3C2412_NFECCERR_MERRBIT(x) (((x) >> 4) & 0x7)
> -#define S3C2412_NFECCERR_SPARE_ERR(x) (((x) >> 2) & 0x3)
> -#define S3C2412_NFECCERR_MAIN_ERR(x) (((x) >> 2) & 0x3)
> -#define S3C2412_NFECCERR_NONE (0)
> -#define S3C2412_NFECCERR_1BIT (1)
> -#define S3C2412_NFECCERR_MULTIBIT (2)
> -#define S3C2412_NFECCERR_ECCAREA (3)
> -
> -
> -
> -#endif /* __ASM_ARM_REGS_NAND */
> -
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 47fbd9a2cacf..f0918e7411d9 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -46,9 +46,43 @@
> #include <linux/mtd/nand_ecc.h>
> #include <linux/mtd/partitions.h>
>
> -#include <plat/regs-nand.h>
> #include <linux/platform_data/mtd-nand-s3c2410.h>
>
> +#define S3C2410_NFREG(x) (x)
> +
> +#define S3C2410_NFCONF S3C2410_NFREG(0x00)
> +#define S3C2410_NFCMD S3C2410_NFREG(0x04)
> +#define S3C2410_NFADDR S3C2410_NFREG(0x08)
> +#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
> +#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
> +#define S3C2410_NFECC S3C2410_NFREG(0x14)
> +#define S3C2440_NFCONT S3C2410_NFREG(0x04)
> +#define S3C2440_NFCMD S3C2410_NFREG(0x08)
> +#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
> +#define S3C2440_NFDATA S3C2410_NFREG(0x10)
> +#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
> +#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
> +#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
> +#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
> +#define S3C2410_NFCONF_EN (1<<15)
> +#define S3C2410_NFCONF_INITECC (1<<12)
> +#define S3C2410_NFCONF_nFCE (1<<11)
> +#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
> +#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
> +#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
> +#define S3C2410_NFSTAT_BUSY (1<<0)
> +#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
> +#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
> +#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
> +#define S3C2440_NFCONT_INITECC (1<<4)
> +#define S3C2440_NFCONT_nFCE (1<<1)
> +#define S3C2440_NFCONT_ENABLE (1<<0)
> +#define S3C2440_NFSTAT_READY (1<<0)
> +#define S3C2412_NFCONF_NANDBOOT (1<<31)
> +#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
> +#define S3C2412_NFCONT_nFCE0 (1<<1)
> +#define S3C2412_NFSTAT_READY (1<<0)
> +
> /* new oob placement block for use with hardware ecc generation
> */
>
> --
> 1.7.9.5
>
Gentle ping.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
2014-01-10 5:54 ` [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
2014-01-15 6:07 ` Sachin Kamat
@ 2014-01-21 4:29 ` Sachin Kamat
2014-01-23 1:20 ` kgene
1 sibling, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2014-01-21 4:29 UTC (permalink / raw)
To: linux-mtd; +Cc: Sachin Kamat, Kukjin Kim, Brian Norris
On 10 January 2014 11:24, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> are no other users, merge this file into the driver code to remove
> platform dependency. While at it also remove unused macros.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-nand.h | 123 ------------------------
> drivers/mtd/nand/s3c2410.c | 36 ++++++-
> 2 files changed, 35 insertions(+), 124 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-nand.h b/arch/arm/plat-samsung/include/plat/regs-nand.h
> deleted file mode 100644
> index 238efea7b9e4..000000000000
> --- a/arch/arm/plat-samsung/include/plat/regs-nand.h
> +++ /dev/null
> @@ -1,123 +0,0 @@
> -/* arch/arm/mach-s3c2410/include/mach/regs-nand.h
> - *
> - * Copyright (c) 2004-2005 Simtec Electronics <linux@simtec.co.uk>
> - * http://www.simtec.co.uk/products/SWLINUX/
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * S3C2410 NAND register definitions
> -*/
> -
> -#ifndef __ASM_ARM_REGS_NAND
> -#define __ASM_ARM_REGS_NAND
> -
> -
> -#define S3C2410_NFREG(x) (x)
> -
> -#define S3C2410_NFCONF S3C2410_NFREG(0x00)
> -#define S3C2410_NFCMD S3C2410_NFREG(0x04)
> -#define S3C2410_NFADDR S3C2410_NFREG(0x08)
> -#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
> -#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
> -#define S3C2410_NFECC S3C2410_NFREG(0x14)
> -
> -#define S3C2440_NFCONT S3C2410_NFREG(0x04)
> -#define S3C2440_NFCMD S3C2410_NFREG(0x08)
> -#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
> -#define S3C2440_NFDATA S3C2410_NFREG(0x10)
> -#define S3C2440_NFECCD0 S3C2410_NFREG(0x14)
> -#define S3C2440_NFECCD1 S3C2410_NFREG(0x18)
> -#define S3C2440_NFECCD S3C2410_NFREG(0x1C)
> -#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
> -#define S3C2440_NFESTAT0 S3C2410_NFREG(0x24)
> -#define S3C2440_NFESTAT1 S3C2410_NFREG(0x28)
> -#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
> -#define S3C2440_NFMECC1 S3C2410_NFREG(0x30)
> -#define S3C2440_NFSECC S3C2410_NFREG(0x34)
> -#define S3C2440_NFSBLK S3C2410_NFREG(0x38)
> -#define S3C2440_NFEBLK S3C2410_NFREG(0x3C)
> -
> -#define S3C2412_NFSBLK S3C2410_NFREG(0x20)
> -#define S3C2412_NFEBLK S3C2410_NFREG(0x24)
> -#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
> -#define S3C2412_NFMECC_ERR0 S3C2410_NFREG(0x2C)
> -#define S3C2412_NFMECC_ERR1 S3C2410_NFREG(0x30)
> -#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
> -#define S3C2412_NFMECC1 S3C2410_NFREG(0x38)
> -#define S3C2412_NFSECC S3C2410_NFREG(0x3C)
> -
> -#define S3C2410_NFCONF_EN (1<<15)
> -#define S3C2410_NFCONF_512BYTE (1<<14)
> -#define S3C2410_NFCONF_4STEP (1<<13)
> -#define S3C2410_NFCONF_INITECC (1<<12)
> -#define S3C2410_NFCONF_nFCE (1<<11)
> -#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
> -#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
> -#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
> -
> -#define S3C2410_NFSTAT_BUSY (1<<0)
> -
> -#define S3C2440_NFCONF_BUSWIDTH_8 (0<<0)
> -#define S3C2440_NFCONF_BUSWIDTH_16 (1<<0)
> -#define S3C2440_NFCONF_ADVFLASH (1<<3)
> -#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
> -#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
> -#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
> -
> -#define S3C2440_NFCONT_LOCKTIGHT (1<<13)
> -#define S3C2440_NFCONT_SOFTLOCK (1<<12)
> -#define S3C2440_NFCONT_ILLEGALACC_EN (1<<10)
> -#define S3C2440_NFCONT_RNBINT_EN (1<<9)
> -#define S3C2440_NFCONT_RN_FALLING (1<<8)
> -#define S3C2440_NFCONT_SPARE_ECCLOCK (1<<6)
> -#define S3C2440_NFCONT_MAIN_ECCLOCK (1<<5)
> -#define S3C2440_NFCONT_INITECC (1<<4)
> -#define S3C2440_NFCONT_nFCE (1<<1)
> -#define S3C2440_NFCONT_ENABLE (1<<0)
> -
> -#define S3C2440_NFSTAT_READY (1<<0)
> -#define S3C2440_NFSTAT_nCE (1<<1)
> -#define S3C2440_NFSTAT_RnB_CHANGE (1<<2)
> -#define S3C2440_NFSTAT_ILLEGAL_ACCESS (1<<3)
> -
> -#define S3C2412_NFCONF_NANDBOOT (1<<31)
> -#define S3C2412_NFCONF_ECCCLKCON (1<<30)
> -#define S3C2412_NFCONF_ECC_MLC (1<<24)
> -#define S3C2412_NFCONF_TACLS_MASK (7<<12) /* 1 extra bit of Tacls */
> -
> -#define S3C2412_NFCONT_ECC4_DIRWR (1<<18)
> -#define S3C2412_NFCONT_LOCKTIGHT (1<<17)
> -#define S3C2412_NFCONT_SOFTLOCK (1<<16)
> -#define S3C2412_NFCONT_ECC4_ENCINT (1<<13)
> -#define S3C2412_NFCONT_ECC4_DECINT (1<<12)
> -#define S3C2412_NFCONT_MAIN_ECC_LOCK (1<<7)
> -#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
> -#define S3C2412_NFCONT_nFCE1 (1<<2)
> -#define S3C2412_NFCONT_nFCE0 (1<<1)
> -
> -#define S3C2412_NFSTAT_ECC_ENCDONE (1<<7)
> -#define S3C2412_NFSTAT_ECC_DECDONE (1<<6)
> -#define S3C2412_NFSTAT_ILLEGAL_ACCESS (1<<5)
> -#define S3C2412_NFSTAT_RnB_CHANGE (1<<4)
> -#define S3C2412_NFSTAT_nFCE1 (1<<3)
> -#define S3C2412_NFSTAT_nFCE0 (1<<2)
> -#define S3C2412_NFSTAT_Res1 (1<<1)
> -#define S3C2412_NFSTAT_READY (1<<0)
> -
> -#define S3C2412_NFECCERR_SERRDATA(x) (((x) >> 21) & 0xf)
> -#define S3C2412_NFECCERR_SERRBIT(x) (((x) >> 18) & 0x7)
> -#define S3C2412_NFECCERR_MERRDATA(x) (((x) >> 7) & 0x3ff)
> -#define S3C2412_NFECCERR_MERRBIT(x) (((x) >> 4) & 0x7)
> -#define S3C2412_NFECCERR_SPARE_ERR(x) (((x) >> 2) & 0x3)
> -#define S3C2412_NFECCERR_MAIN_ERR(x) (((x) >> 2) & 0x3)
> -#define S3C2412_NFECCERR_NONE (0)
> -#define S3C2412_NFECCERR_1BIT (1)
> -#define S3C2412_NFECCERR_MULTIBIT (2)
> -#define S3C2412_NFECCERR_ECCAREA (3)
> -
> -
> -
> -#endif /* __ASM_ARM_REGS_NAND */
> -
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 47fbd9a2cacf..f0918e7411d9 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -46,9 +46,43 @@
> #include <linux/mtd/nand_ecc.h>
> #include <linux/mtd/partitions.h>
>
> -#include <plat/regs-nand.h>
> #include <linux/platform_data/mtd-nand-s3c2410.h>
>
> +#define S3C2410_NFREG(x) (x)
> +
> +#define S3C2410_NFCONF S3C2410_NFREG(0x00)
> +#define S3C2410_NFCMD S3C2410_NFREG(0x04)
> +#define S3C2410_NFADDR S3C2410_NFREG(0x08)
> +#define S3C2410_NFDATA S3C2410_NFREG(0x0C)
> +#define S3C2410_NFSTAT S3C2410_NFREG(0x10)
> +#define S3C2410_NFECC S3C2410_NFREG(0x14)
> +#define S3C2440_NFCONT S3C2410_NFREG(0x04)
> +#define S3C2440_NFCMD S3C2410_NFREG(0x08)
> +#define S3C2440_NFADDR S3C2410_NFREG(0x0C)
> +#define S3C2440_NFDATA S3C2410_NFREG(0x10)
> +#define S3C2440_NFSTAT S3C2410_NFREG(0x20)
> +#define S3C2440_NFMECC0 S3C2410_NFREG(0x2C)
> +#define S3C2412_NFSTAT S3C2410_NFREG(0x28)
> +#define S3C2412_NFMECC0 S3C2410_NFREG(0x34)
> +#define S3C2410_NFCONF_EN (1<<15)
> +#define S3C2410_NFCONF_INITECC (1<<12)
> +#define S3C2410_NFCONF_nFCE (1<<11)
> +#define S3C2410_NFCONF_TACLS(x) ((x)<<8)
> +#define S3C2410_NFCONF_TWRPH0(x) ((x)<<4)
> +#define S3C2410_NFCONF_TWRPH1(x) ((x)<<0)
> +#define S3C2410_NFSTAT_BUSY (1<<0)
> +#define S3C2440_NFCONF_TACLS(x) ((x)<<12)
> +#define S3C2440_NFCONF_TWRPH0(x) ((x)<<8)
> +#define S3C2440_NFCONF_TWRPH1(x) ((x)<<4)
> +#define S3C2440_NFCONT_INITECC (1<<4)
> +#define S3C2440_NFCONT_nFCE (1<<1)
> +#define S3C2440_NFCONT_ENABLE (1<<0)
> +#define S3C2440_NFSTAT_READY (1<<0)
> +#define S3C2412_NFCONF_NANDBOOT (1<<31)
> +#define S3C2412_NFCONT_INIT_MAIN_ECC (1<<5)
> +#define S3C2412_NFCONT_nFCE0 (1<<1)
> +#define S3C2412_NFSTAT_READY (1<<0)
> +
> /* new oob placement block for use with hardware ecc generation
> */
>
> --
> 1.7.9.5
>
Hi Brian,
Any comments on this patch?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
2014-01-21 4:29 ` Sachin Kamat
@ 2014-01-23 1:20 ` kgene
2014-01-23 1:36 ` Brian Norris
0 siblings, 1 reply; 7+ messages in thread
From: kgene @ 2014-01-23 1:20 UTC (permalink / raw)
To: 'Sachin Kamat', linux-mtd; +Cc: 'Brian Norris'
Sachin Kamat wrote:
>
> On 10 January 2014 11:24, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> > are no other users, merge this file into the driver code to remove
> > platform dependency. While at it also remove unused macros.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
> > ---
> > arch/arm/plat-samsung/include/plat/regs-nand.h | 123
------------------
> ------
> > drivers/mtd/nand/s3c2410.c | 36 ++++++-
> > 2 files changed, 35 insertions(+), 124 deletions(-)
> > delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
2014-01-23 1:20 ` kgene
@ 2014-01-23 1:36 ` Brian Norris
0 siblings, 0 replies; 7+ messages in thread
From: Brian Norris @ 2014-01-23 1:36 UTC (permalink / raw)
To: kgene; +Cc: 'Sachin Kamat', linux-mtd
On Thu, Jan 23, 2014 at 10:20:05AM +0900, kgene@kernel.org wrote:
> Sachin Kamat wrote:
> >
> > On 10 January 2014 11:24, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > > plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> > > are no other users, merge this file into the driver code to remove
> > > platform dependency. While at it also remove unused macros.
> > >
> > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > > Cc: Kukjin Kim <kgene.kim@samsung.com>
Sorry, I sent this through compile-testing a few days ago but didn't get
back to it.
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Cool. Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-23 1:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 5:54 [PATCH Resend 1/3] mtd: omap2: Cleanup header files Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 2/3] mtd: orion: Cleanup mtd-orion_nand.h header Sachin Kamat
2014-01-10 5:54 ` [PATCH Resend 3/3] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
2014-01-15 6:07 ` Sachin Kamat
2014-01-21 4:29 ` Sachin Kamat
2014-01-23 1:20 ` kgene
2014-01-23 1:36 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox