Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im

From: Michael Walle <michael@walle.cc>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Cc: ~sircmpwn/email-test-drive@lists.sr.ht, patrick@stwcx.xyz,
	garnermic@fb.com, Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
Date: Thu, 06 Oct 2022 13:52:33 +0200	[thread overview]
Message-ID: <0dde4fa6ddeefa23314dbdcd1dd1b28b@walle.cc> (raw)
In-Reply-To: <20221006070841.2106194-1-Delphine_CC_Chiu@Wiwynn.com>

Hi,

Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> Add support for winbond w25q01jv-im chip.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c 
> b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..2b02b05ceb0a 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
> = {
>  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },
> +	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)

The name should be w25q01jvm.

> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ) },

That flash should support SFDP, so please try the following:
+	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },

Also, we require an SFDP dump for new flash submissions, see [1].

-michael

[1] 
https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/