* [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
@ 2022-10-06 7:08 Delphine CC Chiu
2022-10-06 11:52 ` Michael Walle
0 siblings, 1 reply; 9+ messages in thread
From: Delphine CC Chiu @ 2022-10-06 7:08 UTC (permalink / raw)
To: ~sircmpwn/email-test-drive
Cc: patrick, garnermic, Delphine CC Chiu, Tudor Ambarus,
Pratyush Yadav, Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Add support for winbond w25q01jv-im chip.
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ffaa24055259..2b02b05ceb0a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ) },
};
/**
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
2022-10-06 7:08 [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im Delphine CC Chiu
@ 2022-10-06 11:52 ` Michael Walle
2022-10-06 20:26 ` Patrick Williams
2022-10-06 20:40 ` Patrick Williams
0 siblings, 2 replies; 9+ messages in thread
From: Michael Walle @ 2022-10-06 11:52 UTC (permalink / raw)
To: Delphine CC Chiu
Cc: ~sircmpwn/email-test-drive, patrick, garnermic, Tudor Ambarus,
Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Hi,
Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> Add support for winbond w25q01jv-im chip.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..2b02b05ceb0a 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
The name should be w25q01jvm.
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> + SPI_NOR_QUAD_READ) },
That flash should support SFDP, so please try the following:
+ { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
Also, we require an SFDP dump for new flash submissions, see [1].
-michael
[1]
https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
2022-10-06 11:52 ` Michael Walle
@ 2022-10-06 20:26 ` Patrick Williams
2022-10-06 20:40 ` Patrick Williams
1 sibling, 0 replies; 9+ messages in thread
From: Patrick Williams @ 2022-10-06 20:26 UTC (permalink / raw)
To: Michael Walle, Potin Lai
Cc: Delphine CC Chiu, ~sircmpwn/email-test-drive, garnermic,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1477 bytes --]
On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > = {
> > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ) },
> > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>
> The name should be w25q01jvm.
>
> > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > + SPI_NOR_QUAD_READ) },
>
> That flash should support SFDP, so please try the following:
> + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
>
> Also, we require an SFDP dump for new flash submissions, see [1].
>
> -michael
>
> [1]
> https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/
It looks like this was already attempted to be added:
https://lore.kernel.org/all/20220222085148.21594-1-potin.lai@quantatw.com/
Potin, do you have an update?
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
2022-10-06 11:52 ` Michael Walle
2022-10-06 20:26 ` Patrick Williams
@ 2022-10-06 20:40 ` Patrick Williams
2022-10-06 23:04 ` Patrick Williams
1 sibling, 1 reply; 9+ messages in thread
From: Patrick Williams @ 2022-10-06 20:40 UTC (permalink / raw)
To: Michael Walle
Cc: Delphine CC Chiu, ~sircmpwn/email-test-drive, garnermic,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel, Potin Lai
[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]
On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > = {
> > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ) },
> > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>
> The name should be w25q01jvm.
>
> > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > + SPI_NOR_QUAD_READ) },
>
> That flash should support SFDP, so please try the following:
> + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard
requirement or can we delay until the QEMU support can be written?
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
2022-10-06 20:40 ` Patrick Williams
@ 2022-10-06 23:04 ` Patrick Williams
0 siblings, 0 replies; 9+ messages in thread
From: Patrick Williams @ 2022-10-06 23:04 UTC (permalink / raw)
To: Michael Walle
Cc: Delphine CC Chiu, ~sircmpwn/email-test-drive, garnermic,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel, Potin Lai
[-- Attachment #1.1: Type: text/plain, Size: 1781 bytes --]
On Thu, Oct 06, 2022 at 03:40:48PM -0500, Patrick Williams wrote:
> On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> > Hi,
> >
> > Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > > Add support for winbond w25q01jv-im chip.
> > >
> > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > > ---
> > > drivers/mtd/spi-nor/winbond.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/mtd/spi-nor/winbond.c
> > > b/drivers/mtd/spi-nor/winbond.c
> > > index ffaa24055259..2b02b05ceb0a 100644
> > > --- a/drivers/mtd/spi-nor/winbond.c
> > > +++ b/drivers/mtd/spi-nor/winbond.c
> > > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > > = {
> > > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > > SPI_NOR_QUAD_READ) },
> > > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
> >
> > The name should be w25q01jvm.
> >
> > > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > > + SPI_NOR_QUAD_READ) },
> >
> > That flash should support SFDP, so please try the following:
> > + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
>
> It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard
> requirement or can we delay until the QEMU support can be written?
It turns out that there is some tentative support in QEMU for giving
SFDP information now. I've sent a patch building on top of that for the
w25q01jvq chip and updated Potin's patch-set to v4 that I mentioned
elsewhere in this thread.
It looks like the w25q01jvq I pointed to in Potin's patch-set and the
w25q01jvm being proposed here are slightly different chips.
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
@ 2022-10-06 7:38 Delphine CC Chiu
0 siblings, 0 replies; 9+ messages in thread
From: Delphine CC Chiu @ 2022-10-06 7:38 UTC (permalink / raw)
To: ~sircmpwn/email-test-drive
Cc: patrick, garnermic, Delphine CC Chiu, Tudor Ambarus,
Pratyush Yadav, Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Add support for winbond w25q01jv-im chip.
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ffaa24055259..2b02b05ceb0a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ) },
};
/**
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
@ 2022-10-06 7:39 Delphine CC Chiu
0 siblings, 0 replies; 9+ messages in thread
From: Delphine CC Chiu @ 2022-10-06 7:39 UTC (permalink / raw)
To: ~sircmpwn/email-test-drive
Cc: patrick, garnermic, Delphine CC Chiu, Tudor Ambarus,
Pratyush Yadav, Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Add support for winbond w25q01jv-im chip.
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ffaa24055259..2b02b05ceb0a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ) },
};
/**
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
@ 2022-10-07 5:21 Delphine CC Chiu
2022-11-21 13:58 ` Tudor.Ambarus
0 siblings, 1 reply; 9+ messages in thread
From: Delphine CC Chiu @ 2022-10-07 5:21 UTC (permalink / raw)
To: michael
Cc: patrick, garnermic, Delphine CC Chiu, Tudor Ambarus,
Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Add support for winbond w25q01jv-im chip.
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ffaa24055259..850f2fd867aa 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -139,6 +139,8 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jvm", INFO(0xef7021, 0, 64 * 1024, 2048)
+ PARSE_SFDP },
};
/**
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im
2022-10-07 5:21 Delphine CC Chiu
@ 2022-11-21 13:58 ` Tudor.Ambarus
0 siblings, 0 replies; 9+ messages in thread
From: Tudor.Ambarus @ 2022-11-21 13:58 UTC (permalink / raw)
To: Delphine_CC_Chiu, michael
Cc: patrick, garnermic, pratyush, miquel.raynal, richard, vigneshr,
linux-mtd, linux-kernel
On 10/7/22 08:21, Delphine CC Chiu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add support for winbond w25q01jv-im chip.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..850f2fd867aa 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,8 @@ static const struct flash_info winbond_nor_parts[] = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jvm", INFO(0xef7021, 0, 64 * 1024, 2048)
> + PARSE_SFDP },
> };
>
Hi!
The flash entry is not really needed as all its features and parameters
are initialized by parsing SFDP, so we can instead use the spi-nor-generic
driver that was introduced by Michael at:
https://lore.kernel.org/linux-mtd/166903807811.85501.6803386075881922742.b4-ty@microchip.com/T/#t
--
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-11-21 13:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 7:08 [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im Delphine CC Chiu
2022-10-06 11:52 ` Michael Walle
2022-10-06 20:26 ` Patrick Williams
2022-10-06 20:40 ` Patrick Williams
2022-10-06 23:04 ` Patrick Williams
-- strict thread matches above, loose matches on Subject: below --
2022-10-06 7:38 Delphine CC Chiu
2022-10-06 7:39 Delphine CC Chiu
2022-10-07 5:21 Delphine CC Chiu
2022-11-21 13:58 ` Tudor.Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox