[PATCH] ubi_create_gluebi: Initialize static volumes with vol->used_bytes

[PATCH] ubi_create_gluebi: Initialize static volumes with vol->used_bytes

[Jan Altenberg]

Hi all,

I came across a problem which seems to be present since:

commit 941dfb07ed91451b1c58626a0d258dfdf468b593
UBI: set correct gluebi device size

ubi_create_gluebi() leaves mtd->size = 0 for static volumes. So even
existing static volumes are initialized with a size of 0.
See attached patch (applies on top of latest git).

Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>

---
 drivers/mtd/ubi/gluebi.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/mtd/ubi/gluebi.c
===================================================================
--- linux-2.6.orig/drivers/mtd/ubi/gluebi.c
+++ linux-2.6/drivers/mtd/ubi/gluebi.c
@@ -291,11 +291,12 @@ int ubi_create_gluebi(struct ubi_device 
 	/*
 	 * In case of dynamic volume, MTD device size is just volume size. In
 	 * case of a static volume the size is equivalent to the amount of data
-	 * bytes, which is zero at this moment and will be changed after volume
-	 * update.
+	 * bytes.
 	 */
 	if (vol->vol_type == UBI_DYNAMIC_VOLUME)
 		mtd->size = vol->usable_leb_size * vol->reserved_pebs;
+	else
+		mtd->size = vol->used_bytes;
 
 	if (add_mtd_device(mtd)) {
 		ubi_err("cannot not add MTD device\n");

Re: [PATCH] ubi_create_gluebi: Initialize static volumes with vol->used_bytes

[Artem Bityutskiy]

On Fri, 2008-03-28 at 16:13 +0100, Jan Altenberg wrote:
> Hi all,
> 
> I came across a problem which seems to be present since:
> 
> commit 941dfb07ed91451b1c58626a0d258dfdf468b593
> UBI: set correct gluebi device size
> 
> ubi_create_gluebi() leaves mtd->size = 0 for static volumes. So even
> existing static volumes are initialized with a size of 0.
> See attached patch (applies on top of latest git).

Fair enough, applied, thank you!

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)