public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] jffs2: Move erasing from write_super to GC.
Date: Tue, 30 Mar 2010 15:57:34 +0300	[thread overview]
Message-ID: <1269953854.6648.4.camel@localhost> (raw)
In-Reply-To: <1269079399-27087-1-git-send-email-Joakim.Tjernlund@transmode.se>

On Sat, 2010-03-20 at 11:03 +0100, Joakim Tjernlund wrote:
> Erasing blocks is a form of GC and therefore it should live in the
> GC task. By moving it there two problems will be solved:
> 1) unmounting will not hang until all pending blocks has
>    been erased.
> 2) Erasing can be paused by sending a SIGSTOP to the GC thread which
>    allowes for time critical tasks to work in peace.
> 
> Since erasing now is in the GC thread, erases should trigger
> the GC task instead.
> wbuf.c still wants to flush its buffer via write_super so
> invent jffs2_dirty_trigger() and use that in wbuf.
> Remove surplus call to jffs2_erase_pending_trigger() in erase.c
> and remove jffs2_garbage_collect_trigger() from write_super as
> of now write_super() should only commit dirty data to disk.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---

Chatted with dwmw2, and he is fine with your patch, so I'll add it to my
l2 tree, thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  reply	other threads:[~2010-03-30 12:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20 10:03 [PATCH] jffs2: Move erasing from write_super to GC Joakim Tjernlund
2010-03-30 12:57 ` Artem Bityutskiy [this message]
2010-03-30 13:04   ` Joakim Tjernlund
2010-05-13 17:16 ` David Woodhouse
2010-05-14 10:10   ` Joakim Tjernlund
2010-05-14 10:35     ` David Woodhouse
2010-05-14 11:07       ` Joakim Tjernlund
2010-05-14 12:12         ` Joakim Tjernlund
2010-05-17 15:35           ` Joakim Tjernlund
2010-05-18 15:46           ` David Woodhouse
2010-05-18 18:19             ` Joakim Tjernlund
2010-05-18 18:37           ` David Woodhouse
2010-05-18 18:59             ` David Woodhouse
2010-05-18 22:44               ` Joakim Tjernlund
2010-05-18 23:42                 ` David Woodhouse
2010-05-19  9:47                   ` Joakim Tjernlund
2010-05-19 10:05                     ` David Woodhouse
2010-05-19 10:36                       ` Joakim Tjernlund
2010-05-19 16:49                     ` David Woodhouse
2010-05-19 20:06                       ` Joakim Tjernlund
2010-05-19 21:24                         ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2010-02-26  9:19 Joakim Tjernlund
2010-02-15  7:40 Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269953854.6648.4.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=Joakim.Tjernlund@transmode.se \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox