From: David Woodhouse <dwmw2@infradead.org>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] jffs2: Move erasing from write_super to GC.
Date: Wed, 19 May 2010 11:05:31 +0100 [thread overview]
Message-ID: <1274263531.6930.9695.camel@macbook.infradead.org> (raw)
In-Reply-To: <OFC16DD021.1CA8E33E-ONC1257728.002FE329-C1257728.0035CD60@transmode.se>
On Wed, 2010-05-19 at 11:47 +0200, Joakim Tjernlund wrote:
>
> This looks like a typo and I had to change that to:
> BUG_ON(spin_is_locked(&c->erase_completion_lock));
Hm, no -- we want it to BUG() if the spinlock is _NOT_ locked.
You're building on UP, without preemption or spinlock debugging. In that
case, spinlocks are a no-op. So spin_trylock() _always_ succeeds, and
spin_is_locked() always returns 0.
It should be lockdep_assert_held(), I think.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-05-19 10:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 10:03 [PATCH] jffs2: Move erasing from write_super to GC Joakim Tjernlund
2010-03-30 12:57 ` Artem Bityutskiy
2010-03-30 13:04 ` Joakim Tjernlund
2010-05-13 17:16 ` David Woodhouse
2010-05-14 10:10 ` Joakim Tjernlund
2010-05-14 10:35 ` David Woodhouse
2010-05-14 11:07 ` Joakim Tjernlund
2010-05-14 12:12 ` Joakim Tjernlund
2010-05-17 15:35 ` Joakim Tjernlund
2010-05-18 15:46 ` David Woodhouse
2010-05-18 18:19 ` Joakim Tjernlund
2010-05-18 18:37 ` David Woodhouse
2010-05-18 18:59 ` David Woodhouse
2010-05-18 22:44 ` Joakim Tjernlund
2010-05-18 23:42 ` David Woodhouse
2010-05-19 9:47 ` Joakim Tjernlund
2010-05-19 10:05 ` David Woodhouse [this message]
2010-05-19 10:36 ` Joakim Tjernlund
2010-05-19 16:49 ` David Woodhouse
2010-05-19 20:06 ` Joakim Tjernlund
2010-05-19 21:24 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2010-02-26 9:19 Joakim Tjernlund
2010-02-15 7:40 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274263531.6930.9695.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox