MTD: 2 patches

MTD: 2 patches

[Maxim Levitsky]

Hi,

I recently found bug that I intoduced.
I seen that just once, but it is obivous that code is wrong.
Also I want to trim warning on sm_ftl, I think it was a bit too scary.


Best regards,
        Maxim Levitsky

[PATCH 1/2] MTD: blkdevs: fix crash related to sysfs attributes.

[Maxim Levitsky]

Remove the attributes group before disk to avoid use after free

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
 drivers/mtd/mtd_blkdevs.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 03e19c1..75aba70 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -409,13 +409,14 @@ int del_mtd_blktrans_dev(struct mtd_blktrans_dev *old)
 		BUG();
 	}
 
-	/* Stop new requests to arrive */
-	del_gendisk(old->disk);
-
 	if (old->disk_attributes)
 		sysfs_remove_group(&disk_to_dev(old->disk)->kobj,
 						old->disk_attributes);
 
+	/* Stop new requests to arrive */
+	del_gendisk(old->disk);
+
+
 	/* Stop the thread */
 	kthread_stop(old->thread);
 
-- 
1.7.0.4

[PATCH 2/2] MTD: update description on sm_ftl

[Maxim Levitsky]

I think that scary description can go now...

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
 drivers/mtd/Kconfig |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index f8210bf..8664133 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -311,11 +311,14 @@ config SM_FTL
 	select MTD_BLKDEVS
 	select MTD_NAND_ECC
 	help
-	  This enables new and very EXPERMENTAL support for SmartMedia/xD
+	  This enables EXPERMENTAL R/W support for SmartMedia/xD
 	  FTL (Flash translation layer).
-	  Write support isn't yet well tested, therefore this code IS likely to
-	  eat your card, so please don't use it together with valuable data.
-	  Use readonly driver (CONFIG_SSFDC) instead.
+	  Write support is only lightly tested, therefore this driver
+	  isn't recommended to use with valuable data (anyway if you have
+	  valuable data, do backups regardsless of software/hardware you
+	  use, because you never know what will eat your data...)
+	  If you only need R/O access, you can use older R/O driver
+	  (CONFIG_SSFDC)
 
 config MTD_OOPS
 	tristate "Log panic/oops to an MTD buffer"
-- 
1.7.0.4

Re: MTD: 2 patches

[Maxim Levitsky]

On Wed, 2010-07-28 at 18:53 +0300, Maxim Levitsky wrote: 
> Hi,
> 
> I recently found bug that I intoduced.
> I seen that just once, but it is obivous that code is wrong.
> Also I want to trim warning on sm_ftl, I think it was a bit too scary.

Any update?

Best regards,
Maxim Levitsky

Re: MTD: 2 patches

[Maxim Levitsky]

On Sat, 2010-07-31 at 15:38 +0300, Maxim Levitsky wrote: 
> On Wed, 2010-07-28 at 18:53 +0300, Maxim Levitsky wrote: 
> > Hi,
> > 
> > I recently found bug that I intoduced.
> > I seen that just once, but it is obivous that code is wrong.
> > Also I want to trim warning on sm_ftl, I think it was a bit too scary.
> 
> Any update?
Any update? 
> 

Best regards,
	Maxim Levitsky

Re: MTD: 2 patches

[Artem Bityutskiy]

On Tue, 2010-08-03 at 23:19 +0300, Maxim Levitsky wrote:
> On Sat, 2010-07-31 at 15:38 +0300, Maxim Levitsky wrote: 
> > On Wed, 2010-07-28 at 18:53 +0300, Maxim Levitsky wrote: 
> > > Hi,
> > > 
> > > I recently found bug that I intoduced.
> > > I seen that just once, but it is obivous that code is wrong.
> > > Also I want to trim warning on sm_ftl, I think it was a bit too scary.
> > 
> > Any update?
> Any update? 

Taken to my l2-mtd-2.6.git / master

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)